From: Mike Rapoport <rppt@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Peter Xu <peterx@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Axel Rasmussen <axelrasmussen@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
James Houghton <jthoughton@google.com>,
Nikita Kalyazin <kalyazin@amazon.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Ujwal Kundur <ujwal.kundur@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Michal Hocko <mhocko@suse.com>,
Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
Hugh Dickins <hughd@google.com>,
Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH v3 1/4] mm: Introduce vm_uffd_ops API
Date: Tue, 30 Sep 2025 12:07:50 +0200 [thread overview]
Message-ID: <aNur9nbdnlykqbU7@kernel.org> (raw)
In-Reply-To: <f1da3505-f17f-4829-80c1-696b1d99057d@redhat.com>
On Tue, Sep 30, 2025 at 11:36:53AM +0200, David Hildenbrand wrote:
> On 26.09.25 23:16, Peter Xu wrote:
> > + /**
> > + * uffd_get_folio: Handler to resolve UFFDIO_CONTINUE request.
>
> Just wondering if we could incorporate the "continue" / "minor" aspect into
> the callback name.
>
> uffd_minor_get_folio / uffd_continue_get_folio
>
> Or do you see use of that callback in the context of other uffd features?
If someone picks the gauntlet of refactoring the loop in mcopy_atomic()
we'd need a similar callback for uffd copy. And as I see it it would be
different enough to warrant emphasizing minor/continue in the name here.
I also think we can drop uffd_ prefix for the callback, as it's called as
uffd_ops->get_folio() or whatever it's be called.
> --
> Cheers
>
> David / dhildenb
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-09-30 10:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 21:16 [PATCH v3 0/4] mm/userfaultfd: modulize memory types Peter Xu
2025-09-26 21:16 ` [PATCH v3 1/4] mm: Introduce vm_uffd_ops API Peter Xu
2025-09-30 9:36 ` David Hildenbrand
2025-09-30 10:07 ` Mike Rapoport [this message]
2025-09-30 10:18 ` David Hildenbrand
2025-09-30 18:39 ` Peter Xu
2025-09-30 18:48 ` Peter Xu
2025-09-30 19:19 ` David Hildenbrand
2025-09-30 20:35 ` Peter Xu
2025-10-01 13:58 ` David Hildenbrand
2025-10-01 14:35 ` Peter Xu
2025-10-01 14:39 ` David Hildenbrand
2025-10-03 14:02 ` Peter Xu
2025-10-06 13:38 ` David Hildenbrand
2025-10-06 19:06 ` Liam R. Howlett
2025-10-06 21:02 ` Peter Xu
2025-10-07 3:31 ` Liam R. Howlett
2025-10-07 13:51 ` Peter Xu
2025-10-07 16:03 ` Liam R. Howlett
2025-10-07 16:14 ` David Hildenbrand
2025-10-07 16:47 ` Peter Xu
2025-10-07 18:46 ` Liam R. Howlett
2025-10-07 19:41 ` Peter Xu
2025-10-07 20:23 ` David Hildenbrand
2025-10-07 20:25 ` Liam R. Howlett
2025-10-07 20:40 ` Peter Xu
2025-09-26 21:16 ` [PATCH v3 2/4] mm/shmem: Support " Peter Xu
2025-09-26 21:16 ` [PATCH v3 3/4] mm/hugetlb: " Peter Xu
2025-09-26 21:16 ` [PATCH v3 4/4] mm: Apply vm_uffd_ops API to core mm Peter Xu
2025-09-30 9:23 ` David Hildenbrand
2025-09-30 18:52 ` Peter Xu
2025-09-30 19:49 ` [PATCH v3 0/4] mm/userfaultfd: modulize memory types Liam R. Howlett
2025-09-30 20:45 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNur9nbdnlykqbU7@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jthoughton@google.com \
--cc=kalyazin@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=surenb@google.com \
--cc=ujwal.kundur@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.