Re: [PATCH v2 2/2] selftests: netfilter: add nfnetlink ACK handling tests

[Florian Westphal <fw@strlen.de>]

Nikolaos Gkarlis <nickgarlis@gmail.com> wrote:
> Add nfnetlink selftests to validate the ACKs sent after a batch
> message. These tests verify that:
> 
>   - ACKs are always received in order.
>   - Module loading does not affect the responses.
>   - The number of ACKs matches the number of requests, unless a
>     fatal error occurs.

Thanks for the tests!

This looks good to me, justs one minor nit.

Can you drop the shell wrapper and just call unshare(CLONE_NEWNET) from the
fixture setup function?

> +++ b/tools/testing/selftests/net/netfilter/Makefile
> @@ -37,6 +37,7 @@ TEST_PROGS += nft_zones_many.sh
>  TEST_PROGS += rpath.sh
>  TEST_PROGS += vxlan_mtu_frag.sh
>  TEST_PROGS += xt_string.sh
> +TEST_PROGS += nfnetlink.sh

>  TEST_PROGS_EXTENDED = nft_concat_range_perf.sh
>  
> @@ -46,6 +47,7 @@ TEST_GEN_FILES += conntrack_dump_flush
>  TEST_GEN_FILES += conntrack_reverse_clash
>  TEST_GEN_FILES += sctp_collision
>  TEST_GEN_FILES += udpclash
> +TEST_GEN_FILES += nfnetlink

replacing this with
TEST_GEN_PROGS = nfnetlink

... should make kselftests run this prog just like it does
for TEST_PROGS shell scripts.