Re: [PATCH v2 2/2] selftests: netfilter: add nfnetlink ACK handling tests

[Florian Westphal <fw@strlen.de>]

Nikolaos Gkarlis <nickgarlis@gmail.com> wrote:
> Florian Westphal <fw@strlen.de> wrote:
> > Is this to exercise replay path?
> > Perhaps add a comment to the subtest that depends on this.
> 
> Yes, that is the goal. I can add a comment to the test explaining that.

Thanks!

> verifies the number of ACKs returned and their order, which is what
> bf2ac490d28c broke. I have tested both builtin and non-existent cases.

Great.

> What do you think about something like this?
> 
> +++ b/tools/testing/selftests/net/netfilter/nfnetlink.sh
> @@ -0,0 +1,5 @@
> +#!/bin/bash
> +
> +# If nft_ct is a module and is loaded, remove it to test module auto-loading

Looks good, can you also mention that if removal doesn't work this is
ok?

> +lsmod | grep -q "^nft_ct\b" && rmmod nft_ct

You could just "rmmod nft_ct 2>/dev/null" with
above comment in place.

> +./nfnetlink

Since you need the shell wraper for the rmmod you could
also make this

unshare -n ./nfnetlink and not do it in the .c setup
function.  Your call.

> I can send a v3 if that looks okay to you.

Yes please.  You can just send a v3 of the test case,
no need to resend the fix.