Re: [libnftnl PATCH] utils: Introduce nftnl_parse_str_attr()

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Oct 16, 2025 at 01:01:42PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > Wrap the common parsing of string attributes into a function. Apart from
> > slightly reducing code size, this unifies callers in conditional freeing
> > of the field in case it was set before (missing in twelve spots) and
> > error checking for failing strdup()-calls (missing in four spots).
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > ---
> >  include/utils.h         |  3 +++
> >  src/chain.c             | 33 +++++++++------------------------
> >  src/expr/dynset.c       | 12 +++++-------
> >  src/expr/flow_offload.c | 12 +++++-------
> >  src/expr/log.c          | 13 ++++---------
> >  src/expr/lookup.c       | 12 +++++-------
> >  src/expr/objref.c       | 18 ++++++++----------
> >  src/flowtable.c         | 24 ++++++++----------------
> >  src/object.c            | 14 ++++++--------
> >  src/rule.c              | 22 ++++++----------------
> >  src/set.c               | 22 ++++++----------------
> >  src/set_elem.c          | 38 +++++++++++++-------------------------
> >  src/table.c             | 11 +++--------
> >  src/trace.c             | 28 ++++++++++------------------
> >  src/utils.c             | 15 +++++++++++++++
> >  15 files changed, 106 insertions(+), 171 deletions(-)
> 
> Nice compaction.
> 
> Acked-by: Florian Westphal <fw@strlen.de>

I started different infrastructure to compact this, I can rebase at
some point on top this if Phil is having time to make cleanups.