From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [libnftnl PATCH] utils: Introduce nftnl_parse_str_attr()
Date: Sat, 18 Oct 2025 21:13:05 +0200 [thread overview]
Message-ID: <aPPmwQ6O_4L03DSe@orbyte.nwl.cc> (raw)
In-Reply-To: <20251015202436.17486-1-phil@nwl.cc>
On Wed, Oct 15, 2025 at 10:24:36PM +0200, Phil Sutter wrote:
> Wrap the common parsing of string attributes into a function. Apart from
> slightly reducing code size, this unifies callers in conditional freeing
> of the field in case it was set before (missing in twelve spots) and
> error checking for failing strdup()-calls (missing in four spots).
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
prev parent reply other threads:[~2025-10-18 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 20:24 [libnftnl PATCH] utils: Introduce nftnl_parse_str_attr() Phil Sutter
2025-10-16 11:01 ` Florian Westphal
2025-10-16 13:52 ` Pablo Neira Ayuso
2025-10-16 14:03 ` Phil Sutter
2025-10-18 19:13 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPPmwQ6O_4L03DSe@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.