* [PATCH] drm/sitronix/st7571-i2c: Remove unneeded semicolon
@ 2025-07-29 4:26 Chen Ni
2025-07-29 13:07 ` Marcus Folkesson
0 siblings, 1 reply; 7+ messages in thread
From: Chen Ni @ 2025-07-29 4:26 UTC (permalink / raw)
To: marcus.folkesson, maarten.lankhorst, mripard, tzimmermann,
airlied, simona
Cc: dri-devel, linux-kernel, Chen Ni
Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
index 453eb7e045e5..35e0a86c7dc8 100644
--- a/drivers/gpu/drm/sitronix/st7571-i2c.c
+++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
@@ -319,7 +319,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
memcpy(st7571->hwbuf, vmap->vaddr, size);
break;
- };
+ }
}
static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/sitronix/st7571-i2c: Remove unneeded semicolon
2025-07-29 4:26 [PATCH] drm/sitronix/st7571-i2c: Remove " Chen Ni
@ 2025-07-29 13:07 ` Marcus Folkesson
0 siblings, 0 replies; 7+ messages in thread
From: Marcus Folkesson @ 2025-07-29 13:07 UTC (permalink / raw)
To: Chen Ni
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
On Tue, Jul 29, 2025 at 12:26:20PM +0800, Chen Ni wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
@ 2025-10-22 6:10 Marcus Folkesson
2025-10-22 6:52 ` Thomas Zimmermann
2025-10-22 7:59 ` Marcus Folkesson
0 siblings, 2 replies; 7+ messages in thread
From: Marcus Folkesson @ 2025-10-22 6:10 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: dri-devel, linux-kernel, kernel test robot, Marcus Folkesson
Fix style issue reported by Kernel test robot.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
--- a/drivers/gpu/drm/sitronix/st7571-i2c.c
+++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
@@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
memcpy(st7571->hwbuf, vmap->vaddr, size);
break;
- };
+ }
}
static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
---
base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
change-id: 20251022-st7571-semicolon-bc5287cde264
Best regards,
--
Marcus Folkesson <marcus.folkesson@gmail.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
2025-10-22 6:10 [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon Marcus Folkesson
@ 2025-10-22 6:52 ` Thomas Zimmermann
2025-10-22 7:59 ` Marcus Folkesson
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Zimmermann @ 2025-10-22 6:52 UTC (permalink / raw)
To: Marcus Folkesson, Maarten Lankhorst, Maxime Ripard, David Airlie,
Simona Vetter
Cc: dri-devel, linux-kernel, kernel test robot
Am 22.10.25 um 08:10 schrieb Marcus Folkesson:
> Fix style issue reported by Kernel test robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
> size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
> memcpy(st7571->hwbuf, vmap->vaddr, size);
> break;
> - };
> + }
> }
>
> static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
>
> ---
> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
> change-id: 20251022-st7571-semicolon-bc5287cde264
>
> Best regards,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
2025-10-22 6:10 [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon Marcus Folkesson
2025-10-22 6:52 ` Thomas Zimmermann
@ 2025-10-22 7:59 ` Marcus Folkesson
2025-10-22 8:19 ` Thomas Zimmermann
1 sibling, 1 reply; 7+ messages in thread
From: Marcus Folkesson @ 2025-10-22 7:59 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: dri-devel, linux-kernel, kernel test robot
[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]
On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
> Fix style issue reported by Kernel test robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
> size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
> memcpy(st7571->hwbuf, vmap->vaddr, size);
> break;
> - };
> + }
> }
>
> static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
>
> ---
> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
> change-id: 20251022-st7571-semicolon-bc5287cde264
>
> Best regards,
> --
> Marcus Folkesson <marcus.folkesson@gmail.com>
>
Pushed to drm-misc-fixes.
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
2025-10-22 7:59 ` Marcus Folkesson
@ 2025-10-22 8:19 ` Thomas Zimmermann
2025-10-22 8:32 ` Marcus Folkesson
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Zimmermann @ 2025-10-22 8:19 UTC (permalink / raw)
To: Marcus Folkesson, Maarten Lankhorst, Maxime Ripard, David Airlie,
Simona Vetter
Cc: dri-devel, linux-kernel, kernel test robot
Hi
Am 22.10.25 um 09:59 schrieb Marcus Folkesson:
> On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
>> Fix style issue reported by Kernel test robot.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> ---
>> drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
>> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
>> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
>> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
>> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
>> size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
>> memcpy(st7571->hwbuf, vmap->vaddr, size);
>> break;
>> - };
>> + }
>> }
>>
>> static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
>>
>> ---
>> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
>> change-id: 20251022-st7571-semicolon-bc5287cde264
>>
>> Best regards,
>> --
>> Marcus Folkesson <marcus.folkesson@gmail.com>
>>
> Pushed to drm-misc-fixes.
This does not belong into -fixes as it's not a bug fix, just a style
issue. Also misses the Fixes tag. No need to revert, but please keep in
mind for next time.
Best regards
Thomas
>
> Best regards,
> Marcus Folkesson
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
2025-10-22 8:19 ` Thomas Zimmermann
@ 2025-10-22 8:32 ` Marcus Folkesson
0 siblings, 0 replies; 7+ messages in thread
From: Marcus Folkesson @ 2025-10-22 8:32 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter,
dri-devel, linux-kernel, kernel test robot
[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]
Hi,
On Wed, Oct 22, 2025 at 10:19:13AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 22.10.25 um 09:59 schrieb Marcus Folkesson:
> > On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
> > > Fix style issue reported by Kernel test robot.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
> > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > > ---
> > > drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> > > index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
> > > --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> > > +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> > > @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
> > > size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
> > > memcpy(st7571->hwbuf, vmap->vaddr, size);
> > > break;
> > > - };
> > > + }
> > > }
> > > static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
> > >
> > > ---
> > > base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
> > > change-id: 20251022-st7571-semicolon-bc5287cde264
> > >
> > > Best regards,
> > > --
> > > Marcus Folkesson <marcus.folkesson@gmail.com>
> > >
> > Pushed to drm-misc-fixes.
s/drm-misc-fixes/drm-misc-next/
>
> This does not belong into -fixes as it's not a bug fix, just a style issue.
> Also misses the Fixes tag. No need to revert, but please keep in mind for
> next time.
Ooops, it was pushed to drm-misc-next, not drm-misc-fixes.
Sorry for the typo and thanks for pointing it out.
Best regards,
Marcus Folkesson
>
> Best regards
> Thomas
>
> >
> > Best regards,
> > Marcus Folkesson
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-22 8:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 6:10 [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon Marcus Folkesson
2025-10-22 6:52 ` Thomas Zimmermann
2025-10-22 7:59 ` Marcus Folkesson
2025-10-22 8:19 ` Thomas Zimmermann
2025-10-22 8:32 ` Marcus Folkesson
-- strict thread matches above, loose matches on Subject: below --
2025-07-29 4:26 [PATCH] drm/sitronix/st7571-i2c: Remove " Chen Ni
2025-07-29 13:07 ` Marcus Folkesson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.