From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
alok.a.tiwarilinux@gmail.com
Subject: Re: [Intel-wired-lan] [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message
Date: Wed, 22 Oct 2025 15:48:12 +0100 [thread overview]
Message-ID: <aPjurC9zjCBX1A_P@horms.kernel.org> (raw)
In-Reply-To: <20251021193203.2393365-1-alok.a.tiwari@oracle.com>
On Tue, Oct 21, 2025 at 12:32:01PM -0700, Alok Tiwari wrote:
> Corrected the dev_warn format string:
> - "Vlan id %d\n is not added" -> "Vlan id %d is not added\n"
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Interesting, there seem to be some other cases of this, at least under
net/divers. Do you plan to address those too?
In any case, looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
alok.a.tiwarilinux@gmail.com
Subject: Re: [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message
Date: Wed, 22 Oct 2025 15:48:12 +0100 [thread overview]
Message-ID: <aPjurC9zjCBX1A_P@horms.kernel.org> (raw)
In-Reply-To: <20251021193203.2393365-1-alok.a.tiwari@oracle.com>
On Tue, Oct 21, 2025 at 12:32:01PM -0700, Alok Tiwari wrote:
> Corrected the dev_warn format string:
> - "Vlan id %d\n is not added" -> "Vlan id %d is not added\n"
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Interesting, there seem to be some other cases of this, at least under
net/divers. Do you plan to address those too?
In any case, looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-22 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 19:32 [Intel-wired-lan] [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message Alok Tiwari
2025-10-21 19:32 ` Alok Tiwari
2025-10-22 14:48 ` Simon Horman [this message]
2025-10-22 14:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPjurC9zjCBX1A_P@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.