All of lore.kernel.org
 help / color / mirror / Atom feed
From: Troy Mitchell <troy.mitchell@linux.dev>
To: "Michal Wilczynski" <m.wilczynski@samsung.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Drew Fustini" <fustini@kernel.org>,
	"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org,
	Troy Mitchell <troy.mitchell@linux.dev>
Subject: Re: [PATCH 3/4] pwm: th1520: Use module_pwm_platform_driver! macro
Date: Wed, 29 Oct 2025 08:59:49 +0800	[thread overview]
Message-ID: <aQFnBYc7C-nQslJ9@kernel.org> (raw)
In-Reply-To: <20251028-pwm_fixes-v1-3-25a532d31998@samsung.com>

On Tue, Oct 28, 2025 at 01:22:34PM +0100, Michal Wilczynski wrote:
> The `pwm_th1520` Rust driver calls C functions from the `PWM` namespace,
> triggering `modpost` warnings due to missing namespace import
> declarations in its `.modinfo` section.
> 
> Fix these warnings and simplify the module declaration by switching from
> the generic `kernel::module_platform_driver!` macro to the newly
> introduced PWM-specific `kernel::module_pwm_platform_driver!` macro.
> The new macro automatically handles the required `imports_ns: ["PWM"]`
> declaration.
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>

WARNING: multiple messages have this Message-ID (diff)
From: Troy Mitchell <troy.mitchell@linux.dev>
To: "Michal Wilczynski" <m.wilczynski@samsung.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Drew Fustini" <fustini@kernel.org>,
	"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org,
	Troy Mitchell <troy.mitchell@linux.dev>
Subject: Re: [PATCH 3/4] pwm: th1520: Use module_pwm_platform_driver! macro
Date: Wed, 29 Oct 2025 08:59:49 +0800	[thread overview]
Message-ID: <aQFnBYc7C-nQslJ9@kernel.org> (raw)
In-Reply-To: <20251028-pwm_fixes-v1-3-25a532d31998@samsung.com>

On Tue, Oct 28, 2025 at 01:22:34PM +0100, Michal Wilczynski wrote:
> The `pwm_th1520` Rust driver calls C functions from the `PWM` namespace,
> triggering `modpost` warnings due to missing namespace import
> declarations in its `.modinfo` section.
> 
> Fix these warnings and simplify the module declaration by switching from
> the generic `kernel::module_platform_driver!` macro to the newly
> introduced PWM-specific `kernel::module_pwm_platform_driver!` macro.
> The new macro automatically handles the required `imports_ns: ["PWM"]`
> declaration.
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-10-29  1:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20251028122315eucas1p159b65037cf6f3f710c1917e2464399b5@eucas1p1.samsung.com>
2025-10-28 12:22 ` [PATCH 0/4] Introduce import_ns support for Rust Michal Wilczynski
2025-10-28 12:22   ` Michal Wilczynski
2025-10-28 12:22   ` [PATCH 1/4] rust: macros: Add support for 'imports_ns' to module! Michal Wilczynski
2025-10-28 12:22     ` Michal Wilczynski
2025-10-28 22:32     ` Elle Rhumsaa
2025-10-28 22:32       ` Elle Rhumsaa
2025-10-29 12:47     ` Alice Ryhl
2025-10-29 12:47       ` Alice Ryhl
2025-10-31  7:47     ` Uwe Kleine-König
2025-10-31  7:47       ` Uwe Kleine-König
2025-10-31 12:57       ` Miguel Ojeda
2025-10-31 12:57         ` Miguel Ojeda
2025-10-31 13:12         ` Daniel Gomez
2025-10-31 13:12           ` Daniel Gomez
2025-11-01  8:06           ` Uwe Kleine-König
2025-11-01  8:06             ` Uwe Kleine-König
2025-10-28 12:22   ` [PATCH 2/4] rust: pwm: Add module_pwm_platform_driver! macro Michal Wilczynski
2025-10-28 12:22     ` Michal Wilczynski
2025-10-28 22:32     ` Elle Rhumsaa
2025-10-28 22:32       ` Elle Rhumsaa
2025-10-28 12:22   ` [PATCH 3/4] pwm: th1520: Use " Michal Wilczynski
2025-10-28 12:22     ` Michal Wilczynski
2025-10-28 22:33     ` Elle Rhumsaa
2025-10-28 22:33       ` Elle Rhumsaa
2025-10-29  0:59     ` Troy Mitchell [this message]
2025-10-29  0:59       ` Troy Mitchell
2025-10-28 12:22   ` [PATCH 4/4] pwm: th1520: Fix clippy warning for redundant struct field init Michal Wilczynski
2025-10-28 12:22     ` Michal Wilczynski
2025-10-28 22:33     ` Elle Rhumsaa
2025-10-28 22:33       ` Elle Rhumsaa
2025-10-30 22:05     ` Uwe Kleine-König
2025-10-30 22:05       ` Uwe Kleine-König
2025-10-29 10:04   ` [PATCH 0/4] Introduce import_ns support for Rust Uwe Kleine-König
2025-10-29 10:04     ` Uwe Kleine-König
2025-10-29 11:07     ` Michal Wilczynski
2025-10-29 11:07       ` Michal Wilczynski
2025-10-29 18:18     ` Miguel Ojeda
2025-10-29 18:18       ` Miguel Ojeda
2025-10-29 18:51       ` Michal Wilczynski
2025-10-29 18:51         ` Michal Wilczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQFnBYc7C-nQslJ9@kernel.org \
    --to=troy.mitchell@linux.dev \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=fustini@kernel.org \
    --cc=gary@garyguo.net \
    --cc=guoren@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lossin@kernel.org \
    --cc=m.wilczynski@samsung.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tmgross@umich.edu \
    --cc=ukleinek@kernel.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.