From: Yao Zi <ziyao@disroot.org>
To: Qiang Ma <maqianga@uniontech.com>,
ardb@kernel.org, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr
Cc: linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi/riscv: Remove the useless failure return message print
Date: Fri, 31 Oct 2025 04:12:25 +0000 [thread overview]
Message-ID: <aQQ3KUap1cB73HOm@pie> (raw)
In-Reply-To: <20251031024328.735161-1-maqianga@uniontech.com>
On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote:
> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> the return value is always 0, and this debug message
> is unnecessary. So, remove it.
Should we make efi_create_mapping() return void at the same time, if it
will never fail?
Regards,
Yao Zi
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
WARNING: multiple messages have this Message-ID (diff)
From: Yao Zi <ziyao@disroot.org>
To: Qiang Ma <maqianga@uniontech.com>,
ardb@kernel.org, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr
Cc: linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi/riscv: Remove the useless failure return message print
Date: Fri, 31 Oct 2025 04:12:25 +0000 [thread overview]
Message-ID: <aQQ3KUap1cB73HOm@pie> (raw)
In-Reply-To: <20251031024328.735161-1-maqianga@uniontech.com>
On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote:
> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> the return value is always 0, and this debug message
> is unnecessary. So, remove it.
Should we make efi_create_mapping() return void at the same time, if it
will never fail?
Regards,
Yao Zi
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-10-31 4:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 2:43 [PATCH] efi/riscv: Remove the useless failure return message print Qiang Ma
2025-10-31 2:43 ` Qiang Ma
2025-10-31 4:12 ` Yao Zi [this message]
2025-10-31 4:12 ` Yao Zi
2025-10-31 6:52 ` Ard Biesheuvel
2025-10-31 6:52 ` Ard Biesheuvel
2025-10-31 8:27 ` Yao Zi
2025-10-31 8:27 ` Yao Zi
2025-11-26 0:27 ` Paul Walmsley
2025-11-26 0:27 ` Paul Walmsley
2025-11-26 2:49 ` Qiang Ma
2025-11-26 2:49 ` Qiang Ma
2025-11-26 2:52 ` Qiang Ma
2025-11-26 2:52 ` Qiang Ma
2025-11-26 6:38 ` Ard Biesheuvel
2025-11-26 6:38 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQQ3KUap1cB73HOm@pie \
--to=ziyao@disroot.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maqianga@uniontech.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.