Re: [PATCH v9 05/12] NFSD: Remove alignment size checking

[Mike Snitzer <snitzer@kernel.org>]

On Tue, Nov 04, 2025 at 09:14:09AM -0500, Chuck Lever wrote:
> On 11/4/25 6:52 AM, Christoph Hellwig wrote:
> > On Tue, Nov 04, 2025 at 09:30:25AM +1100, NeilBrown wrote:
> >> On Tue, 04 Nov 2025, Chuck Lever wrote:
> >>> From: Chuck Lever <chuck.lever@oracle.com>
> >>>
> >>> Noted that the NFS client's LOCALIO code still retains this check.
> >>
> >> It might be good to capture here *why* the check is removed.
> >> Is it because alignments never exceed PAGE_SIZE, or because the code is
> >> quite capable of handling larger alignments
> >> (I haven't been following the conversation closely..)
> > 
> > I'm still trying to understand why it was added in the first place :)
> 
> I'm trying to understand what action you'd like me to take. Should I
> drop this patch?

Maybe just fold it into Patch 3 and we can forget it ever happened?

The reason it was added is this NFSD_IO_DIRECT feature has had many
iterations, and in the earlier days on its development I was
allocating extra _pages_ to accomodate the misaligned head and tail
pages _outside_ of the sunrpc provided buffers.  This started with
READ and copy-n-paste brought it to the WRITE side IIRC.

> > But I'm also completely lost in the maze of fixup patches.
> Several people have asked me to collapse the fix-ups into a single
> patch. We would lose some history and attributions doing that. Does
> anyone have other thoughts?

The series has a mix of renames that distract, but overall what
matters most is where the code ends up. I don't have a problem with
the various changes when I look at the result (and because I've
acclimated to the evolution). Probably best to just leave well enough
alone given Jeff, myself and Neil have provided various Reviewed-by

Mike