Re: [PATCH v9 05/12] NFSD: Remove alignment size checking

[Mike Snitzer <snitzer@kernel.org>]

On Wed, Nov 05, 2025 at 09:38:33AM -0500, Chuck Lever wrote:
> On 11/5/25 7:52 AM, Christoph Hellwig wrote:
> > On Tue, Nov 04, 2025 at 09:14:09AM -0500, Chuck Lever wrote:
> >>>> It might be good to capture here *why* the check is removed.
> >>>> Is it because alignments never exceed PAGE_SIZE, or because the code is
> >>>> quite capable of handling larger alignments
> >>>> (I haven't been following the conversation closely..)
> >>>
> >>> I'm still trying to understand why it was added in the first place :)
> >>
> >> I'm trying to understand what action you'd like me to take. Should I
> >> drop this patch?
> > 
> > With "it" I meant the check.  І think Mike explain this was due to a
> > PAGE_SIZE bound buffer originally, and in that context it makes sense.
> > Without the explanation I don't understand the rationale for adding the
> > check in the first place.
> 
> Agreed, Mike's original patch has no explanatory comment, and there
> needs to be one. Mike, can you suggest a one or two sentence comment
> and I will replace this patch with one that adds the comment.

I replied yesterday suggesting you just fold 5 into 3.

> >>> But I'm also completely lost in the maze of fixup patches.
> >> Several people have asked me to collapse the fix-ups into a single
> >> patch. We would lose some history and attributions doing that. Does
> >> anyone have other thoughts?
> > 
> > The action I'd see is to collapse the series into reviewable chunks.
> > I.e., fold the addition of the direct I/O writes into a single patch
> > that has all the policy decisions and documents them, leaving only
> > clearly separate prep patches separate.
> Meaning: combine the patches from 3/12 to 12/12 into a single patch.

But if you elect to fold all of 3 to 12, definitely add your
Co-developed-by: