From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 04/15] gpio: pl061: Use modern PM macros
Date: Wed, 19 Nov 2025 17:50:34 +0200 [thread overview]
Message-ID: <aR3nSmSlV9bfqi3k@smile.fi.intel.com> (raw)
In-Reply-To: <20251119144327.13345-5-jszhang@kernel.org>
On Wed, Nov 19, 2025 at 10:43:16PM +0800, Jisheng Zhang wrote:
> Use the modern PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>
> The pl061_context_save_regs structure is always embedded into struct
> pl061 to simplify code, so this brings a tiny 8 bytes memory overhead
> for !CONFIG_PM_SLEP.
As I pointed out you have a typo here
_SLEEP
...
> -#ifdef CONFIG_PM
> struct pl061_context_save_regs csave_regs;
> -#endif
Just leave it here, and drop that paragraph from the commit message.
The rest is fine.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-19 15:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 14:43 [PATCH v3 00/15] gpio: Use modern PM macros Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 01/15] gpio: dwapb: " Jisheng Zhang
2025-11-19 15:42 ` Andy Shevchenko
2025-11-19 15:51 ` Jisheng Zhang
2025-11-19 16:11 ` Andy Shevchenko
2025-11-19 16:04 ` Jisheng Zhang
2025-11-19 16:27 ` Andy Shevchenko
2025-11-19 14:43 ` [PATCH v3 02/15] gpio: brcmstb: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 03/15] gpio: htc-egpio: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 04/15] gpio: pl061: " Jisheng Zhang
2025-11-19 15:50 ` Andy Shevchenko [this message]
2025-11-19 14:43 ` [PATCH v3 05/15] gpio: pxa: " Jisheng Zhang
2025-11-19 15:47 ` Andy Shevchenko
2025-11-19 15:58 ` Jisheng Zhang
2025-11-19 16:25 ` Andy Shevchenko
2025-11-19 14:43 ` [PATCH v3 06/15] gpio: ml-ioh: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 07/15] gpio: mlxbf2: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 08/15] gpio: msc313: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 09/15] gpio: omap: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 10/15] gpio: pch: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 11/15] gpio: tqmx86: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 12/15] gpio: uniphier: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 13/15] gpio: xgene: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 14/15] gpio: xilinx: " Jisheng Zhang
2025-11-19 14:43 ` [PATCH v3 15/15] gpio: zynq: " Jisheng Zhang
2025-11-19 15:52 ` [PATCH v3 00/15] gpio: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR3nSmSlV9bfqi3k@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=jszhang@kernel.org \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.