From: Sabrina Dubroca <sd@queasysnail.net>
To: Marek Mietus <mmietus97@yahoo.com>,
edumazet@google.com, pabeni@redhat.com, kuba@kernel.org,
davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 02/14] net: skb: use dstref for storing dst entry
Date: Wed, 12 Nov 2025 18:09:28 +0100 [thread overview]
Message-ID: <aRS_SEUbglrR_MeX@krikkit> (raw)
In-Reply-To: <20251112072720.5076-3-mmietus97@yahoo.com>
2025-11-12, 08:27:08 +0100, Marek Mietus wrote:
> Use the newly introduced dstref object for storing the dst entry
> in skb instead of using _skb_refdst, and remove code related
> to _skb_refdst.
This is an important change to a very core part of networking. You
need to CC all the networking maintainers/reviewers for this series
(ask scripts/get_maintainer.pl).
> This is mostly a cosmetic improvement. It improves readability
That rename, and the rest of the changes in this series. is causing
some non-negligible churn and will take a while to review, to ensure
all the conversions are correct.
@Maintainers can I get some time to look at this in detail?
Also, I'm not sure how we ended up from the previous proposal ("some
tunnels are under RCU so they don't need a reference" [1]) to this.
[1] https://lore.kernel.org/netdev/20250922110622.10368-1-mmietus97@yahoo.com/
--
Sabrina
next prev parent reply other threads:[~2025-11-12 17:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251112072720.5076-1-mmietus97.ref@yahoo.com>
2025-11-12 7:27 ` [PATCH net-next v4 00/14] net: tunnel: introduce noref xmit flows for tunnels Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 01/14] net: dst: implement dstref object Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 02/14] net: skb: use dstref for storing dst entry Marek Mietus
2025-11-12 17:09 ` Sabrina Dubroca [this message]
2025-11-13 9:36 ` Marek Mietus
[not found] ` <CANn89i+qce6WJYUpjH93SMRKA8cQ6Wt-b81O6gu9V5GGnDeo_A@mail.gmail.com>
2025-11-13 18:17 ` Sabrina Dubroca
2025-11-17 11:31 ` Marek Mietus
2025-11-18 0:10 ` Jakub Kicinski
2025-11-12 7:27 ` [PATCH net-next v4 03/14] net: skb: rename skb_dstref_restore to skb_dstref_set Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 04/14] net: dst_cache: add noref versions for dst_cache Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 05/14] net: tunnel: use dstref in ip and udp tunnel xmit functions Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 06/14] net: tunnel: return dstref in udp_tunnel{,6}_dst_lookup Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 07/14] net: tunnel: make udp_tunnel{,6}_dst_lookup return a noref dst Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 08/14] net: ovpn: convert ovpn_udp{4,6}_output to use " Marek Mietus
2025-11-12 7:27 ` [PATCH net-next v4 09/14] net: wireguard: convert send{4,6} to use a noref dst when possible Marek Mietus
2025-11-13 16:40 ` Jason A. Donenfeld
2025-11-12 7:33 ` [PATCH net-next v4 10/14] net: tunnel: convert ip_md_tunnel_xmit " Marek Mietus
2025-11-12 7:33 ` [PATCH net-next v4 11/14] net: tunnel: convert ip_tunnel_xmit " Marek Mietus
2025-11-12 7:33 ` [PATCH net-next v4 12/14] net: sit: convert ipip6_tunnel_xmit to use a noref dst Marek Mietus
2025-11-12 7:33 ` [PATCH net-next v4 13/14] net: tipc: convert tipc_udp_xmit " Marek Mietus
2025-11-12 7:33 ` [PATCH net-next v4 14/14] net: sctp: convert sctp_v{4,6}_xmit to use a noref dst when possible Marek Mietus
2025-11-13 17:09 [PATCH net-next v4 02/14] net: skb: use dstref for storing dst entry kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRS_SEUbglrR_MeX@krikkit \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mmietus97@yahoo.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.