All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Marek Mietus <mmietus97@yahoo.com>
Cc: netdev@vger.kernel.org, sd@queasysnail.net, kuba@kernel.org
Subject: Re: [PATCH net-next v4 09/14] net: wireguard: convert send{4,6} to use a noref dst when possible
Date: Thu, 13 Nov 2025 17:40:51 +0100	[thread overview]
Message-ID: <aRYKE2rKobILiqAG@zx2c4.com> (raw)
In-Reply-To: <20251112072720.5076-10-mmietus97@yahoo.com>

Hi Marek,

On Wed, Nov 12, 2025 at 08:27:15AM +0100, Marek Mietus wrote:
> send{4,6} unnecessarily reference the dst_entry from the
> dst_cache when interacting with the cache.
> 
> Reduce this overhead by avoiding the redundant refcount increments.
> 
> This is only possible in flows where the cache is used. Otherwise, we
> fall-back to a referenced dst.
> 
> These changes are safe as both ipv4 and ip6 support noref xmit under RCU
> which is already the case for the wireguard send{4,6} functions.

Assuming the rest of the patchset is fine, this patch is okay with me,
with one very small nit. The commit subject should be
    wireguard: socket: convert send{4,6} to use a noref dst when possible
instead of "net: wireguard" etc.

Please CC me on future revisions of this if you do a v2, and I'll give
my reviewed-by.

Thanks,
Jason

  reply	other threads:[~2025-11-13 16:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251112072720.5076-1-mmietus97.ref@yahoo.com>
2025-11-12  7:27 ` [PATCH net-next v4 00/14] net: tunnel: introduce noref xmit flows for tunnels Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 01/14] net: dst: implement dstref object Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 02/14] net: skb: use dstref for storing dst entry Marek Mietus
2025-11-12 17:09     ` Sabrina Dubroca
2025-11-13  9:36       ` Marek Mietus
     [not found]         ` <CANn89i+qce6WJYUpjH93SMRKA8cQ6Wt-b81O6gu9V5GGnDeo_A@mail.gmail.com>
2025-11-13 18:17           ` Sabrina Dubroca
2025-11-17 11:31             ` Marek Mietus
2025-11-18  0:10               ` Jakub Kicinski
2025-11-12  7:27   ` [PATCH net-next v4 03/14] net: skb: rename skb_dstref_restore to skb_dstref_set Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 04/14] net: dst_cache: add noref versions for dst_cache Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 05/14] net: tunnel: use dstref in ip and udp tunnel xmit functions Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 06/14] net: tunnel: return dstref in udp_tunnel{,6}_dst_lookup Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 07/14] net: tunnel: make udp_tunnel{,6}_dst_lookup return a noref dst Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 08/14] net: ovpn: convert ovpn_udp{4,6}_output to use " Marek Mietus
2025-11-12  7:27   ` [PATCH net-next v4 09/14] net: wireguard: convert send{4,6} to use a noref dst when possible Marek Mietus
2025-11-13 16:40     ` Jason A. Donenfeld [this message]
2025-11-12  7:33   ` [PATCH net-next v4 10/14] net: tunnel: convert ip_md_tunnel_xmit " Marek Mietus
2025-11-12  7:33   ` [PATCH net-next v4 11/14] net: tunnel: convert ip_tunnel_xmit " Marek Mietus
2025-11-12  7:33   ` [PATCH net-next v4 12/14] net: sit: convert ipip6_tunnel_xmit to use a noref dst Marek Mietus
2025-11-12  7:33   ` [PATCH net-next v4 13/14] net: tipc: convert tipc_udp_xmit " Marek Mietus
2025-11-12  7:33   ` [PATCH net-next v4 14/14] net: sctp: convert sctp_v{4,6}_xmit to use a noref dst when possible Marek Mietus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRYKE2rKobILiqAG@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=kuba@kernel.org \
    --cc=mmietus97@yahoo.com \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.