From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrei Botila <andrei.botila@oss.nxp.com>,
Richard Cochran <richardcochran@gmail.com>,
Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Kory Maincent <kory.maincent@bootlin.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/9] phy: add hwtstamp_get callback to phy drivers
Date: Thu, 13 Nov 2025 17:15:40 +0000 [thread overview]
Message-ID: <aRYSPKmGennbjxwj@shell.armlinux.org.uk> (raw)
In-Reply-To: <69ec62f4-649b-4d88-8c06-6bf675160b0b@linux.dev>
On Thu, Nov 13, 2025 at 05:05:18PM +0000, Vadim Fedorenko wrote:
> On 13/11/2025 16:57, Russell King (Oracle) wrote:
> > On Thu, Nov 13, 2025 at 04:48:00PM +0000, Vadim Fedorenko wrote:
> > > If the above is correct, then yes, there is no reason to implement
> > > SIOCGHWTSTAMP, and even more, SIOCSHWTSTAMP can be technically removed
> > > as a dead code.
> >
> > I think you're missing the clarification in this sentence "... to
> > implement SIOCGHWTSTAMP in phy_mii_ioctl(), and even more,
> > SIOCSHWTSTAMP can be removed from this function as dead code.""
>
> Ok, it's better to "there is no reason to have SIOCGHWTSTAMP chunk,
> provided in patch 2 of this series"
>
> Or are you asking for the clarification of SIOCSHWTSTAMP removal?
> I don't plan to remove it, at least not in this series. I just wanted
> to mention that there will be no way to reach SIOCSHWTSTAMP case in
> phy_mii_ioctl() from user-space ABI. Does it make sense?
I'm not asking. I'm trying to work out what you're trying to say, and
suggesting a clarification to your last paragraph that would clarify
what I thought you mean. Now I'm even more confused about what you're
proposing.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-13 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:31 [PATCH net-next v2 0/9] add hwtstamp_get callback to phy drivers Vadim Fedorenko
2025-11-13 11:31 ` [PATCH net-next v2 1/9] phy: rename hwtstamp callback to hwtstamp_set Vadim Fedorenko
2025-11-13 13:31 ` Andrew Lunn
2025-11-13 11:32 ` [PATCH net-next v2 2/9] phy: add hwtstamp_get callback to phy drivers Vadim Fedorenko
2025-11-13 12:02 ` Russell King (Oracle)
2025-11-13 12:12 ` Vadim Fedorenko
2025-11-13 12:24 ` Russell King (Oracle)
2025-11-17 17:39 ` Vadim Fedorenko
2025-11-17 17:56 ` Russell King (Oracle)
2025-11-13 13:36 ` Andrew Lunn
2025-11-13 16:48 ` Vadim Fedorenko
2025-11-13 16:57 ` Russell King (Oracle)
2025-11-13 17:05 ` Vadim Fedorenko
2025-11-13 17:15 ` Russell King (Oracle) [this message]
2025-11-13 18:03 ` Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 3/9] net: phy: broadcom: add HW timestamp configuration reporting Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 4/9] net: phy: dp83640: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 5/9] net: phy: micrel: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 6/9] net: phy: microchip_rds_ptp: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 7/9] phy: mscc: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 8/9] net: phy: nxp-c45-tja11xx: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 9/9] ptp: ptp_ines: " Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRYSPKmGennbjxwj@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrei.botila@oss.nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.