From: Petr Mladek <pmladek@suse.com>
To: Feng Tang <feng.tang@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lance Yang <ioworker0@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
paulmck@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] hung_task: Add hung_task_sys_info sysctl to dump sys info on task-hung
Date: Fri, 14 Nov 2025 16:36:39 +0100 [thread overview]
Message-ID: <aRdMh3royGUDlO5V@pathway.suse.cz> (raw)
In-Reply-To: <20251113111039.22701-3-feng.tang@linux.alibaba.com>
On Thu 2025-11-13 19:10:37, Feng Tang wrote:
> When task-hung happens, developers may need different kinds of system
> information (call-stacks, memory info, locks, etc.) to help debugging.
>
> Add 'hung_task_sys_info' sysctl knob to take human readable string like
> "tasks,mem,timers,locks,ftrace,...", and when task-hung happens, all
> requested information will be dumped. (refer kernel/sys_info.c for more
> details).
>
> Meanwhile, the newly introduced sys_info() call is used to unify some
> existing info-dumping knobs.
>
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>
It would have been better to split the refactoring (moving some logic
from check_hung_task()) into a separate patch.
But the result looks good. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2025-11-14 15:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:10 [PATCH v2 0/4] Enable hung_task and lockup cases to dump system info on demand Feng Tang
2025-11-13 11:10 ` [PATCH v2 1/4] docs: panic: correct some sys_ifo names in sysctl doc Feng Tang
2025-11-13 11:10 ` [PATCH v2 2/4] hung_task: Add hung_task_sys_info sysctl to dump sys info on task-hung Feng Tang
2025-11-14 15:36 ` Petr Mladek [this message]
2025-11-16 7:16 ` Feng Tang
2025-11-16 7:58 ` Lance Yang
2025-11-16 9:11 ` Feng Tang
2025-11-16 13:22 ` Lance Yang
2025-11-16 14:13 ` Feng Tang
2025-11-17 17:53 ` Andrew Morton
2025-11-18 2:26 ` Feng Tang
2025-11-18 6:06 ` Lance Yang
2025-11-18 15:20 ` Petr Mladek
2025-11-18 17:57 ` Lance Yang
2025-11-19 12:31 ` Petr Mladek
2025-11-13 11:10 ` [PATCH v2 3/4] watchdog: add sys_info sysctls to dump sys info on system lockup Feng Tang
2025-11-14 15:44 ` Petr Mladek
2025-11-13 11:10 ` [PATCH v2 4/4] sys_info: add a default kernel sys_info mask Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRdMh3royGUDlO5V@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=feng.tang@linux.alibaba.com \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.