From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jordan Rife <jordan@jrife.io>
Subject: Re: [PATCH net-next v3 08/11] tools: ynl: add sample for wireguard
Date: Tue, 18 Nov 2025 16:20:58 +0100 [thread overview]
Message-ID: <aRyO2mvToYf4yuwY@zx2c4.com> (raw)
In-Reply-To: <20251105183223.89913-9-ast@fiberby.net>
On Wed, Nov 05, 2025 at 06:32:17PM +0000, Asbjørn Sloth Tønnesen wrote:
> +CFLAGS_wireguard:=$(call get_hdr_inc,_LINUX_WIREGUARD_H,wireguard.h) \
> + -D _WG_UAPI_WIREGUARD_H # alternate pre-YNL guard
I don't totally grok what's going on here. As I understand it, this
makefile creates `wireguard-user.h` in the generated/ include path,
which has all the various netlink wrapper declarations. And then this
also references, somehow, include/uapi/linux/wireguard.h, for the constants.
For some reason, you're then defining _WG_UAPI_WIREGUARD_H here, so that
wireguard.h from /usr/include doesn't clash. But also, why would it?
Isn't this just a matter of placing $(src)/include/uapi earlier in the
include file path?
Jason
next prev parent reply other threads:[~2025-11-18 15:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 18:32 [PATCH net-next v3 00/11] wireguard: netlink: ynl conversion Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 01/11] wireguard: netlink: validate nested arrays in policy Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 02/11] wireguard: netlink: use WG_KEY_LEN in policies Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 03/11] wireguard: netlink: enable strict genetlink validation Asbjørn Sloth Tønnesen
2025-11-18 15:15 ` Jason A. Donenfeld
2025-11-18 17:10 ` Jason A. Donenfeld
2025-11-26 16:24 ` Asbjørn Sloth Tønnesen
2025-11-26 16:26 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 04/11] netlink: specs: add specification for wireguard Asbjørn Sloth Tønnesen
2025-11-18 2:15 ` Jason A. Donenfeld
2025-11-18 12:08 ` Asbjørn Sloth Tønnesen
2025-11-18 15:07 ` Jason A. Donenfeld
2025-11-18 21:59 ` Asbjørn Sloth Tønnesen
2025-11-18 22:52 ` Jason A. Donenfeld
2025-11-19 0:50 ` Jakub Kicinski
2025-11-19 19:19 ` Asbjørn Sloth Tønnesen
2025-11-19 19:22 ` Jason A. Donenfeld
2025-11-19 19:47 ` Asbjørn Sloth Tønnesen
2025-11-19 20:01 ` Jason A. Donenfeld
2025-11-20 2:27 ` Jakub Kicinski
2025-11-05 18:32 ` [PATCH net-next v3 05/11] uapi: wireguard: move enum wg_cmd Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 06/11] uapi: wireguard: move flag enums Asbjørn Sloth Tønnesen
2025-11-18 15:10 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 07/11] uapi: wireguard: generate header with ynl-gen Asbjørn Sloth Tønnesen
2025-11-18 15:17 ` Jason A. Donenfeld
2025-11-19 0:53 ` Jakub Kicinski
2025-11-20 0:55 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 08/11] tools: ynl: add sample for wireguard Asbjørn Sloth Tønnesen
2025-11-18 15:20 ` Jason A. Donenfeld [this message]
2025-11-18 17:16 ` Asbjørn Sloth Tønnesen
2025-11-18 17:17 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 09/11] wireguard: netlink: convert to split ops Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 10/11] wireguard: netlink: rename netlink handlers Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code Asbjørn Sloth Tønnesen
2025-11-18 15:15 ` Jason A. Donenfeld
2025-11-18 16:57 ` Jason A. Donenfeld
2025-11-18 22:23 ` Asbjørn Sloth Tønnesen
2025-11-18 22:51 ` Jason A. Donenfeld
2025-11-19 1:00 ` Jakub Kicinski
2025-11-20 0:54 ` Jason A. Donenfeld
2025-11-20 2:44 ` Jakub Kicinski
2025-11-20 2:46 ` Jason A. Donenfeld
2025-11-20 3:19 ` Jakub Kicinski
2025-11-20 19:49 ` Asbjørn Sloth Tønnesen
2025-11-11 2:07 ` [PATCH net-next v3 00/11] wireguard: netlink: ynl conversion Jakub Kicinski
2025-11-12 3:59 ` Jason A. Donenfeld
2025-11-18 0:14 ` Jakub Kicinski
2025-11-18 0:43 ` Jason A. Donenfeld
2025-11-18 0:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRyO2mvToYf4yuwY@zx2c4.com \
--to=jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jordan@jrife.io \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.