* [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma
@ 2025-11-25 10:18 Nareshkumar Gollakoti
2025-11-25 12:36 ` ✓ i915.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: Nareshkumar Gollakoti @ 2025-11-25 10:18 UTC (permalink / raw)
To: intel-gfx; +Cc: naresh.kumar.g
The variable "fence" should be initialized to NULL,
and any usage of fence should be guarded
by a check to ensure it is not NULL
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c
index afb06598b6e1..401f1835939b 100644
--- a/drivers/gpu/drm/xe/xe_pagefault.c
+++ b/drivers/gpu/drm/xe/xe_pagefault.c
@@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma,
struct xe_tile *tile = gt_to_tile(gt);
struct xe_validation_ctx ctx;
struct drm_exec exec;
- struct dma_fence *fence;
+ struct dma_fence *fence = NULL;
int err, needs_vram;
lockdep_assert_held_write(&vm->lock);
@@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma,
}
}
- dma_fence_wait(fence, false);
- dma_fence_put(fence);
+ if (fence) {
+ dma_fence_wait(fence, false);
+ dma_fence_put(fence);
+ }
unlock_dma_resv:
xe_validation_ctx_fini(&ctx);
--
2.43.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* ✓ i915.CI.BAT: success for fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti @ 2025-11-25 12:36 ` Patchwork 2025-11-25 13:35 ` [PATCH] " Rodrigo Vivi ` (4 subsequent siblings) 5 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2025-11-25 12:36 UTC (permalink / raw) To: Nareshkumar Gollakoti; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 6273 bytes --] == Series Details == Series: fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma URL : https://patchwork.freedesktop.org/series/158020/ State : success == Summary == CI Bug Log - changes from CI_DRM_17582 -> Patchwork_158020v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/index.html Participating hosts (43 -> 44) ------------------------------ Additional (2): fi-kbl-guc bat-adls-6 Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_158020v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@fbdev@info: - fi-kbl-guc: NOTRUN -> [SKIP][1] ([i915#1849]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/fi-kbl-guc/igt@fbdev@info.html * igt@gem_lmem_swapping@basic: - fi-kbl-guc: NOTRUN -> [SKIP][2] ([i915#4613]) +3 other tests skip [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/fi-kbl-guc/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@parallel-random-engines: - bat-adls-6: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@gem_lmem_swapping@parallel-random-engines.html * igt@gem_tiled_pread_basic: - bat-adls-6: NOTRUN -> [SKIP][4] ([i915#3282]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@gem_tiled_pread_basic.html * igt@intel_hwmon@hwmon-read: - bat-adls-6: NOTRUN -> [SKIP][5] ([i915#7707]) +1 other test skip [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@intel_hwmon@hwmon-read.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - bat-adls-6: NOTRUN -> [SKIP][6] ([i915#4103]) +1 other test skip [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_cursor_legacy@basic-flip-before-cursor-legacy: - fi-kbl-guc: NOTRUN -> [SKIP][7] ([i915#11190]) +16 other tests skip [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/fi-kbl-guc/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html * igt@kms_dsc@dsc-basic: - bat-adls-6: NOTRUN -> [SKIP][8] ([i915#3555] / [i915#3840]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@kms_dsc@dsc-basic.html * igt@kms_force_connector_basic@force-load-detect: - bat-adls-6: NOTRUN -> [SKIP][9] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_pm_backlight@basic-brightness: - bat-adls-6: NOTRUN -> [SKIP][10] ([i915#5354]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@kms_pm_backlight@basic-brightness.html * igt@kms_psr@psr-primary-mmap-gtt: - bat-adls-6: NOTRUN -> [SKIP][11] ([i915#1072] / [i915#9732]) +3 other tests skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@kms_psr@psr-primary-mmap-gtt.html * igt@kms_setmode@basic-clone-single-crtc: - bat-adls-6: NOTRUN -> [SKIP][12] ([i915#3555]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - fi-kbl-guc: NOTRUN -> [SKIP][13] +18 other tests skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/fi-kbl-guc/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-fence-read: - bat-adls-6: NOTRUN -> [SKIP][14] ([i915#3291]) +2 other tests skip [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-adls-6/igt@prime_vgem@basic-fence-read.html #### Possible fixes #### * igt@i915_selftest@live@workarounds: - bat-dg2-9: [DMESG-FAIL][15] ([i915#12061]) -> [PASS][16] +1 other test pass [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/bat-dg2-9/igt@i915_selftest@live@workarounds.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-dg2-9/igt@i915_selftest@live@workarounds.html - bat-dg2-14: [DMESG-FAIL][17] ([i915#12061]) -> [PASS][18] +1 other test pass [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/bat-dg2-14/igt@i915_selftest@live@workarounds.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/bat-dg2-14/igt@i915_selftest@live@workarounds.html [i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072 [i915#11190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11190 [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061 [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849 [i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291 [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555 [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840 [i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103 [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613 [i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354 [i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707 [i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732 Build changes ------------- * Linux: CI_DRM_17582 -> Patchwork_158020v1 CI-20190529: 20190529 CI_DRM_17582: c9ffb8a8ab1294c1870e017e0502cb8089d3d8b8 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_8637: 730ee3dfb26f8d7891fc240b0132a08c5bc7b949 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_158020v1: c9ffb8a8ab1294c1870e017e0502cb8089d3d8b8 @ git://anongit.freedesktop.org/gfx-ci/linux == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/index.html [-- Attachment #2: Type: text/html, Size: 7477 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti 2025-11-25 12:36 ` ✓ i915.CI.BAT: success for " Patchwork @ 2025-11-25 13:35 ` Rodrigo Vivi 2025-11-25 14:48 ` Kumar G, Naresh 2025-11-25 22:22 ` ✗ i915.CI.Full: failure for " Patchwork ` (3 subsequent siblings) 5 siblings, 1 reply; 15+ messages in thread From: Rodrigo Vivi @ 2025-11-25 13:35 UTC (permalink / raw) To: Nareshkumar Gollakoti; +Cc: intel-gfx On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: Hi Nareshkumar, Thank you so much for the patch. I believe the change below is a good addition, but the patch itself is in a bad format. fixup in the commit subject is absolutely no no! This is a git indication that the patch should be squashed to the one introducing the error, but we are in a non-rebasing branch. So you need to provide a fix as a new patch and using the proper tags indicating which patch it is fixing and Cc'ing author and reviewer of the original patch. In this case: Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Cc: Matthew Brost <matthew.brost@intel.com> Cc: Stuart Summers <stuart.summers@intel.com> > The variable "fence" should be initialized to NULL, > and any usage of fence should be guarded > by a check to ensure it is not NULL Furthermore, the message itself here is a bit strange. It is not necessarily true that it 'should' be initialized. In this case it looks more like a false positive of static analysis tools, but it would be good to have this protection just in case... So, some rephrasing here might be good. Please read the documentation on how to submit patches for the proper style and messages: https://www.kernel.org/doc/html/latest/process/submitting-patches.html Thanks, Rodrigo. > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > --- > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c > index afb06598b6e1..401f1835939b 100644 > --- a/drivers/gpu/drm/xe/xe_pagefault.c > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > struct xe_tile *tile = gt_to_tile(gt); > struct xe_validation_ctx ctx; > struct drm_exec exec; > - struct dma_fence *fence; > + struct dma_fence *fence = NULL; > int err, needs_vram; > > lockdep_assert_held_write(&vm->lock); > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > } > } > > - dma_fence_wait(fence, false); > - dma_fence_put(fence); > + if (fence) { > + dma_fence_wait(fence, false); > + dma_fence_put(fence); > + } > > unlock_dma_resv: > xe_validation_ctx_fini(&ctx); > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 13:35 ` [PATCH] " Rodrigo Vivi @ 2025-11-25 14:48 ` Kumar G, Naresh 2025-11-26 2:03 ` Matthew Brost 0 siblings, 1 reply; 15+ messages in thread From: Kumar G, Naresh @ 2025-11-25 14:48 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx On 25-11-2025 19:05, Rodrigo Vivi wrote: > On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: > > Hi Nareshkumar, > > Thank you so much for the patch. I believe the change below is a good > addition, but the patch itself is in a bad format. > > fixup in the commit subject is absolutely no no! This is a git indication > that the patch should be squashed to the one introducing the error, > but we are in a non-rebasing branch. So you need to provide a fix > as a new patch and using the proper tags indicating which patch > it is fixing and Cc'ing author and reviewer of the original patch. > Hi Rodrigo, My appologies, will correct mentioned suggestions/feedback.but i have pushed this patch to this mailing list by mistake and will correct and route to the xe mailing list. ignore this patch Thanks, Naresh > In this case: > Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: Stuart Summers <stuart.summers@intel.com> > >> The variable "fence" should be initialized to NULL, >> and any usage of fence should be guarded >> by a check to ensure it is not NULL > > Furthermore, the message itself here is a bit strange. It is not > necessarily true that it 'should' be initialized. In this case > it looks more like a false positive of static analysis tools, > but it would be good to have this protection just in case... > > So, some rephrasing here might be good. > > Please read the documentation on how to submit patches for the > proper style and messages: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Thanks, > Rodrigo. > > >> >> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> >> --- >> drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c >> index afb06598b6e1..401f1835939b 100644 >> --- a/drivers/gpu/drm/xe/xe_pagefault.c >> +++ b/drivers/gpu/drm/xe/xe_pagefault.c >> @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, >> struct xe_tile *tile = gt_to_tile(gt); >> struct xe_validation_ctx ctx; >> struct drm_exec exec; >> - struct dma_fence *fence; >> + struct dma_fence *fence = NULL; >> int err, needs_vram; >> >> lockdep_assert_held_write(&vm->lock); >> @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, >> } >> } >> >> - dma_fence_wait(fence, false); >> - dma_fence_put(fence); >> + if (fence) { >> + dma_fence_wait(fence, false); >> + dma_fence_put(fence); >> + } >> >> unlock_dma_resv: >> xe_validation_ctx_fini(&ctx); >> -- >> 2.43.0 >> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 14:48 ` Kumar G, Naresh @ 2025-11-26 2:03 ` Matthew Brost 2025-11-26 4:04 ` Upadhyay, Tejas 0 siblings, 1 reply; 15+ messages in thread From: Matthew Brost @ 2025-11-26 2:03 UTC (permalink / raw) To: Kumar G, Naresh; +Cc: Rodrigo Vivi, intel-gfx On Tue, Nov 25, 2025 at 08:18:37PM +0530, Kumar G, Naresh wrote: > > > On 25-11-2025 19:05, Rodrigo Vivi wrote: > > On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: > > > > Hi Nareshkumar, > > > > Thank you so much for the patch. I believe the change below is a good > > addition, but the patch itself is in a bad format. > > > > fixup in the commit subject is absolutely no no! This is a git indication > > that the patch should be squashed to the one introducing the error, > > but we are in a non-rebasing branch. So you need to provide a fix > > as a new patch and using the proper tags indicating which patch > > it is fixing and Cc'ing author and reviewer of the original patch. > > > Hi Rodrigo, > My appologies, will correct mentioned suggestions/feedback.but i have pushed > this patch to this mailing list by mistake and will correct and route to the > xe mailing list. > > ignore this patch > > Thanks, > Naresh > > In this case: > > Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") > > Cc: Matthew Brost <matthew.brost@intel.com> > > Cc: Stuart Summers <stuart.summers@intel.com> > > > > > The variable "fence" should be initialized to NULL, > > > and any usage of fence should be guarded > > > by a check to ensure it is not NULL > > > > Furthermore, the message itself here is a bit strange. It is not > > necessarily true that it 'should' be initialized. In this case > > it looks more like a false positive of static analysis tools, > > but it would be good to have this protection just in case... Yes, I looked at code, I'm guessing this is a static analysis false positive. Matt > > > > So, some rephrasing here might be good. > > > > Please read the documentation on how to submit patches for the > > proper style and messages: > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > > > Thanks, > > Rodrigo. > > > > > > > > > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > > > --- > > > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c > > > index afb06598b6e1..401f1835939b 100644 > > > --- a/drivers/gpu/drm/xe/xe_pagefault.c > > > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > > > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > > > struct xe_tile *tile = gt_to_tile(gt); > > > struct xe_validation_ctx ctx; > > > struct drm_exec exec; > > > - struct dma_fence *fence; > > > + struct dma_fence *fence = NULL; > > > int err, needs_vram; > > > lockdep_assert_held_write(&vm->lock); > > > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > > > } > > > } > > > - dma_fence_wait(fence, false); > > > - dma_fence_put(fence); > > > + if (fence) { > > > + dma_fence_wait(fence, false); > > > + dma_fence_put(fence); > > > + } > > > unlock_dma_resv: > > > xe_validation_ctx_fini(&ctx); > > > -- > > > 2.43.0 > > > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-26 2:03 ` Matthew Brost @ 2025-11-26 4:04 ` Upadhyay, Tejas 0 siblings, 0 replies; 15+ messages in thread From: Upadhyay, Tejas @ 2025-11-26 4:04 UTC (permalink / raw) To: Brost, Matthew, Kumar G, Naresh Cc: Vivi, Rodrigo, intel-gfx@lists.freedesktop.org > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Matthew Brost > Sent: 26 November 2025 07:33 > To: Kumar G, Naresh <naresh.kumar.g@intel.com> > Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized > fence usage in xe_pagefault_handle_vma > > On Tue, Nov 25, 2025 at 08:18:37PM +0530, Kumar G, Naresh wrote: > > > > > > On 25-11-2025 19:05, Rodrigo Vivi wrote: > > > On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti > wrote: > > > > > > Hi Nareshkumar, > > > > > > Thank you so much for the patch. I believe the change below is a > > > good addition, but the patch itself is in a bad format. > > > > > > fixup in the commit subject is absolutely no no! This is a git > > > indication that the patch should be squashed to the one introducing > > > the error, but we are in a non-rebasing branch. So you need to > > > provide a fix as a new patch and using the proper tags indicating > > > which patch it is fixing and Cc'ing author and reviewer of the original patch. > > > > > Hi Rodrigo, > > My appologies, will correct mentioned suggestions/feedback.but i have > > pushed this patch to this mailing list by mistake and will correct and > > route to the xe mailing list. > > > > ignore this patch > > > > Thanks, > > Naresh > > > In this case: > > > Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") > > > Cc: Matthew Brost <matthew.brost@intel.com> > > > Cc: Stuart Summers <stuart.summers@intel.com> > > > > > > > The variable "fence" should be initialized to NULL, and any usage > > > > of fence should be guarded by a check to ensure it is not NULL > > > > > > Furthermore, the message itself here is a bit strange. It is not > > > necessarily true that it 'should' be initialized. In this case it > > > looks more like a false positive of static analysis tools, but it > > > would be good to have this protection just in case... > > Yes, I looked at code, I'm guessing this is a static analysis false positive. Yeah, Naresh, lets drop patch then. Tejas > > Matt > > > > > > > So, some rephrasing here might be good. > > > > > > Please read the documentation on how to submit patches for the > > > proper style and messages: > > > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.ht > > > ml > > > > > > Thanks, > > > Rodrigo. > > > > > > > > > > > > > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > > > > --- > > > > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c > > > > b/drivers/gpu/drm/xe/xe_pagefault.c > > > > index afb06598b6e1..401f1835939b 100644 > > > > --- a/drivers/gpu/drm/xe/xe_pagefault.c > > > > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > > > > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt > *gt, struct xe_vma *vma, > > > > struct xe_tile *tile = gt_to_tile(gt); > > > > struct xe_validation_ctx ctx; > > > > struct drm_exec exec; > > > > - struct dma_fence *fence; > > > > + struct dma_fence *fence = NULL; > > > > int err, needs_vram; > > > > lockdep_assert_held_write(&vm->lock); > > > > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct > xe_gt *gt, struct xe_vma *vma, > > > > } > > > > } > > > > - dma_fence_wait(fence, false); > > > > - dma_fence_put(fence); > > > > + if (fence) { > > > > + dma_fence_wait(fence, false); > > > > + dma_fence_put(fence); > > > > + } > > > > unlock_dma_resv: > > > > xe_validation_ctx_fini(&ctx); > > > > -- > > > > 2.43.0 > > > > > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✗ i915.CI.Full: failure for fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti 2025-11-25 12:36 ` ✓ i915.CI.BAT: success for " Patchwork 2025-11-25 13:35 ` [PATCH] " Rodrigo Vivi @ 2025-11-25 22:22 ` Patchwork 2025-11-26 2:01 ` [PATCH] " Matthew Brost ` (2 subsequent siblings) 5 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2025-11-25 22:22 UTC (permalink / raw) To: Kumar G, Naresh; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 63165 bytes --] == Series Details == Series: fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma URL : https://patchwork.freedesktop.org/series/158020/ State : failure == Summary == CI Bug Log - changes from CI_DRM_17582_full -> Patchwork_158020v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_158020v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_158020v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_158020v1_full: ### IGT changes ### #### Possible regressions #### * igt@kms_content_protection@dp-mst-suspend-resume: - shard-mtlp: NOTRUN -> [SKIP][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_content_protection@dp-mst-suspend-resume.html Known issues ------------ Here are the changes found in Patchwork_158020v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@device_reset@unbind-cold-reset-rebind: - shard-rkl: NOTRUN -> [SKIP][2] ([i915#11078]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@device_reset@unbind-cold-reset-rebind.html * igt@gem_basic@multigpu-create-close: - shard-tglu: NOTRUN -> [SKIP][3] ([i915#7697]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-2/igt@gem_basic@multigpu-create-close.html * igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-smem-lmem0: - shard-dg2: [PASS][4] -> [ABORT][5] ([i915#15317]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-6/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-smem-lmem0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-5/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-smem-lmem0.html * igt@gem_ccs@suspend-resume@xmajor-compressed-compfmt0-lmem0-lmem0: - shard-dg2: [PASS][6] -> [INCOMPLETE][7] ([i915#12392] / [i915#13356]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-6/igt@gem_ccs@suspend-resume@xmajor-compressed-compfmt0-lmem0-lmem0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-5/igt@gem_ccs@suspend-resume@xmajor-compressed-compfmt0-lmem0-lmem0.html * igt@gem_ctx_persistence@heartbeat-stop: - shard-mtlp: NOTRUN -> [SKIP][8] ([i915#8555]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@gem_ctx_persistence@heartbeat-stop.html * igt@gem_eio@in-flight-suspend: - shard-rkl: NOTRUN -> [ABORT][9] ([i915#15317]) +4 other tests abort [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_balancer@parallel-balancer: - shard-rkl: NOTRUN -> [SKIP][10] ([i915#4525]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@gem_exec_balancer@parallel-balancer.html * igt@gem_exec_capture@capture-invisible: - shard-glk10: NOTRUN -> [SKIP][11] ([i915#6334]) +1 other test skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@gem_exec_capture@capture-invisible.html - shard-tglu: NOTRUN -> [SKIP][12] ([i915#6334]) +1 other test skip [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@gem_exec_capture@capture-invisible.html * igt@gem_exec_reloc@basic-wc-gtt-active: - shard-mtlp: NOTRUN -> [SKIP][13] ([i915#3281]) +2 other tests skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@gem_exec_reloc@basic-wc-gtt-active.html * igt@gem_exec_reloc@basic-write-wc-noreloc: - shard-rkl: NOTRUN -> [SKIP][14] ([i915#3281]) +1 other test skip [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@gem_exec_reloc@basic-write-wc-noreloc.html * igt@gem_exec_suspend@basic-s0: - shard-mtlp: [PASS][15] -> [ABORT][16] ([i915#15317]) +7 other tests abort [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-mtlp-5/igt@gem_exec_suspend@basic-s0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-2/igt@gem_exec_suspend@basic-s0.html * igt@gem_exec_suspend@basic-s4-devices@lmem0: - shard-dg2: [PASS][17] -> [ABORT][18] ([i915#15317] / [i915#7975]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-8/igt@gem_exec_suspend@basic-s4-devices@lmem0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-6/igt@gem_exec_suspend@basic-s4-devices@lmem0.html * igt@gem_fence_thrash@bo-write-verify-none: - shard-mtlp: NOTRUN -> [SKIP][19] ([i915#4860]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@gem_fence_thrash@bo-write-verify-none.html * igt@gem_lmem_swapping@basic: - shard-rkl: NOTRUN -> [SKIP][20] ([i915#4613]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@massive-random: - shard-tglu: NOTRUN -> [SKIP][21] ([i915#4613]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-2/igt@gem_lmem_swapping@massive-random.html * igt@gem_lmem_swapping@parallel-random-verify: - shard-glk: NOTRUN -> [SKIP][22] ([i915#4613]) +1 other test skip [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk3/igt@gem_lmem_swapping@parallel-random-verify.html - shard-mtlp: NOTRUN -> [SKIP][23] ([i915#4613]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@gem_lmem_swapping@parallel-random-verify.html * igt@gem_mmap_wc@bad-size: - shard-mtlp: NOTRUN -> [SKIP][24] ([i915#4083]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@gem_mmap_wc@bad-size.html * igt@gem_pwrite@basic-exhaustion: - shard-tglu-1: NOTRUN -> [WARN][25] ([i915#2658]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@gem_pwrite@basic-exhaustion.html * igt@gem_readwrite@read-bad-handle: - shard-rkl: NOTRUN -> [SKIP][26] ([i915#3282]) +1 other test skip [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@gem_readwrite@read-bad-handle.html * igt@gem_readwrite@read-write: - shard-mtlp: NOTRUN -> [SKIP][27] ([i915#3282]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@gem_readwrite@read-write.html * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled: - shard-mtlp: NOTRUN -> [SKIP][28] ([i915#8428]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html * igt@gem_softpin@noreloc-s3: - shard-snb: NOTRUN -> [ABORT][29] ([i915#15317]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-snb4/igt@gem_softpin@noreloc-s3.html * igt@gem_userptr_blits@relocations: - shard-mtlp: NOTRUN -> [SKIP][30] ([i915#3281] / [i915#3297]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@gem_userptr_blits@relocations.html * igt@gem_userptr_blits@unsync-unmap-cycles: - shard-tglu-1: NOTRUN -> [SKIP][31] ([i915#3297]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@gem_userptr_blits@unsync-unmap-cycles.html * igt@gem_workarounds@suspend-resume: - shard-glk: NOTRUN -> [ABORT][32] ([i915#15317]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk5/igt@gem_workarounds@suspend-resume.html * igt@gem_workarounds@suspend-resume-fd: - shard-tglu: [PASS][33] -> [ABORT][34] ([i915#15317]) +1 other test abort [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-tglu-5/igt@gem_workarounds@suspend-resume-fd.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-7/igt@gem_workarounds@suspend-resume-fd.html * igt@gen9_exec_parse@allowed-all: - shard-tglu: NOTRUN -> [SKIP][35] ([i915#2527] / [i915#2856]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@gen9_exec_parse@allowed-all.html * igt@gen9_exec_parse@valid-registers: - shard-mtlp: NOTRUN -> [SKIP][36] ([i915#2856]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@gen9_exec_parse@valid-registers.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-glk: NOTRUN -> [FAIL][37] ([i915#14888]) +1 other test fail [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk9/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_async_flips@async-flip-dpms: - shard-mtlp: NOTRUN -> [FAIL][38] ([i915#15313]) +5 other tests fail [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_async_flips@async-flip-dpms.html * igt@kms_async_flips@async-flip-suspend-resume: - shard-glk10: NOTRUN -> [ABORT][39] ([i915#15317]) +4 other tests abort [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_async_flips@async-flip-suspend-resume.html * igt@kms_big_fb@4-tiled-64bpp-rotate-0: - shard-rkl: NOTRUN -> [SKIP][40] ([i915#5286]) +1 other test skip [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0: - shard-tglu: NOTRUN -> [SKIP][41] ([i915#5286]) +1 other test skip [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-16bpp-rotate-0: - shard-mtlp: NOTRUN -> [SKIP][42] +7 other tests skip [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-addfb-size-overflow: - shard-mtlp: NOTRUN -> [SKIP][43] ([i915#6187]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_big_fb@yf-tiled-addfb-size-overflow.html * igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs@pipe-a-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][44] ([i915#6095]) +11 other tests skip [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg1-14/igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs@pipe-a-hdmi-a-4.html * igt@kms_ccs@bad-rotation-90-y-tiled-gen12-mc-ccs@pipe-c-edp-1: - shard-mtlp: NOTRUN -> [SKIP][45] ([i915#6095]) +24 other tests skip [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_ccs@bad-rotation-90-y-tiled-gen12-mc-ccs@pipe-c-edp-1.html * igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-mc-ccs: - shard-rkl: NOTRUN -> [SKIP][46] ([i915#14098] / [i915#6095]) +20 other tests skip [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-mc-ccs.html * igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs@pipe-a-dp-3: - shard-dg2: NOTRUN -> [SKIP][47] ([i915#10307] / [i915#6095]) +71 other tests skip [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-11/igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs@pipe-a-dp-3.html * igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2: - shard-rkl: NOTRUN -> [SKIP][48] ([i915#6095]) +37 other tests skip [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-4/igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2.html * igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-b-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][49] ([i915#6095]) +11 other tests skip [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-8/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-b-hdmi-a-3.html * igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-d-edp-1: - shard-mtlp: [PASS][50] -> [INCOMPLETE][51] ([i915#12796]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-mtlp-5/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-d-edp-1.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-7/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-d-edp-1.html * igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-a-hdmi-a-1: - shard-glk: NOTRUN -> [INCOMPLETE][52] ([i915#12796]) +1 other test incomplete [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk6/igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-a-hdmi-a-1.html * igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-d-hdmi-a-1: - shard-tglu-1: NOTRUN -> [SKIP][53] ([i915#6095]) +4 other tests skip [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-d-hdmi-a-1.html * igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-mc-ccs@pipe-d-hdmi-a-1: - shard-tglu: NOTRUN -> [SKIP][54] ([i915#6095]) +9 other tests skip [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-mc-ccs@pipe-d-hdmi-a-1.html * igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-rc-ccs-cc@pipe-a-hdmi-a-3: - shard-dg1: NOTRUN -> [ABORT][55] ([i915#15317]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg1-13/igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-rc-ccs-cc@pipe-a-hdmi-a-3.html * igt@kms_ccs@random-ccs-data-4-tiled-lnl-ccs: - shard-rkl: NOTRUN -> [SKIP][56] ([i915#12313]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_ccs@random-ccs-data-4-tiled-lnl-ccs.html * igt@kms_chamelium_audio@hdmi-audio-edid: - shard-tglu: NOTRUN -> [SKIP][57] ([i915#11151] / [i915#7828]) +1 other test skip [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-2/igt@kms_chamelium_audio@hdmi-audio-edid.html * igt@kms_chamelium_color@ctm-red-to-blue: - shard-rkl: NOTRUN -> [SKIP][58] +2 other tests skip [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_chamelium_color@ctm-red-to-blue.html * igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k: - shard-rkl: NOTRUN -> [SKIP][59] ([i915#11151] / [i915#7828]) +2 other tests skip [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k.html * igt@kms_chamelium_frames@dp-crc-multiple: - shard-mtlp: NOTRUN -> [SKIP][60] ([i915#11151] / [i915#7828]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_chamelium_frames@dp-crc-multiple.html * igt@kms_chamelium_frames@hdmi-crc-multiple: - shard-tglu-1: NOTRUN -> [SKIP][61] ([i915#11151] / [i915#7828]) +1 other test skip [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_chamelium_frames@hdmi-crc-multiple.html * igt@kms_cursor_crc@cursor-offscreen-32x10: - shard-tglu-1: NOTRUN -> [SKIP][62] ([i915#3555]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_cursor_crc@cursor-offscreen-32x10.html * igt@kms_cursor_crc@cursor-onscreen-32x10: - shard-mtlp: NOTRUN -> [SKIP][63] ([i915#3555] / [i915#8814]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_cursor_crc@cursor-onscreen-32x10.html * igt@kms_cursor_crc@cursor-onscreen-512x170: - shard-tglu: NOTRUN -> [SKIP][64] ([i915#13049]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_cursor_crc@cursor-onscreen-512x170.html * igt@kms_cursor_crc@cursor-random-128x42@pipe-a-hdmi-a-1: - shard-tglu-1: NOTRUN -> [FAIL][65] ([i915#13566]) +1 other test fail [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_cursor_crc@cursor-random-128x42@pipe-a-hdmi-a-1.html * igt@kms_cursor_crc@cursor-random-256x85: - shard-tglu: NOTRUN -> [FAIL][66] ([i915#13566]) +1 other test fail [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-2/igt@kms_cursor_crc@cursor-random-256x85.html * igt@kms_cursor_crc@cursor-rapid-movement-64x21: - shard-mtlp: NOTRUN -> [SKIP][67] ([i915#8814]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_cursor_crc@cursor-rapid-movement-64x21.html * igt@kms_cursor_crc@cursor-sliding-128x42: - shard-rkl: [PASS][68] -> [FAIL][69] ([i915#13566]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-2/igt@kms_cursor_crc@cursor-sliding-128x42.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_cursor_crc@cursor-sliding-128x42.html * igt@kms_cursor_crc@cursor-sliding-128x42@pipe-a-hdmi-a-2: - shard-rkl: NOTRUN -> [FAIL][70] ([i915#13566]) +1 other test fail [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_cursor_crc@cursor-sliding-128x42@pipe-a-hdmi-a-2.html * igt@kms_cursor_crc@cursor-suspend: - shard-tglu: NOTRUN -> [ABORT][71] ([i915#15317]) +2 other tests abort [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_cursor_crc@cursor-suspend.html - shard-glk10: NOTRUN -> [INCOMPLETE][72] ([i915#12358] / [i915#14152] / [i915#7882]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_cursor_crc@cursor-suspend.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-1: - shard-glk10: NOTRUN -> [INCOMPLETE][73] ([i915#12358] / [i915#14152]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-1.html * igt@kms_dither@fb-8bpc-vs-panel-8bpc: - shard-dg2: [PASS][74] -> [SKIP][75] ([i915#3555]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-11/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-8/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html * igt@kms_dp_aux_dev: - shard-dg2: [PASS][76] -> [SKIP][77] ([i915#1257]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-11/igt@kms_dp_aux_dev.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-7/igt@kms_dp_aux_dev.html * igt@kms_dp_linktrain_fallback@dp-fallback: - shard-mtlp: NOTRUN -> [SKIP][78] ([i915#13707]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_dp_linktrain_fallback@dp-fallback.html * igt@kms_dsc@dsc-with-bpc: - shard-tglu-1: NOTRUN -> [SKIP][79] ([i915#3555] / [i915#3840]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_dsc@dsc-with-bpc.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-glk: NOTRUN -> [INCOMPLETE][80] ([i915#9878]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk9/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_feature_discovery@chamelium: - shard-rkl: NOTRUN -> [SKIP][81] ([i915#4854]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_feature_discovery@chamelium.html * igt@kms_feature_discovery@dp-mst: - shard-tglu-1: NOTRUN -> [SKIP][82] ([i915#9337]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_feature_discovery@dp-mst.html * igt@kms_feature_discovery@psr1: - shard-rkl: NOTRUN -> [SKIP][83] ([i915#658]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_feature_discovery@psr1.html * igt@kms_flip@2x-flip-vs-dpms: - shard-tglu: NOTRUN -> [SKIP][84] ([i915#3637] / [i915#9934]) +1 other test skip [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_flip@2x-flip-vs-dpms.html * igt@kms_flip@2x-flip-vs-panning-vs-hang: - shard-rkl: NOTRUN -> [SKIP][85] ([i915#9934]) +1 other test skip [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_flip@2x-flip-vs-panning-vs-hang.html * igt@kms_flip@2x-modeset-vs-vblank-race: - shard-mtlp: NOTRUN -> [SKIP][86] ([i915#3637] / [i915#9934]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_flip@2x-modeset-vs-vblank-race.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-tglu-1: NOTRUN -> [ABORT][87] ([i915#15317]) +3 other tests abort [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_flip@flip-vs-suspend@a-dp3: - shard-dg2: NOTRUN -> [ABORT][88] ([i915#15317]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-11/igt@kms_flip@flip-vs-suspend@a-dp3.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling: - shard-mtlp: NOTRUN -> [SKIP][89] ([i915#2672] / [i915#3555] / [i915#8813]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][90] ([i915#2672] / [i915#8813]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-upscaling: - shard-glk10: NOTRUN -> [SKIP][91] +78 other tests skip [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-upscaling.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][92] ([i915#8708]) +1 other test skip [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbc-tiling-4: - shard-rkl: NOTRUN -> [SKIP][93] ([i915#5439]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_frontbuffer_tracking@fbc-tiling-4.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglu: NOTRUN -> [SKIP][94] ([i915#15102]) +5 other tests skip [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff: - shard-tglu-1: NOTRUN -> [SKIP][95] +13 other tests skip [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt: - shard-mtlp: NOTRUN -> [SKIP][96] ([i915#1825]) +8 other tests skip [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-wc: - shard-tglu: NOTRUN -> [SKIP][97] +11 other tests skip [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt: - shard-rkl: NOTRUN -> [SKIP][98] ([i915#1825]) +7 other tests skip [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render: - shard-snb: NOTRUN -> [SKIP][99] +41 other tests skip [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-snb4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary: - shard-rkl: NOTRUN -> [SKIP][100] ([i915#15102] / [i915#3023]) +2 other tests skip [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html * igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite: - shard-tglu-1: NOTRUN -> [SKIP][101] ([i915#15102]) +4 other tests skip [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite.html * igt@kms_hdr@invalid-metadata-sizes: - shard-dg2: [PASS][102] -> [SKIP][103] ([i915#3555] / [i915#8228]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-11/igt@kms_hdr@invalid-metadata-sizes.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-7/igt@kms_hdr@invalid-metadata-sizes.html * igt@kms_hdr@static-toggle-dpms: - shard-mtlp: NOTRUN -> [SKIP][104] ([i915#12713] / [i915#3555] / [i915#8228]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_hdr@static-toggle-dpms.html * igt@kms_joiner@basic-ultra-joiner: - shard-mtlp: NOTRUN -> [SKIP][105] ([i915#12339]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_joiner@basic-ultra-joiner.html * igt@kms_joiner@invalid-modeset-force-big-joiner: - shard-rkl: NOTRUN -> [SKIP][106] ([i915#10656] / [i915#12388]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_joiner@invalid-modeset-force-big-joiner.html * igt@kms_pipe_crc_basic@hang-read-crc: - shard-dg1: [PASS][107] -> [DMESG-WARN][108] ([i915#4423]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg1-13/igt@kms_pipe_crc_basic@hang-read-crc.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg1-12/igt@kms_pipe_crc_basic@hang-read-crc.html * igt@kms_plane@plane-panning-bottom-right-suspend: - shard-glk: NOTRUN -> [INCOMPLETE][109] ([i915#13026]) +1 other test incomplete [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk9/igt@kms_plane@plane-panning-bottom-right-suspend.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b: - shard-rkl: [PASS][110] -> [ABORT][111] ([i915#15317]) +1 other test abort [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-5/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-4/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b.html * igt@kms_plane_alpha_blend@alpha-transparent-fb: - shard-glk10: NOTRUN -> [FAIL][112] ([i915#10647] / [i915#12177]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_plane_alpha_blend@alpha-transparent-fb.html * igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1: - shard-glk10: NOTRUN -> [FAIL][113] ([i915#10647]) +1 other test fail [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1.html * igt@kms_plane_multiple@2x-tiling-x: - shard-mtlp: NOTRUN -> [SKIP][114] ([i915#13958]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_plane_multiple@2x-tiling-x.html * igt@kms_plane_scaling@intel-max-src-size: - shard-rkl: NOTRUN -> [SKIP][115] ([i915#6953]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_plane_scaling@intel-max-src-size.html * igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-c: - shard-tglu: NOTRUN -> [SKIP][116] ([i915#12247]) +4 other tests skip [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-c.html * igt@kms_plane_scaling@planes-downscale-factor-0-75: - shard-mtlp: NOTRUN -> [SKIP][117] ([i915#12247] / [i915#3555] / [i915#6953]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_plane_scaling@planes-downscale-factor-0-75.html * igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-b: - shard-mtlp: NOTRUN -> [SKIP][118] ([i915#12247]) +3 other tests skip [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-b.html * igt@kms_pm_dc@dc5-dpms-negative: - shard-mtlp: NOTRUN -> [SKIP][119] ([i915#13441]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_pm_dc@dc5-dpms-negative.html * igt@kms_pm_dc@dc5-psr: - shard-tglu-1: NOTRUN -> [SKIP][120] ([i915#9685]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_pm_dc@dc5-psr.html * igt@kms_pm_dc@dc9-dpms: - shard-rkl: NOTRUN -> [SKIP][121] ([i915#4281]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_pm_dc@dc9-dpms.html * igt@kms_pm_rpm@modeset-non-lpsp-stress: - shard-mtlp: NOTRUN -> [SKIP][122] ([i915#15073]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_pm_rpm@modeset-non-lpsp-stress.html * igt@kms_pm_rpm@system-suspend-modeset: - shard-glk: NOTRUN -> [ABORT][123] ([i915#10553] / [i915#15317]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk3/igt@kms_pm_rpm@system-suspend-modeset.html * igt@kms_prime@basic-crc-hybrid: - shard-mtlp: NOTRUN -> [SKIP][124] ([i915#6524]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_prime@basic-crc-hybrid.html * igt@kms_prime@basic-modeset-hybrid: - shard-rkl: NOTRUN -> [SKIP][125] ([i915#6524]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_prime@basic-modeset-hybrid.html * igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-exceed-fully-sf: - shard-snb: NOTRUN -> [SKIP][126] ([i915#11520]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-snb4/igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-exceed-sf@pipe-b-edp-1: - shard-mtlp: NOTRUN -> [SKIP][127] ([i915#12316]) +3 other tests skip [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-exceed-sf@pipe-b-edp-1.html * igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf: - shard-tglu-1: NOTRUN -> [SKIP][128] ([i915#11520]) +2 other tests skip [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf.html - shard-glk: NOTRUN -> [SKIP][129] ([i915#11520]) +9 other tests skip [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk6/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf.html * igt@kms_psr2_sf@fbc-psr2-overlay-plane-update-sf-dmg-area@pipe-a-edp-1: - shard-mtlp: NOTRUN -> [SKIP][130] ([i915#9808]) +1 other test skip [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_psr2_sf@fbc-psr2-overlay-plane-update-sf-dmg-area@pipe-a-edp-1.html * igt@kms_psr2_sf@pr-cursor-plane-update-sf: - shard-tglu: NOTRUN -> [SKIP][131] ([i915#11520]) +1 other test skip [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_psr2_sf@pr-cursor-plane-update-sf.html - shard-glk10: NOTRUN -> [SKIP][132] ([i915#11520]) [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk10/igt@kms_psr2_sf@pr-cursor-plane-update-sf.html * igt@kms_psr2_sf@pr-overlay-plane-update-sf-dmg-area: - shard-rkl: NOTRUN -> [SKIP][133] ([i915#11520]) +2 other tests skip [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_psr2_sf@pr-overlay-plane-update-sf-dmg-area.html * igt@kms_psr2_su@page_flip-xrgb8888: - shard-tglu: NOTRUN -> [SKIP][134] ([i915#9683]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_psr2_su@page_flip-xrgb8888.html * igt@kms_psr@fbc-psr-cursor-render: - shard-tglu: NOTRUN -> [SKIP][135] ([i915#9732]) +4 other tests skip [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-9/igt@kms_psr@fbc-psr-cursor-render.html * igt@kms_psr@fbc-psr2-cursor-mmap-gtt: - shard-glk: NOTRUN -> [SKIP][136] +253 other tests skip [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk3/igt@kms_psr@fbc-psr2-cursor-mmap-gtt.html * igt@kms_psr@pr-no-drrs: - shard-mtlp: NOTRUN -> [SKIP][137] ([i915#9688]) +10 other tests skip [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_psr@pr-no-drrs.html * igt@kms_psr@psr-cursor-plane-move: - shard-rkl: NOTRUN -> [SKIP][138] ([i915#1072] / [i915#9732]) +6 other tests skip [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_psr@psr-cursor-plane-move.html * igt@kms_psr@psr2-sprite-mmap-gtt: - shard-tglu-1: NOTRUN -> [SKIP][139] ([i915#9732]) +1 other test skip [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_psr@psr2-sprite-mmap-gtt.html * igt@kms_rotation_crc@primary-y-tiled-reflect-x-90: - shard-mtlp: NOTRUN -> [SKIP][140] ([i915#12755]) [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html * igt@kms_setmode@basic-clone-single-crtc: - shard-rkl: NOTRUN -> [SKIP][141] ([i915#3555]) [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_setmode@basic-clone-single-crtc.html * igt@kms_vrr@flip-basic-fastset: - shard-tglu-1: NOTRUN -> [SKIP][142] ([i915#9906]) [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-1/igt@kms_vrr@flip-basic-fastset.html * igt@kms_vrr@max-min: - shard-rkl: NOTRUN -> [SKIP][143] ([i915#9906]) [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_vrr@max-min.html * igt@kms_writeback@writeback-fb-id: - shard-glk: NOTRUN -> [SKIP][144] ([i915#2437]) [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk3/igt@kms_writeback@writeback-fb-id.html #### Possible fixes #### * igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0: - shard-dg2: [ABORT][145] ([i915#15317]) -> [PASS][146] [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-6/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-5/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0.html * igt@gem_exec_suspend@basic-s0@lmem0: - shard-dg2: [INCOMPLETE][147] ([i915#13356]) -> [PASS][148] [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-7/igt@gem_exec_suspend@basic-s0@lmem0.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-3/igt@gem_exec_suspend@basic-s0@lmem0.html * igt@gem_exec_suspend@basic-s0@smem: - shard-snb: [ABORT][149] ([i915#15317]) -> [PASS][150] +1 other test pass [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-snb7/igt@gem_exec_suspend@basic-s0@smem.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-snb4/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s4-devices: - shard-rkl: [ABORT][151] ([i915#15317] / [i915#7975]) -> [PASS][152] +1 other test pass [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@gem_exec_suspend@basic-s4-devices.html [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@gem_exec_suspend@basic-s4-devices.html * igt@gem_exec_suspend@basic-s4-devices@smem: - shard-dg2: [ABORT][153] ([i915#15317] / [i915#7975]) -> [PASS][154] [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-8/igt@gem_exec_suspend@basic-s4-devices@smem.html [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-6/igt@gem_exec_suspend@basic-s4-devices@smem.html * igt@gem_workarounds@suspend-resume-context: - shard-mtlp: [ABORT][155] ([i915#15317]) -> [PASS][156] +3 other tests pass [155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-mtlp-3/igt@gem_workarounds@suspend-resume-context.html [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-6/igt@gem_workarounds@suspend-resume-context.html * igt@i915_suspend@basic-s2idle-without-i915: - shard-glk: [ABORT][157] ([i915#15317]) -> [PASS][158] [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-glk5/igt@i915_suspend@basic-s2idle-without-i915.html [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk9/igt@i915_suspend@basic-s2idle-without-i915.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-tglu: [ABORT][159] ([i915#15317]) -> [PASS][160] [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-tglu-8/igt@i915_suspend@fence-restore-tiled2untiled.html [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-tglu-2/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_async_flips@async-flip-suspend-resume@pipe-b-hdmi-a-2: - shard-rkl: [ABORT][161] ([i915#15317]) -> [PASS][162] +1 other test pass [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-4/igt@kms_async_flips@async-flip-suspend-resume@pipe-b-hdmi-a-2.html [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-7/igt@kms_async_flips@async-flip-suspend-resume@pipe-b-hdmi-a-2.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip: - shard-mtlp: [FAIL][163] ([i915#5138]) -> [PASS][164] [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip.html [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip.html * igt@kms_pm_rpm@dpms-mode-unset-non-lpsp: - shard-dg2: [SKIP][165] ([i915#15073]) -> [PASS][166] [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-4/igt@kms_pm_rpm@dpms-mode-unset-non-lpsp.html [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-11/igt@kms_pm_rpm@dpms-mode-unset-non-lpsp.html * igt@kms_pm_rpm@i2c: - shard-dg1: [DMESG-WARN][167] ([i915#4423]) -> [PASS][168] [167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg1-16/igt@kms_pm_rpm@i2c.html [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg1-18/igt@kms_pm_rpm@i2c.html * igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait: - shard-rkl: [SKIP][169] ([i915#15073]) -> [PASS][170] +1 other test pass [169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-5/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-4/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html * igt@perf@blocking@0-rcs0: - shard-rkl: [FAIL][171] ([i915#10538]) -> [PASS][172] +1 other test pass [171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-8/igt@perf@blocking@0-rcs0.html [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-2/igt@perf@blocking@0-rcs0.html #### Warnings #### * igt@gem_create@create-ext-cpu-access-sanity-check: - shard-rkl: [SKIP][173] ([i915#6335]) -> [SKIP][174] ([i915#14544] / [i915#6335]) [173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@gem_create@create-ext-cpu-access-sanity-check.html [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@gem_create@create-ext-cpu-access-sanity-check.html * igt@gem_eio@in-flight-suspend: - shard-dg1: [ABORT][175] ([i915#15317] / [i915#4391] / [i915#4423]) -> [ABORT][176] ([i915#15317]) [175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg1-18/igt@gem_eio@in-flight-suspend.html [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg1-19/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_balancer@parallel-dmabuf-import-out-fence: - shard-rkl: [SKIP][177] ([i915#14544] / [i915#4525]) -> [SKIP][178] ([i915#4525]) [177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@gem_exec_balancer@parallel-dmabuf-import-out-fence.html [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@gem_exec_balancer@parallel-dmabuf-import-out-fence.html * igt@gem_exec_reloc@basic-wc-read-noreloc: - shard-rkl: [SKIP][179] ([i915#14544] / [i915#3281]) -> [SKIP][180] ([i915#3281]) +2 other tests skip [179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@gem_exec_reloc@basic-wc-read-noreloc.html [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@gem_exec_reloc@basic-wc-read-noreloc.html * igt@gem_lmem_swapping@heavy-verify-random: - shard-rkl: [SKIP][181] ([i915#14544] / [i915#4613]) -> [SKIP][182] ([i915#4613]) +1 other test skip [181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@gem_lmem_swapping@heavy-verify-random.html [182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-5/igt@gem_lmem_swapping@heavy-verify-random.html * igt@gem_workarounds@suspend-resume-context: - shard-rkl: [ABORT][183] ([i915#15317]) -> [INCOMPLETE][184] ([i915#13356]) [183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-5/igt@gem_workarounds@suspend-resume-context.html [184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-3/igt@gem_workarounds@suspend-resume-context.html * igt@gen7_exec_parse@chained-batch: - shard-rkl: [SKIP][185] -> [SKIP][186] ([i915#14544]) +5 other tests skip [185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@gen7_exec_parse@chained-batch.html [186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@gen7_exec_parse@chained-batch.html * igt@gen9_exec_parse@bb-oversize: - shard-rkl: [SKIP][187] ([i915#14544] / [i915#2527]) -> [SKIP][188] ([i915#2527]) [187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@gen9_exec_parse@bb-oversize.html [188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-5/igt@gen9_exec_parse@bb-oversize.html * igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs: - shard-rkl: [SKIP][189] ([i915#12313] / [i915#14544]) -> [SKIP][190] ([i915#12313]) [189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs.html [190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs.html * igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-rc-ccs: - shard-rkl: [SKIP][191] ([i915#14098] / [i915#14544] / [i915#6095]) -> [SKIP][192] ([i915#14098] / [i915#6095]) +1 other test skip [191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-rc-ccs.html [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-rc-ccs.html * igt@kms_chamelium_frames@dp-frame-dump: - shard-rkl: [SKIP][193] ([i915#11151] / [i915#7828]) -> [SKIP][194] ([i915#11151] / [i915#14544] / [i915#7828]) [193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@kms_chamelium_frames@dp-frame-dump.html [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@kms_chamelium_frames@dp-frame-dump.html * igt@kms_content_protection@content-type-change: - shard-rkl: [SKIP][195] ([i915#14544] / [i915#9424]) -> [SKIP][196] ([i915#9424]) [195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_content_protection@content-type-change.html [196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_content_protection@content-type-change.html * igt@kms_cursor_crc@cursor-rapid-movement-max-size: - shard-rkl: [SKIP][197] ([i915#14544] / [i915#3555]) -> [SKIP][198] ([i915#3555]) [197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html [198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-5/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html * igt@kms_cursor_crc@cursor-sliding-512x512: - shard-rkl: [SKIP][199] ([i915#13049]) -> [SKIP][200] ([i915#13049] / [i915#14544]) [199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@kms_cursor_crc@cursor-sliding-512x512.html [200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@kms_cursor_crc@cursor-sliding-512x512.html * igt@kms_cursor_legacy@cursorb-vs-flipb-toggle: - shard-rkl: [SKIP][201] ([i915#14544]) -> [SKIP][202] +2 other tests skip [201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html [202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html * igt@kms_dsc@dsc-basic: - shard-rkl: [SKIP][203] ([i915#14544] / [i915#3555] / [i915#3840]) -> [SKIP][204] ([i915#3555] / [i915#3840]) [203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_dsc@dsc-basic.html [204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_dsc@dsc-basic.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-rkl: [SKIP][205] ([i915#9934]) -> [SKIP][206] ([i915#14544] / [i915#9934]) [205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@2x-flip-vs-suspend: - shard-glk: [INCOMPLETE][207] ([i915#12314] / [i915#12745] / [i915#4839] / [i915#6113]) -> [INCOMPLETE][208] ([i915#12745] / [i915#4839] / [i915#6113]) [207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-glk5/igt@kms_flip@2x-flip-vs-suspend.html [208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk1/igt@kms_flip@2x-flip-vs-suspend.html * igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2: - shard-glk: [INCOMPLETE][209] ([i915#12314] / [i915#4839] / [i915#6113]) -> [INCOMPLETE][210] ([i915#4839] / [i915#6113]) [209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-glk5/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html [210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk1/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip@2x-flip-vs-wf_vblank: - shard-rkl: [SKIP][211] ([i915#14544] / [i915#9934]) -> [SKIP][212] ([i915#9934]) +2 other tests skip [211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_flip@2x-flip-vs-wf_vblank.html [212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_flip@2x-flip-vs-wf_vblank.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-glk: [INCOMPLETE][213] ([i915#12745] / [i915#4839]) -> [INCOMPLETE][214] ([i915#12745] / [i915#4839] / [i915#6113]) [213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-glk6/igt@kms_flip@flip-vs-suspend-interruptible.html [214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-glk3/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt: - shard-dg2: [SKIP][215] ([i915#15102] / [i915#3458]) -> [SKIP][216] ([i915#10433] / [i915#15102] / [i915#3458]) +1 other test skip [215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html [216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt: - shard-rkl: [SKIP][217] ([i915#14544] / [i915#1825]) -> [SKIP][218] ([i915#1825]) +8 other tests skip [217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html [218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt: - shard-rkl: [SKIP][219] ([i915#14544] / [i915#15102] / [i915#3023]) -> [SKIP][220] ([i915#15102] / [i915#3023]) +5 other tests skip [219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt.html [220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff: - shard-rkl: [SKIP][221] ([i915#1825]) -> [SKIP][222] ([i915#14544] / [i915#1825]) +1 other test skip [221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff.html [222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff.html * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu: - shard-dg2: [SKIP][223] ([i915#10433] / [i915#15102] / [i915#3458]) -> [SKIP][224] ([i915#15102] / [i915#3458]) [223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg2-4/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html [224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg2-11/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html - shard-rkl: [SKIP][225] ([i915#15102] / [i915#3023]) -> [SKIP][226] ([i915#14544] / [i915#15102] / [i915#3023]) +1 other test skip [225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html [226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html * igt@kms_panel_fitting@legacy: - shard-rkl: [SKIP][227] ([i915#14544] / [i915#6301]) -> [SKIP][228] ([i915#6301]) [227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_panel_fitting@legacy.html [228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-8/igt@kms_panel_fitting@legacy.html * igt@kms_psr@psr-cursor-plane-onoff: - shard-dg1: [SKIP][229] ([i915#1072] / [i915#4423] / [i915#9732]) -> [SKIP][230] ([i915#1072] / [i915#9732]) [229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-dg1-17/igt@kms_psr@psr-cursor-plane-onoff.html [230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-dg1-17/igt@kms_psr@psr-cursor-plane-onoff.html * igt@kms_psr@psr2-primary-page-flip: - shard-rkl: [SKIP][231] ([i915#1072] / [i915#14544] / [i915#9732]) -> [SKIP][232] ([i915#1072] / [i915#9732]) +1 other test skip [231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-6/igt@kms_psr@psr2-primary-page-flip.html [232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-5/igt@kms_psr@psr2-primary-page-flip.html * igt@kms_psr@psr2-sprite-render: - shard-rkl: [SKIP][233] ([i915#1072] / [i915#9732]) -> [SKIP][234] ([i915#1072] / [i915#14544] / [i915#9732]) +2 other tests skip [233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@kms_psr@psr2-sprite-render.html [234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@kms_psr@psr2-sprite-render.html * igt@prime_vgem@coherency-gtt: - shard-rkl: [SKIP][235] ([i915#3708]) -> [SKIP][236] ([i915#14544] / [i915#3708]) [235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17582/shard-rkl-3/igt@prime_vgem@coherency-gtt.html [236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/shard-rkl-6/igt@prime_vgem@coherency-gtt.html [i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307 [i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433 [i915#10538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10538 [i915#10553]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10553 [i915#10647]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10647 [i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656 [i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072 [i915#11078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11078 [i915#11151]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11151 [i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520 [i915#12177]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12177 [i915#12247]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12247 [i915#12313]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12313 [i915#12314]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12314 [i915#12316]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12316 [i915#12339]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12339 [i915#12358]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12358 [i915#12388]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12388 [i915#12392]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12392 [i915#1257]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1257 [i915#12713]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12713 [i915#12745]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12745 [i915#12755]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12755 [i915#12796]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12796 [i915#13026]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13026 [i915#13049]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13049 [i915#13356]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13356 [i915#13441]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13441 [i915#13566]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13566 [i915#13707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13707 [i915#13958]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13958 [i915#14098]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14098 [i915#14152]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14152 [i915#14544]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14544 [i915#14888]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14888 [i915#15073]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15073 [i915#15102]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15102 [i915#15313]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15313 [i915#15317]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15317 [i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825 [i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527 [i915#2658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672 [i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856 [i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023 [i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297 [i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458 [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637 [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708 [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840 [i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083 [i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281 [i915#4391]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4391 [i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423 [i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525 [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613 [i915#4839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4839 [i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854 [i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860 [i915#5138]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5138 [i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286 [i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439 [i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095 [i915#6113]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6113 [i915#6187]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6187 [i915#6301]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6301 [i915#6334]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6334 [i915#6335]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6335 [i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658 [i915#6953]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6953 [i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697 [i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828 [i915#7882]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7882 [i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975 [i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228 [i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428 [i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555 [i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708 [i915#8813]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8813 [i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814 [i915#9337]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9337 [i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424 [i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683 [i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685 [i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688 [i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732 [i915#9808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9808 [i915#9878]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9878 [i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906 [i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934 Build changes ------------- * Linux: CI_DRM_17582 -> Patchwork_158020v1 CI-20190529: 20190529 CI_DRM_17582: c9ffb8a8ab1294c1870e017e0502cb8089d3d8b8 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_8637: 730ee3dfb26f8d7891fc240b0132a08c5bc7b949 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_158020v1: c9ffb8a8ab1294c1870e017e0502cb8089d3d8b8 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158020v1/index.html [-- Attachment #2: Type: text/html, Size: 82459 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti ` (2 preceding siblings ...) 2025-11-25 22:22 ` ✗ i915.CI.Full: failure for " Patchwork @ 2025-11-26 2:01 ` Matthew Brost 2025-11-26 2:07 ` Matthew Brost 2025-11-26 15:50 ` Andi Shyti 5 siblings, 0 replies; 15+ messages in thread From: Matthew Brost @ 2025-11-26 2:01 UTC (permalink / raw) To: Nareshkumar Gollakoti; +Cc: intel-gfx On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: > The variable "fence" should be initialized to NULL, > and any usage of fence should be guarded > by a check to ensure it is not NULL > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > --- > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c > index afb06598b6e1..401f1835939b 100644 > --- a/drivers/gpu/drm/xe/xe_pagefault.c > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > struct xe_tile *tile = gt_to_tile(gt); > struct xe_validation_ctx ctx; > struct drm_exec exec; > - struct dma_fence *fence; > + struct dma_fence *fence = NULL; > int err, needs_vram; > > lockdep_assert_held_write(&vm->lock); > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > } > } > > - dma_fence_wait(fence, false); > - dma_fence_put(fence); > + if (fence) { > + dma_fence_wait(fence, false); > + dma_fence_put(fence); > + } Maybe I'm blind, but I don't see the problem in the existing code. How did this get reported as an issue which you are trying to fix here? Also I think Rodrigo mentioned this fixup! are not convention in DRM, rather 'Fixes' tags. Matt > > unlock_dma_resv: > xe_validation_ctx_fini(&ctx); > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti ` (3 preceding siblings ...) 2025-11-26 2:01 ` [PATCH] " Matthew Brost @ 2025-11-26 2:07 ` Matthew Brost 2025-11-26 4:02 ` Upadhyay, Tejas 2025-11-26 15:50 ` Andi Shyti 5 siblings, 1 reply; 15+ messages in thread From: Matthew Brost @ 2025-11-26 2:07 UTC (permalink / raw) To: Nareshkumar Gollakoti; +Cc: intel-gfx On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: > The variable "fence" should be initialized to NULL, > and any usage of fence should be guarded > by a check to ensure it is not NULL > I sent some replies to wrong list, see those but from Rodrigo: 'fixup in the commit subject is absolutely no no! This is a git indication that the patch should be squashed to the one introducing the error, but we are in a non-rebasing branch. So you need to provide a fix as a new patch and using the proper tags indicating which patch it is fixing and Cc'ing author and reviewer of the original patch.' You kinda ignored this feedback on the resend too... Matt > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > --- > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c > index afb06598b6e1..401f1835939b 100644 > --- a/drivers/gpu/drm/xe/xe_pagefault.c > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > struct xe_tile *tile = gt_to_tile(gt); > struct xe_validation_ctx ctx; > struct drm_exec exec; > - struct dma_fence *fence; > + struct dma_fence *fence = NULL; > int err, needs_vram; > > lockdep_assert_held_write(&vm->lock); > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > } > } > > - dma_fence_wait(fence, false); > - dma_fence_put(fence); > + if (fence) { > + dma_fence_wait(fence, false); > + dma_fence_put(fence); > + } > > unlock_dma_resv: > xe_validation_ctx_fini(&ctx); > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-26 2:07 ` Matthew Brost @ 2025-11-26 4:02 ` Upadhyay, Tejas 0 siblings, 0 replies; 15+ messages in thread From: Upadhyay, Tejas @ 2025-11-26 4:02 UTC (permalink / raw) To: Brost, Matthew, Kumar G, Naresh; +Cc: intel-gfx@lists.freedesktop.org > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Matthew Brost > Sent: 26 November 2025 07:37 > To: Kumar G, Naresh <naresh.kumar.g@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized > fence usage in xe_pagefault_handle_vma > > On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: > > The variable "fence" should be initialized to NULL, and any usage of > > fence should be guarded by a check to ensure it is not NULL > > > > I sent some replies to wrong list, see those but from Rodrigo: > > 'fixup in the commit subject is absolutely no no! This is a git > indication that the patch should be squashed to the one introducing the > error, but we are in a non-rebasing branch. So you need to provide a fix > as a new patch and using the proper tags indicating which patch it is > fixing and Cc'ing author and reviewer of the original patch.' > > You kinda ignored this feedback on the resend too... Naresh, lets discuss this offline and regenerate patch. Rodrigo and Matt, Thanks for feedback. Tejas > > Matt > > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > > --- > > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c > b/drivers/gpu/drm/xe/xe_pagefault.c > > index afb06598b6e1..401f1835939b 100644 > > --- a/drivers/gpu/drm/xe/xe_pagefault.c > > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, > struct xe_vma *vma, > > struct xe_tile *tile = gt_to_tile(gt); > > struct xe_validation_ctx ctx; > > struct drm_exec exec; > > - struct dma_fence *fence; > > + struct dma_fence *fence = NULL; > > int err, needs_vram; > > > > lockdep_assert_held_write(&vm->lock); > > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt > *gt, struct xe_vma *vma, > > } > > } > > > > - dma_fence_wait(fence, false); > > - dma_fence_put(fence); > > + if (fence) { > > + dma_fence_wait(fence, false); > > + dma_fence_put(fence); > > + } > > > > unlock_dma_resv: > > xe_validation_ctx_fini(&ctx); > > -- > > 2.43.0 > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti ` (4 preceding siblings ...) 2025-11-26 2:07 ` Matthew Brost @ 2025-11-26 15:50 ` Andi Shyti 2025-11-26 16:07 ` Kumar G, Naresh 5 siblings, 1 reply; 15+ messages in thread From: Andi Shyti @ 2025-11-26 15:50 UTC (permalink / raw) To: Nareshkumar Gollakoti; +Cc: intel-gfx Hi Nareshkumar, On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: > The variable "fence" should be initialized to NULL, > and any usage of fence should be guarded > by a check to ensure it is not NULL > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> is this a fix? ... > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > } > } > > - dma_fence_wait(fence, false); > - dma_fence_put(fence); > + if (fence) { > + dma_fence_wait(fence, false); > + dma_fence_put(fence); > + } have you seen a case where fence is NULL at this point? Thanks, Andi ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-26 15:50 ` Andi Shyti @ 2025-11-26 16:07 ` Kumar G, Naresh 0 siblings, 0 replies; 15+ messages in thread From: Kumar G, Naresh @ 2025-11-26 16:07 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx Hi Andi, Do not review this patch, have dropped this patch. Thanks, Naresh On 26-11-2025 21:20, Andi Shyti wrote: > Hi Nareshkumar, > > On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote: >> The variable "fence" should be initialized to NULL, >> and any usage of fence should be guarded >> by a check to ensure it is not NULL >> >> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > > is this a fix? > > ... > >> @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, >> } >> } >> >> - dma_fence_wait(fence, false); >> - dma_fence_put(fence); >> + if (fence) { >> + dma_fence_wait(fence, false); >> + dma_fence_put(fence); >> + } > > have you seen a case where fence is NULL at this point? > > Thanks, > Andi ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma @ 2025-11-25 10:24 Nareshkumar Gollakoti 2025-11-26 11:55 ` Yadav, Sanjay Kumar 0 siblings, 1 reply; 15+ messages in thread From: Nareshkumar Gollakoti @ 2025-11-25 10:24 UTC (permalink / raw) To: intel-xe; +Cc: naresh.kumar.g The variable "fence" should be initialized to NULL, and any usage of fence should be guarded by a check to ensure it is not NULL Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> --- drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index afb06598b6e1..401f1835939b 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, struct xe_tile *tile = gt_to_tile(gt); struct xe_validation_ctx ctx; struct drm_exec exec; - struct dma_fence *fence; + struct dma_fence *fence = NULL; int err, needs_vram; lockdep_assert_held_write(&vm->lock); @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, } } - dma_fence_wait(fence, false); - dma_fence_put(fence); + if (fence) { + dma_fence_wait(fence, false); + dma_fence_put(fence); + } unlock_dma_resv: xe_validation_ctx_fini(&ctx); -- 2.43.0 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-25 10:24 Nareshkumar Gollakoti @ 2025-11-26 11:55 ` Yadav, Sanjay Kumar 2025-11-26 13:17 ` Kumar G, Naresh 0 siblings, 1 reply; 15+ messages in thread From: Yadav, Sanjay Kumar @ 2025-11-26 11:55 UTC (permalink / raw) To: intel-xe On 25-11-2025 15:54, Nareshkumar Gollakoti wrote: > The variable "fence" should be initialized to NULL, > and any usage of fence should be guarded > by a check to ensure it is not NULL > > Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> LGTM nits: Add a dot at the end of the commit description. Reviewed-by: Sanjay Yadav <sanjay.kumar.yadav@intel.com> > --- > drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c > index afb06598b6e1..401f1835939b 100644 > --- a/drivers/gpu/drm/xe/xe_pagefault.c > +++ b/drivers/gpu/drm/xe/xe_pagefault.c > @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > struct xe_tile *tile = gt_to_tile(gt); > struct xe_validation_ctx ctx; > struct drm_exec exec; > - struct dma_fence *fence; > + struct dma_fence *fence = NULL; > int err, needs_vram; > > lockdep_assert_held_write(&vm->lock); > @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, struct xe_vma *vma, > } > } > > - dma_fence_wait(fence, false); > - dma_fence_put(fence); > + if (fence) { > + dma_fence_wait(fence, false); > + dma_fence_put(fence); > + } > > unlock_dma_resv: > xe_validation_ctx_fini(&ctx); ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma 2025-11-26 11:55 ` Yadav, Sanjay Kumar @ 2025-11-26 13:17 ` Kumar G, Naresh 0 siblings, 0 replies; 15+ messages in thread From: Kumar G, Naresh @ 2025-11-26 13:17 UTC (permalink / raw) To: Yadav, Sanjay Kumar, intel-xe Do Not Review, Ignore this patch. On 26-11-2025 17:25, Yadav, Sanjay Kumar wrote: > > On 25-11-2025 15:54, Nareshkumar Gollakoti wrote: >> The variable "fence" should be initialized to NULL, >> and any usage of fence should be guarded >> by a check to ensure it is not NULL >> >> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com> > > LGTM > > nits: Add a dot at the end of the commit description. > > Reviewed-by: Sanjay Yadav <sanjay.kumar.yadav@intel.com> > >> --- >> drivers/gpu/drm/xe/xe_pagefault.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/ >> xe_pagefault.c >> index afb06598b6e1..401f1835939b 100644 >> --- a/drivers/gpu/drm/xe/xe_pagefault.c >> +++ b/drivers/gpu/drm/xe/xe_pagefault.c >> @@ -70,7 +70,7 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, >> struct xe_vma *vma, >> struct xe_tile *tile = gt_to_tile(gt); >> struct xe_validation_ctx ctx; >> struct drm_exec exec; >> - struct dma_fence *fence; >> + struct dma_fence *fence = NULL; >> int err, needs_vram; >> lockdep_assert_held_write(&vm->lock); >> @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt >> *gt, struct xe_vma *vma, >> } >> } >> - dma_fence_wait(fence, false); >> - dma_fence_put(fence); >> + if (fence) { >> + dma_fence_wait(fence, false); >> + dma_fence_put(fence); >> + } >> unlock_dma_resv: >> xe_validation_ctx_fini(&ctx); ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2025-11-26 16:08 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-25 10:18 [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma Nareshkumar Gollakoti 2025-11-25 12:36 ` ✓ i915.CI.BAT: success for " Patchwork 2025-11-25 13:35 ` [PATCH] " Rodrigo Vivi 2025-11-25 14:48 ` Kumar G, Naresh 2025-11-26 2:03 ` Matthew Brost 2025-11-26 4:04 ` Upadhyay, Tejas 2025-11-25 22:22 ` ✗ i915.CI.Full: failure for " Patchwork 2025-11-26 2:01 ` [PATCH] " Matthew Brost 2025-11-26 2:07 ` Matthew Brost 2025-11-26 4:02 ` Upadhyay, Tejas 2025-11-26 15:50 ` Andi Shyti 2025-11-26 16:07 ` Kumar G, Naresh -- strict thread matches above, loose matches on Subject: below -- 2025-11-25 10:24 Nareshkumar Gollakoti 2025-11-26 11:55 ` Yadav, Sanjay Kumar 2025-11-26 13:17 ` Kumar G, Naresh
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.