From: Christoph Hellwig <hch@infradead.org>
To: Po-Wen Kao <powenkao@google.com>, Hannes Reinecke <hare@suse.com>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support
Date: Tue, 2 Dec 2025 23:38:59 -0800 [thread overview]
Message-ID: <aS_pE4nf7wQ031Y8@infradead.org> (raw)
In-Reply-To: <20251203073310.2248956-1-powenkao@google.com>
On Wed, Dec 03, 2025 at 07:33:08AM +0000, Po-Wen Kao wrote:
> From: Brian Kao <powenkao@google.com>
>
> Some low-level drivers (LLD) access block layer crypto fields, such as
> rq->crypt_keyslot and rq->crypt_ctx within `struct request`, to
> configure hardware for inline encryption.
So don't do that except for commands that can actually be encrypted,
i.e. those that have non-zero payload size. I think you really want
to fix this in the driver.
And we really need to stop passing scsi_cmnds to the error handler.
Hannes, any chance you could send another batch of your decades old
series?
next prev parent reply other threads:[~2025-12-03 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 7:33 [PATCH v2 1/1] scsi: core: Fix error handler encryption support Po-Wen Kao
2025-12-03 7:38 ` Christoph Hellwig [this message]
2025-12-03 8:42 ` Hannes Reinecke
2025-12-03 15:55 ` Bart Van Assche
2025-12-04 7:55 ` Hannes Reinecke
2025-12-03 15:57 ` Bart Van Assche
2025-12-04 10:13 ` Christoph Hellwig
2025-12-04 23:20 ` Brian Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS_pE4nf7wQ031Y8@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=powenkao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.