From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Po-Wen Kao <powenkao@google.com>, Hannes Reinecke <hare@suse.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support
Date: Thu, 4 Dec 2025 02:13:55 -0800 [thread overview]
Message-ID: <aTFe48CQcpCt6bm8@infradead.org> (raw)
In-Reply-To: <9d678edb-0db0-4ee5-9ad7-b2b141575026@acm.org>
On Wed, Dec 03, 2025 at 05:57:49AM -1000, Bart Van Assche wrote:
> That would make it impossible to submit SCSI commands from the SCSI
> error handler that read data, e.g. to check that the medium is still
> readable.
That's already impossible right now, because data mapping isn't handled
for EH commands.
> I think that the approach of this patch is better than
> requiring that every SCSI LLD driver that supports inline encryption
> only sets up inline encryption for commands that have a non-zero
> payload size.
There is exactly one such driver (ufshcd) and the error handler needs
to clean up how it sends commands anyway.
next prev parent reply other threads:[~2025-12-04 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 7:33 [PATCH v2 1/1] scsi: core: Fix error handler encryption support Po-Wen Kao
2025-12-03 7:38 ` Christoph Hellwig
2025-12-03 8:42 ` Hannes Reinecke
2025-12-03 15:55 ` Bart Van Assche
2025-12-04 7:55 ` Hannes Reinecke
2025-12-03 15:57 ` Bart Van Assche
2025-12-04 10:13 ` Christoph Hellwig [this message]
2025-12-04 23:20 ` Brian Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTFe48CQcpCt6bm8@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=powenkao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.