All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Sreedevi Joshi <sreedevi.joshi@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] idpf: update idpf_up_complete() return type to void
Date: Sat, 29 Nov 2025 10:54:51 +0000	[thread overview]
Message-ID: <aSrQ-2nLnQabIO34@horms.kernel.org> (raw)
In-Reply-To: <20251126170216.267289-1-sreedevi.joshi@intel.com>

On Wed, Nov 26, 2025 at 11:02:16AM -0600, Sreedevi Joshi wrote:
> idpf_up_complete() function always returns 0 and no callers use this return
> value. Although idpf_vport_open() checks the return value, it only handles
> error cases which never occur. Change the return type to void to simplify
> the code.
> 
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>


WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Sreedevi Joshi <sreedevi.joshi@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH iwl-next] idpf: update idpf_up_complete() return type to void
Date: Sat, 29 Nov 2025 10:54:51 +0000	[thread overview]
Message-ID: <aSrQ-2nLnQabIO34@horms.kernel.org> (raw)
In-Reply-To: <20251126170216.267289-1-sreedevi.joshi@intel.com>

On Wed, Nov 26, 2025 at 11:02:16AM -0600, Sreedevi Joshi wrote:
> idpf_up_complete() function always returns 0 and no callers use this return
> value. Although idpf_vport_open() checks the return value, it only handles
> error cases which never occur. Change the return type to void to simplify
> the code.
> 
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2025-11-29 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 17:02 [Intel-wired-lan] [PATCH iwl-next] idpf: update idpf_up_complete() return type to void Sreedevi Joshi
2025-11-26 17:02 ` Sreedevi Joshi
2025-11-29 10:54 ` Simon Horman [this message]
2025-11-29 10:54   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSrQ-2nLnQabIO34@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=aleksandr.loktionov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=sreedevi.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.