From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH, RFC] rename xfs.h
Date: Thu, 4 Dec 2025 20:04:50 +1100 [thread overview]
Message-ID: <aTFOsmgaPOhtaDeL@dread.disaster.area> (raw)
In-Reply-To: <20251202133723.1928059-1-hch@lst.de>
On Tue, Dec 02, 2025 at 02:37:19PM +0100, Christoph Hellwig wrote:
> Hi all,
>
> currently one of the biggest difference between the kernel and xfsprogs
> for the shared libxfs files is that the all kernel source files first
> include xfs.h, while in xfsprogs they first include libxfs_priv.h. The
> reason for that is that there is a public xfs.h header in xfsprogs that
> causes a namespace collision.
>
> This patch renames xfs.h in the kernel tree to xfs_priv.h, a name that
> is still available in xfsprogs.h. Any other name fitting that criteria
> should work just as well, I'm open to better suggestion if there are
> any.
fs/xfs/xfs.h is just a thin shim around fs/xfs/xfs_linux.h. Rather
than rename it, why not get rid of it and include xfs_linux.h
directly instead? I don't think userspace has a xfs_linux.h header
file anywhere...
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-12-04 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 13:37 [PATCH, RFC] rename xfs.h Christoph Hellwig
2025-12-02 13:37 ` [PATCH] xfs: rename xfs.h to xfs_priv.h Christoph Hellwig
2025-12-04 9:04 ` Dave Chinner [this message]
2025-12-04 9:23 ` [PATCH, RFC] rename xfs.h Christoph Hellwig
2025-12-04 17:21 ` Darrick J. Wong
2025-12-05 8:12 ` Christoph Hellwig
2025-12-05 16:29 ` Darrick J. Wong
2025-12-08 4:30 ` Dave Chinner
2025-12-10 6:08 ` Good name for xfs.h/libxfs_priv.h in libxfs Christoph Hellwig
2025-12-10 6:23 ` Darrick J. Wong
2025-12-10 22:51 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTFOsmgaPOhtaDeL@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.