From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH, RFC] rename xfs.h
Date: Mon, 8 Dec 2025 15:30:13 +1100 [thread overview]
Message-ID: <aTZUVTH4pMITncqc@dread.disaster.area> (raw)
In-Reply-To: <20251205081224.GA21377@lst.de>
On Fri, Dec 05, 2025 at 09:12:24AM +0100, Christoph Hellwig wrote:
> On Thu, Dec 04, 2025 at 09:21:58AM -0800, Darrick J. Wong wrote:
> > > Fine with me if that name is ok for shared code.
> >
> > Why not merge the xfs_linux.h stuff into xfs_priv.h? It's not like xfs
> > supports any other operating systems now.
>
> We should merge them anyway, but I understood Dave in that he preferred
> the xfs_linux.h name over xfs_priv.h one.
Yeah, that. It's really the include file for the platform specific
definitions, not anything "private" to XFS. If we want the same name
for userspace and kernel, then maybe xfs_platform.h is best, and
userspace can then include whatever OS/library specific platform
headers it needs from that.
> I don't really care either
> way, I just don't want to redo the patch too many times.
*nod*
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-12-08 4:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 13:37 [PATCH, RFC] rename xfs.h Christoph Hellwig
2025-12-02 13:37 ` [PATCH] xfs: rename xfs.h to xfs_priv.h Christoph Hellwig
2025-12-04 9:04 ` [PATCH, RFC] rename xfs.h Dave Chinner
2025-12-04 9:23 ` Christoph Hellwig
2025-12-04 17:21 ` Darrick J. Wong
2025-12-05 8:12 ` Christoph Hellwig
2025-12-05 16:29 ` Darrick J. Wong
2025-12-08 4:30 ` Dave Chinner [this message]
2025-12-10 6:08 ` Good name for xfs.h/libxfs_priv.h in libxfs Christoph Hellwig
2025-12-10 6:23 ` Darrick J. Wong
2025-12-10 22:51 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTZUVTH4pMITncqc@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.