linux-next: Signed-off-by missing for commit in the perf tree

linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Hi all,

Commit

  6528cdd61590 ("perf tests stat: Add test for error for an offline CPU")

is missing a Signed-off-by from its author and committer.

I presume the original patch was truncated somehow.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Ian Rogers]

On Thu, Dec 4, 2025 at 2:24 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commit
>
>   6528cdd61590 ("perf tests stat: Add test for error for an offline CPU")
>
> is missing a Signed-off-by from its author and committer.
>
> I presume the original patch was truncated somehow.

Yeah, there was log output that had a line starting "---"
https://lore.kernel.org/lkml/20251203214706.112174-7-irogers@google.com/

Sorry for the trouble this has caused.
Ian

> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Namhyung Kim]

On Thu, Dec 04, 2025 at 02:52:34PM -0800, Ian Rogers wrote:
> On Thu, Dec 4, 2025 at 2:24 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > Commit
> >
> >   6528cdd61590 ("perf tests stat: Add test for error for an offline CPU")
> >
> > is missing a Signed-off-by from its author and committer.
> >
> > I presume the original patch was truncated somehow.
> 
> Yeah, there was log output that had a line starting "---"
> https://lore.kernel.org/lkml/20251203214706.112174-7-irogers@google.com/
> 
> Sorry for the trouble this has caused.
> Ian

Oops, actually that's the reason I prefer having spaces in the front.
I'll take care of it and force push soon.

Thanks,
Namhyung

linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

Hi all,

Commit

  8791a78fb70e ("perf test: Remove duplicate word")

is missing a Signed-off-by from its author.

This is probably not necessarily necessary ;-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Arnaldo Carvalho de Melo]

On Mon, Dec 16, 2024 at 08:27:25AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   8791a78fb70e ("perf test: Remove duplicate word")
> 
> is missing a Signed-off-by from its author.
> 
> This is probably not necessarily necessary ;-)

:-)

I can force push after the original author provides the Signed-off-by,
but for such a simple patch can we just keep things as-is?

Is that that what you're saying?

- Arnaldo

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi Arnaldo,

On Mon, 16 Dec 2024 21:33:39 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> I can force push after the original author provides the Signed-off-by,
> but for such a simple patch can we just keep things as-is?
> 
> Is that that what you're saying?

Yeah, hardly worth a rebase/rewrite.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Arnaldo Carvalho de Melo]

On Tue, Dec 17, 2024 at 11:39:47AM +1100, Stephen Rothwell wrote:
> Hi Arnaldo,
> 
> On Mon, 16 Dec 2024 21:33:39 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > I can force push after the original author provides the Signed-off-by,
> > but for such a simple patch can we just keep things as-is?
> > 
> > Is that that what you're saying?
> 
> Yeah, hardly worth a rebase/rewrite.

So thanks for the report, I'll try and improve my automation practices :-\

- Arnaldo

linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hi all,

Commit

  08b953508560 ("perf evsel: Fallback to "task-clock" when not system wide")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Arnaldo Carvalho de Melo]

Em Wed, Dec 06, 2023 at 09:14:33AM +1100, Stephen Rothwell escreveu:
> Commit
 
>   08b953508560 ("perf evsel: Fallback to "task-clock" when not system wide")
 
> is missing a Signed-off-by from its author.

Thanks for the report, fixed, the issue was that Ian's S-o-B was after a

--- line and thus git-am chopped it up :-\

===============================================================================

When the cycles event isn't available evsel will fallback to the
cpu-clock software event. task-clock is similar to cpu-clock but only
runs when the process is running. Falling back to cpu-clock when not
system wide leads to confusion, by falling back to task-clock it is
hoped the confusion is less.

Pass the target to determine if task-clock is more appropriate. Update
a nearby comment and debug string for the change.

---
v2. Use target__has_cpu as suggested by Namhyung.
https://lpc.events/event/17/contributions/1556/

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/builtin-record.c |  2 +-
 tools/perf/builtin-stat.c   |  2 +-
 tools/perf/builtin-top.c    |  2 +-
 tools/perf/util/evsel.c     | 18 ++++++++++--------
 tools/perf/util/evsel.h     |  3 ++-
 5 files changed, 15 insertions(+), 12 deletions(-

--
===============================================================================

I'll check my pre-commit hooks to see why this didn't get flagged...

- Arnaldo

linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Hi all,

Commits

  19d8ab40f89b ("perf test stat+shadow_stat.sh: Add threshold for rounding errors")
  0c4ded92280b ("perf test lock_contention.sh: Skip test if the number of CPUs is low")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Namhyung Kim]

Hello Stephen,

On Thu, Sep 14, 2023 at 2:26 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
>   19d8ab40f89b ("perf test stat+shadow_stat.sh: Add threshold for rounding errors")
>   0c4ded92280b ("perf test lock_contention.sh: Skip test if the number of CPUs is low")
>
> are missing a Signed-off-by from their author.

Thanks for the notice.  As they're recently added, I think I can replace them
with new commits with s-o-b from the author and force-push.

Veronika, can you resend those two commits with your Sign-off?

Thanks,
Namhyung

linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

Hi all,

Commit

  9e03ed43cd4f ("perf stat: Check existence of os->prefix, fixing a segfault")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Arnaldo Carvalho de Melo]

On December 13, 2022 6:34:34 PM GMT-03:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>Hi all,
>
>Commit
>
>  9e03ed43cd4f ("perf stat: Check existence of os->prefix, fixing a segfault")
>
>is missing a Signed-off-by from its author.

Thanks, I'll fix this as well.

- Arnaldo 
>

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Ian Rogers]

On Tue, Dec 13, 2022 at 1:37 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
>
>
> On December 13, 2022 6:34:34 PM GMT-03:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >Hi all,
> >
> >Commit
> >
> >  9e03ed43cd4f ("perf stat: Check existence of os->prefix, fixing a segfault")
> >
> >is missing a Signed-off-by from its author.
>
> Thanks, I'll fix this as well.
>
> - Arnaldo

Happy any which way this is resolved. In case it is useful:
Signed-off-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> >

linux-next: Signed-off-by missing for commit in the perf tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi all,

Commit

  a2879339be71 ("perf bpf: No need to include headers just use forward declarations")

is missing a Signed-off-by from its author and committer.

Just a misspelt "Signed-off-by".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the perf tree

[Arnaldo Carvalho de Melo]

Em Mon, Oct 31, 2022 at 07:45:02AM +1100, Stephen Rothwell escreveu:
> Hi all,
> 
> Commit
> 
>   a2879339be71 ("perf bpf: No need to include headers just use forward declarations")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Just a misspelt "Signed-off-by".

Ouch, I'll fix it and force push.

- Arnaldo