All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/swtpm: needs gmp
@ 2025-12-08 17:44 Bernd Kuhls
  2025-12-08 18:54 ` Jarkko Sakkinen via buildroot
  2025-12-14 17:06 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2025-12-08 17:44 UTC (permalink / raw)
  To: buildroot; +Cc: Jarkko Sakkinen

Buildroot commit 2b449935c2e8e19a03a8962f49493a76ccca11f9 bumped swtpm
from version 0.8.2 to 0.10.1.

Upstream added gmp as dependency in version 0.9.0:
https://github.com/stefanberger/swtpm/commit/605e0ce8800201fca2a9a37dea5e99be7bdb2233

This causes build errors which are fixed by adding host-gmp as
dependency.

Fixes:
https://autobuild.buildroot.net/results/d14/d14b2953e04b488b2f357386870d557d50190d34/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/swtpm/swtpm.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/swtpm/swtpm.mk b/package/swtpm/swtpm.mk
index 25377f5771..de7f2fa05e 100644
--- a/package/swtpm/swtpm.mk
+++ b/package/swtpm/swtpm.mk
@@ -10,6 +10,7 @@ SWTPM_LICENSE = BSD-4-Clause
 SWTPM_LICENSE_FILES = LICENSE
 
 HOST_SWTPM_DEPENDENCIES = \
+	host-gmp \
 	host-json-glib \
 	host-libopenssl \
 	host-libtasn1 \
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/swtpm: needs gmp
  2025-12-08 17:44 [Buildroot] [PATCH 1/1] package/swtpm: needs gmp Bernd Kuhls
@ 2025-12-08 18:54 ` Jarkko Sakkinen via buildroot
  2025-12-14 17:06 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen via buildroot @ 2025-12-08 18:54 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

On Mon, Dec 08, 2025 at 06:44:27PM +0100, Bernd Kuhls wrote:
> Buildroot commit 2b449935c2e8e19a03a8962f49493a76ccca11f9 bumped swtpm
> from version 0.8.2 to 0.10.1.
> 
> Upstream added gmp as dependency in version 0.9.0:
> https://github.com/stefanberger/swtpm/commit/605e0ce8800201fca2a9a37dea5e99be7bdb2233
> 
> This causes build errors which are fixed by adding host-gmp as
> dependency.
> 
> Fixes:
> https://autobuild.buildroot.net/results/d14/d14b2953e04b488b2f357386870d557d50190d34/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/swtpm/swtpm.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/swtpm/swtpm.mk b/package/swtpm/swtpm.mk
> index 25377f5771..de7f2fa05e 100644
> --- a/package/swtpm/swtpm.mk
> +++ b/package/swtpm/swtpm.mk
> @@ -10,6 +10,7 @@ SWTPM_LICENSE = BSD-4-Clause
>  SWTPM_LICENSE_FILES = LICENSE
>  
>  HOST_SWTPM_DEPENDENCIES = \
> +	host-gmp \
>  	host-json-glib \
>  	host-libopenssl \
>  	host-libtasn1 \
> -- 
> 2.47.3
> 

Thanks! I missed that sorry.


Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/swtpm: needs gmp
  2025-12-08 17:44 [Buildroot] [PATCH 1/1] package/swtpm: needs gmp Bernd Kuhls
  2025-12-08 18:54 ` Jarkko Sakkinen via buildroot
@ 2025-12-14 17:06 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-14 17:06 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Jarkko Sakkinen

On Mon,  8 Dec 2025 18:44:27 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Buildroot commit 2b449935c2e8e19a03a8962f49493a76ccca11f9 bumped swtpm
> from version 0.8.2 to 0.10.1.
> 
> Upstream added gmp as dependency in version 0.9.0:
> https://github.com/stefanberger/swtpm/commit/605e0ce8800201fca2a9a37dea5e99be7bdb2233
> 
> This causes build errors which are fixed by adding host-gmp as
> dependency.
> 
> Fixes:
> https://autobuild.buildroot.net/results/d14/d14b2953e04b488b2f357386870d557d50190d34/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Thanks for this *good* commit log, which has all the information
needed! If you could make sure all your commit logs fixing build issues
have the same level of information, it would be A-M-A-Z-I-N-G.

Jarkko: since you maintain this package, it would be good to report
upstream the issue that <gmp.h> is being included without a proper
check for gmp's availability in configure.ac. This should be fixed
upstream.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-12-14 17:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-08 17:44 [Buildroot] [PATCH 1/1] package/swtpm: needs gmp Bernd Kuhls
2025-12-08 18:54 ` Jarkko Sakkinen via buildroot
2025-12-14 17:06 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.