Re: [PATCH i-g-t 08/10] lib/kms: Introduce igt_output_set_crtc()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Dec 10, 2025 at 04:38:38PM +0200, Jani Nikula wrote:
> On Wed, 10 Dec 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Wed, 10 Dec 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> >> On Wed, 10 Dec 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> >>> +/**
> >>> + * igt_output_set_pipe:
> >>> + * @output: Target output for which the pipe is being set to
> >>> + * @pipe_obj: Display pipe to set to
> >>> + *
> >>> + * This function sets a @pipe to a specific @output connector by
> >>> + * setting the CRTC_ID property of the @pipe. The pipe
> >>> + * is only activated for all pipes except PIPE_NONE.
> >>> + */
> >>> +void igt_output_set_pipe(igt_output_t *output, enum pipe pipe)
> >>> +{
> >>> +	igt_output_set_crtc(output, igt_crtc_for_pipe(output->display, pipe));
> >>
> >> How does that work for the igt_output_set_pipe(output, PIPE_NONE) calls?
> >> Seems like the idea was to pass NULL here? Or should igt_crtc_for_pipe()
> >> handle PIPE_NONE and return NULL?
> >
> > Okay, so it's just this one commit that's busted, as the whole function
> > is removed in the next patch.
> 
> I think igt_crtc_for_pipe() should handle PIPE_NONE, as there are a
> bunch of places in the next patch that pass, say, data->pipe_id to it,
> and it's a nightmare to check where all those come from.

Ack. I thought I did that already, but apparently not.

> 
> >
> >>
> >>> +}
> >>> +
> >>>  static
> >>>  bool __override_all_active_output_modes_to_fit_bw(igt_display_t *display,
> >>>  						  igt_output_t *outputs[IGT_MAX_PIPES],
> >>> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> >>> index a9d2d9027ae8..9ec0f08ada24 100644
> >>> --- a/lib/igt_kms.h
> >>> +++ b/lib/igt_kms.h
> >>> @@ -589,6 +589,7 @@ drmModeModeInfo *igt_output_get_highres_mode(igt_output_t *output);
> >>>  drmModeModeInfo *igt_output_get_lowres_mode(igt_output_t *output);
> >>>  void igt_output_override_mode(igt_output_t *output, const drmModeModeInfo *mode);
> >>>  int igt_output_preferred_vrefresh(igt_output_t *output);
> >>> +void igt_output_set_crtc(igt_output_t *output, igt_pipe_t *pipe_obj);
> >>>  void igt_output_set_pipe(igt_output_t *output, enum pipe pipe);
> >>>  igt_plane_t *igt_output_get_plane(igt_output_t *output, int plane_idx);
> >>>  igt_plane_t *igt_output_get_plane_type(igt_output_t *output, int plane_type);
> 
> -- 
> Jani Nikula, Intel

-- 
Ville Syrjälä
Intel