Re: [PATCH] firmware: arm_scmi: Fix unused notifier-block in unregister

[Dan Carpenter <dan.carpenter@linaro.org>]

On Thu, Dec 11, 2025 at 12:17:01PM +0000, Cristian Marussi wrote:
> On Thu, Dec 11, 2025 at 01:49:27PM +0200, Amitai Gottlieb wrote:
> > In function `scmi_devm_notifier_unregister` the notifier-block parameter
> > was unused and therefore never passed to `devres_release`. This causes
> > the function to always return -ENOENT and fail to unregister the
> > notifier.
> 
> [ CC-ing also Sudeep ]
> 
> Hi,
> 
> thanks for this.
> 
> LGTM.
> 
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
> 
> > 
> > In drivers that rely on this function for cleanup this causes
> > unexpected failures including kernel-panic.
> > 
> > Fixes: 5ad3d1cf7d34 ("firmware: arm_scmi: Introduce new devres
> > notification ops")

This Fixes tag needs to be all on one line.
Fixes: 5ad3d1cf7d34 ("firmware: arm_scmi: Introduce new devres notification ops")

> > Signed-off-by: Amitai Gottlieb <amitaig@hailo.ai>
> > ---
> > 
> > This is not needed upstream becaues the bug was fixed
> > in a refactor by commit 264a2c520628 ("firmware: arm_scmi: Simplify
> > scmi_devm_notifier_unregister").  It is needed for the 5.15, 6.1 and
> > 6.6 kernels.
> 
> I think there is some sort of syntax to refer to the applicable Kernel
> versions in the tag line....not sure it can be easily followed here...so
> maybe the above comment is enough...
> 
> More details here...
> 
> https://docs.kernel.org/process/stable-kernel-rules.html

I'm pretty sure those little comments aren't parsed automatically...
It feels duplicative.  I don't love those little notes because it feels
like the Fixes tag should normally be sufficient otherwise I want a full
explanation.  There was an embarrassing bug where the notes were wrong
and the patch was missing a Fixes tag so it wasn't backported far enough
in distro kernels.

It can't hurt to add them to the tag section, I suppose.

Cc: <stable@vger.kernel.org> # 5.15.x, 6.1.x, and 6.6.x

Leaving them out is also fine, really.

We definitely still need the note.  I said before that note about
"This is not needed upstream becaues the bug was fixed
in a refactor by commit 264a2c520628 ("firmware: arm_scmi: Simplify
scmi_devm_notifier_unregister")" should go under the --- cut off line,
but actually I think now that it should go into the actual commit
message itself.  Otherwise people who work on distro kernels, for
example, will wonder why the commit doesn't have an upstream hash.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

Wait until Sudeep has responded, and then resend the patch to
stable@vger.kernel.org with all the Reviewed-by tags.

regards,
dan carpenter