Re: [PATCH] firmware: arm_scmi: Fix unused notifier-block in unregister

[Cristian Marussi <cristian.marussi@arm.com>]

On Thu, Dec 11, 2025 at 01:49:27PM +0200, Amitai Gottlieb wrote:
> In function `scmi_devm_notifier_unregister` the notifier-block parameter
> was unused and therefore never passed to `devres_release`. This causes
> the function to always return -ENOENT and fail to unregister the
> notifier.

[ CC-ing also Sudeep ]

Hi,

thanks for this.

LGTM.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

> 
> In drivers that rely on this function for cleanup this causes
> unexpected failures including kernel-panic.
> 
> Fixes: 5ad3d1cf7d34 ("firmware: arm_scmi: Introduce new devres
> notification ops")
> Signed-off-by: Amitai Gottlieb <amitaig@hailo.ai>
> ---
> 
> This is not needed upstream becaues the bug was fixed
> in a refactor by commit 264a2c520628 ("firmware: arm_scmi: Simplify
> scmi_devm_notifier_unregister").  It is needed for the 5.15, 6.1 and
> 6.6 kernels.

I think there is some sort of syntax to refer to the applicable Kernel
versions in the tag line....not sure it can be easily followed here...so
maybe the above comment is enough...

More details here...

https://docs.kernel.org/process/stable-kernel-rules.html

Thanks,
Cristian