* [PATCH] tests/functional: Fix URL of gb200nvl-bmc image @ 2025-12-22 7:33 Cédric Le Goater 2025-12-22 9:31 ` Philippe Mathieu-Daudé 2025-12-22 12:52 ` Cédric Le Goater 0 siblings, 2 replies; 8+ messages in thread From: Cédric Le Goater @ 2025-12-22 7:33 UTC (permalink / raw) To: qemu-devel Cc: Thomas Huth, Philippe Mathieu-Daudé, Cédric Le Goater, Ed Tanous, Patrick Williams Commit [1] moved the FW image of the gb200nvl-bmc machine and broke the associated functional test. Fix that. [1] https://github.com/legoater/qemu-aspeed-boot/commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a Cc: Ed Tanous <etanous@nvidia.com> Cc: Patrick Williams <patrick@stwcx.xyz> Signed-off-by: Cédric Le Goater <clg@redhat.com> --- tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py index 8e8e3f05c1b2..e5f2dce0f569 100755 --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py @@ -11,7 +11,7 @@ class GB200Machine(AspeedTest): ASSET_GB200_FLASH = Asset( - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') def test_arm_aspeed_gb200_openbmc(self): -- 2.52.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-22 7:33 [PATCH] tests/functional: Fix URL of gb200nvl-bmc image Cédric Le Goater @ 2025-12-22 9:31 ` Philippe Mathieu-Daudé 2025-12-22 12:52 ` Cédric Le Goater 1 sibling, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2025-12-22 9:31 UTC (permalink / raw) To: Cédric Le Goater, qemu-devel Cc: Thomas Huth, Ed Tanous, Patrick Williams On 22/12/25 08:33, Cédric Le Goater wrote: > Commit [1] moved the FW image of the gb200nvl-bmc machine and broke > the associated functional test. Fix that. > > [1] https://github.com/legoater/qemu-aspeed-boot/commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a > > Cc: Ed Tanous <etanous@nvidia.com> > Cc: Patrick Williams <patrick@stwcx.xyz> > Signed-off-by: Cédric Le Goater <clg@redhat.com> > --- > tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-22 7:33 [PATCH] tests/functional: Fix URL of gb200nvl-bmc image Cédric Le Goater 2025-12-22 9:31 ` Philippe Mathieu-Daudé @ 2025-12-22 12:52 ` Cédric Le Goater 2025-12-23 22:11 ` Patrick Williams 2025-12-24 10:51 ` Philippe Mathieu-Daudé 1 sibling, 2 replies; 8+ messages in thread From: Cédric Le Goater @ 2025-12-22 12:52 UTC (permalink / raw) To: qemu-devel Cc: Thomas Huth, Philippe Mathieu-Daudé, Ed Tanous, Patrick Williams On 12/22/25 08:33, Cédric Le Goater wrote: > Commit [1] moved the FW image of the gb200nvl-bmc machine and broke > the associated functional test. Fix that. > > [1] https://github.com/legoater/qemu-aspeed-boot/commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a > > Cc: Ed Tanous <etanous@nvidia.com> > Cc: Patrick Williams <patrick@stwcx.xyz> > Signed-off-by: Cédric Le Goater <clg@redhat.com> > --- > tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py > index 8e8e3f05c1b2..e5f2dce0f569 100755 > --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py > +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py > @@ -11,7 +11,7 @@ > class GB200Machine(AspeedTest): > > ASSET_GB200_FLASH = Asset( > - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', > + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', > 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') > > def test_arm_aspeed_gb200_openbmc(self): Applied to aspeed-next. Thanks, C. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-22 12:52 ` Cédric Le Goater @ 2025-12-23 22:11 ` Patrick Williams 2025-12-24 11:25 ` Cédric Le Goater 2025-12-24 10:51 ` Philippe Mathieu-Daudé 1 sibling, 1 reply; 8+ messages in thread From: Patrick Williams @ 2025-12-23 22:11 UTC (permalink / raw) To: Cédric Le Goater Cc: qemu-devel, Thomas Huth, Philippe Mathieu-Daudé, Ed Tanous [-- Attachment #1: Type: text/plain, Size: 1018 bytes --] On Mon, Dec 22, 2025 at 01:52:19PM +0100, Cédric Le Goater wrote: > On 12/22/25 08:33, Cédric Le Goater wrote: > > ASSET_GB200_FLASH = Asset( > > - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', > > + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', > > 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') Should we make these commits or tags rather than `master`? Right now it seems only Catalina uses a permalink where as all the others appear to use `master` references. functional/arm/test_aspeed_catalina.py 14: 'https://github.com/legoater/qemu-aspeed-boot/raw/a866feb5ef81245b4827a214584bf6bcc72939f6/images/catalina-bmc/obmc-phosphor-image-catalina-20250619123021.static.mtd.xz', -- Patrick Williams [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-23 22:11 ` Patrick Williams @ 2025-12-24 11:25 ` Cédric Le Goater 0 siblings, 0 replies; 8+ messages in thread From: Cédric Le Goater @ 2025-12-24 11:25 UTC (permalink / raw) To: Patrick Williams Cc: qemu-devel, Thomas Huth, Philippe Mathieu-Daudé, Ed Tanous On 12/23/25 23:11, Patrick Williams wrote: > On Mon, Dec 22, 2025 at 01:52:19PM +0100, Cédric Le Goater wrote: >> On 12/22/25 08:33, Cédric Le Goater wrote: >>> ASSET_GB200_FLASH = Asset( >>> - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', >>> + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz', >>> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') > > Should we make these commits or tags rather than `master`? Right now it > seems only Catalina uses a permalink where as all the others appear to > use `master` references. The main objective is to be able to add new images without breaking existing tests. As long as there is some version number in the fw image file, I don't think it matters much. I would opt for master. Thanks, C. > > functional/arm/test_aspeed_catalina.py > 14: 'https://github.com/legoater/qemu-aspeed-boot/raw/a866feb5ef81245b4827a214584bf6bcc72939f6/images/catalina-bmc/obmc-phosphor-image-catalina-20250619123021.static.mtd.xz', > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-22 12:52 ` Cédric Le Goater 2025-12-23 22:11 ` Patrick Williams @ 2025-12-24 10:51 ` Philippe Mathieu-Daudé 2025-12-24 11:27 ` Cédric Le Goater 1 sibling, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2025-12-24 10:51 UTC (permalink / raw) To: Cédric Le Goater, qemu-devel, Richard Henderson, Stefan Hajnoczi, Peter Maydell Cc: Thomas Huth, Ed Tanous, Patrick Williams, Daniel P. Berrangé On 22/12/25 13:52, Cédric Le Goater wrote: > On 12/22/25 08:33, Cédric Le Goater wrote: >> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke >> the associated functional test. Fix that. >> >> [1] https://github.com/legoater/qemu-aspeed-boot/ >> commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a >> >> Cc: Ed Tanous <etanous@nvidia.com> >> Cc: Patrick Williams <patrick@stwcx.xyz> >> Signed-off-by: Cédric Le Goater <clg@redhat.com> >> --- >> tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/ >> functional/arm/test_aspeed_gb200nvl_bmc.py >> index 8e8e3f05c1b2..e5f2dce0f569 100755 >> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py >> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py >> @@ -11,7 +11,7 @@ >> class GB200Machine(AspeedTest): >> ASSET_GB200_FLASH = Asset( >> - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ >> master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl- >> obmc-20250702182348.static.mtd.xz', >> + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ >> master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image- >> gb200nvl-obmc-20250702182348.static.mtd.xz', >> >> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') >> def test_arm_aspeed_gb200_openbmc(self): > > Applied to aspeed-next. Thanks, this is part of the 2 build failures blocking current pull requests (other one being https://lore.kernel.org/qemu-devel/20251224085714.83169-1-philmd@linaro.org/). If we really want to consider our CI as source of truth (and blocking when not green), then please consider applying it directly on master as a build fix (maintainers Cc'ed). Regards, Phil. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-24 10:51 ` Philippe Mathieu-Daudé @ 2025-12-24 11:27 ` Cédric Le Goater 2025-12-30 20:59 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 8+ messages in thread From: Cédric Le Goater @ 2025-12-24 11:27 UTC (permalink / raw) To: Philippe Mathieu-Daudé, qemu-devel, Richard Henderson, Stefan Hajnoczi, Peter Maydell Cc: Thomas Huth, Ed Tanous, Patrick Williams, Daniel P. Berrangé On 12/24/25 11:51, Philippe Mathieu-Daudé wrote: > On 22/12/25 13:52, Cédric Le Goater wrote: >> On 12/22/25 08:33, Cédric Le Goater wrote: >>> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke >>> the associated functional test. Fix that. >>> >>> [1] https://github.com/legoater/qemu-aspeed-boot/ commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a >>> >>> Cc: Ed Tanous <etanous@nvidia.com> >>> Cc: Patrick Williams <patrick@stwcx.xyz> >>> Signed-off-by: Cédric Le Goater <clg@redhat.com> >>> --- >>> tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/ functional/arm/test_aspeed_gb200nvl_bmc.py >>> index 8e8e3f05c1b2..e5f2dce0f569 100755 >>> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py >>> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py >>> @@ -11,7 +11,7 @@ >>> class GB200Machine(AspeedTest): >>> ASSET_GB200_FLASH = Asset( >>> - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl- obmc-20250702182348.static.mtd.xz', >>> + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image- gb200nvl-obmc-20250702182348.static.mtd.xz', >>> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') >>> def test_arm_aspeed_gb200_openbmc(self): >> >> Applied to aspeed-next. > > Thanks, this is part of the 2 build failures blocking current pull > requests (other one being > https://lore.kernel.org/qemu-devel/20251224085714.83169-1-philmd@linaro.org/). Thanks, I was going to send an aspeed PR yesterday and then, I saw the tests failing because of the missing v5.0.0 machines. C. > If we really want to consider our CI as source of truth (and blocking > when not green), then please consider applying it directly on master > as a build fix (maintainers Cc'ed). ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image 2025-12-24 11:27 ` Cédric Le Goater @ 2025-12-30 20:59 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2025-12-30 20:59 UTC (permalink / raw) To: Cédric Le Goater, qemu-devel, Richard Henderson, Stefan Hajnoczi, Peter Maydell Cc: Thomas Huth, Ed Tanous, Patrick Williams, Daniel P. Berrangé, Markus Armbruster Hi, On 24/12/25 12:27, Cédric Le Goater wrote: > On 12/24/25 11:51, Philippe Mathieu-Daudé wrote: >> On 22/12/25 13:52, Cédric Le Goater wrote: >>> On 12/22/25 08:33, Cédric Le Goater wrote: >>>> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke >>>> the associated functional test. Fix that. >>>> >>>> [1] https://github.com/legoater/qemu-aspeed-boot/ >>>> commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a >>>> >>>> Cc: Ed Tanous <etanous@nvidia.com> >>>> Cc: Patrick Williams <patrick@stwcx.xyz> >>>> Signed-off-by: Cédric Le Goater <clg@redhat.com> >>>> --- >>>> tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/ >>>> tests/ functional/arm/test_aspeed_gb200nvl_bmc.py >>>> index 8e8e3f05c1b2..e5f2dce0f569 100755 >>>> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py >>>> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py >>>> @@ -11,7 +11,7 @@ >>>> class GB200Machine(AspeedTest): >>>> ASSET_GB200_FLASH = Asset( >>>> - 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/ >>>> heads/ master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl- >>>> obmc-20250702182348.static.mtd.xz', >>>> + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/ >>>> heads/ master/images/gb200nvl-bmc/openbmc-20250702182348/obmc- >>>> phosphor-image- gb200nvl-obmc-20250702182348.static.mtd.xz', >>>> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc') >>>> def test_arm_aspeed_gb200_openbmc(self): >>> >>> Applied to aspeed-next. >> >> Thanks, this is part of the 2 build failures blocking current pull >> requests (other one being >> https://lore.kernel.org/qemu-devel/20251224085714.83169-1- >> philmd@linaro.org/). > > Thanks, I was going to send an aspeed PR yesterday and then, I saw > the tests failing because of the missing v5.0.0 machines. > > C. > >> If we really want to consider our CI as source of truth (and blocking >> when not green), then please consider applying it directly on master >> as a build fix (maintainers Cc'ed). One week passed, some PR got merged, I'm surprised the mainstream CI isn't blocked by this issue... Ah, the cache is being hit: https://gitlab.com/qemu-project/qemu/-/jobs/12556022118 2025-12-29 01:26:43,960 - qemu-test - DEBUG - Using cached asset /builds/qemu-project/qemu/functional-cache/download/b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc for https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz => Non reproducible builds. Acceptable? OK I'm not going to hold my pull request any further and just post it ignoring the build issue. Regards, Phil. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-12-30 21:00 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-12-22 7:33 [PATCH] tests/functional: Fix URL of gb200nvl-bmc image Cédric Le Goater 2025-12-22 9:31 ` Philippe Mathieu-Daudé 2025-12-22 12:52 ` Cédric Le Goater 2025-12-23 22:11 ` Patrick Williams 2025-12-24 11:25 ` Cédric Le Goater 2025-12-24 10:51 ` Philippe Mathieu-Daudé 2025-12-24 11:27 ` Cédric Le Goater 2025-12-30 20:59 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.