[meta-virtualization][PATCH] crun: fix CRUN_AS_RUNC checking

[meta-virtualization][PATCH] crun: fix CRUN_AS_RUNC checking

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

We have in this recipe:
CRUN_AS_RUNC ?= "true"

The expected behavior is that if we set it to "false", the symlink
is not created.

Fix the check to achieve this expected behavior.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 recipes-containers/crun/crun_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-containers/crun/crun_git.bb b/recipes-containers/crun/crun_git.bb
index edaf15b8..25e76239 100644
--- a/recipes-containers/crun/crun_git.bb
+++ b/recipes-containers/crun/crun_git.bb
@@ -52,7 +52,7 @@ do_configure:prepend () {
 
 do_install() {
     oe_runmake 'DESTDIR=${D}' install
-    if [ -n "${CRUN_AS_RUNC}" ]; then
+    if ${CRUN_AS_RUNC}; then
         ln -sr "${D}/${bindir}/crun" "${D}${bindir}/runc"
     fi
 }
-- 
2.43.0

Re: [meta-virtualization][PATCH] crun: fix CRUN_AS_RUNC checking

[Bruce Ashfield]

In message: [meta-virtualization][PATCH] crun: fix CRUN_AS_RUNC checking
on 15/12/2025 Chen Qi via lists.yoctoproject.org wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
> 
> We have in this recipe:
> CRUN_AS_RUNC ?= "true"
> 
> The expected behavior is that if we set it to "false", the symlink
> is not created.

The expected behaviour is that if it was set to
anything the symlink would be created, if it was
not set, or cleared nothing is created.

That is a pattern you'll see in many of my
scripts and classes.

Maybe a comment in the code to indicate that
is the case ?

i.e. # clear this variable to disable symlink creation

Cheers,

Bruce

> 
> Fix the check to achieve this expected behavior.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  recipes-containers/crun/crun_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-containers/crun/crun_git.bb b/recipes-containers/crun/crun_git.bb
> index edaf15b8..25e76239 100644
> --- a/recipes-containers/crun/crun_git.bb
> +++ b/recipes-containers/crun/crun_git.bb
> @@ -52,7 +52,7 @@ do_configure:prepend () {
>  
>  do_install() {
>      oe_runmake 'DESTDIR=${D}' install
> -    if [ -n "${CRUN_AS_RUNC}" ]; then
> +    if ${CRUN_AS_RUNC}; then
>          ln -sr "${D}/${bindir}/crun" "${D}${bindir}/runc"
>      fi
>  }
> -- 
> 2.43.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9480): https://lists.yoctoproject.org/g/meta-virtualization/message/9480
> Mute This Topic: https://lists.yoctoproject.org/mt/116789087/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>