[PATCH v2] lxc: delete empty lxc state directory

[PATCH v2] lxc: delete empty lxc state directory

[Vishwas Udupa]

lxc systemd service [1] defines a StateDirectory to ensure that
the /var/lib/lxc directory is automatically created and managed
by systemd during service startup.
Do not create lxc directory at build time for systemd.

[1] https://github.com/lxc/lxc/blob/f9ff9ea2a92653a823edf25e8e28c9dab08b3090/config/init/systemd/lxc.service.in#L16

Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
---
 recipes-containers/lxc/lxc_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
index d6f137d3..542134db 100644
--- a/recipes-containers/lxc/lxc_git.bb
+++ b/recipes-containers/lxc/lxc_git.bb
@@ -141,7 +141,7 @@ do_install:append() {
 
 	if "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}"; then
 	    # nothing special for systemd at the moment
-	    true
+	    (cd ${D}${localstatedir}; [ -d lib/lxc ] && rmdir -v --parents lib/lxc)
 	else
 	    # with meson, these aren't built unless sysvinit is the enabled
 	    # init system.
-- 
2.25.1

Re: [PATCH v2] lxc: delete empty lxc state directory

[Vishwas Udupa]

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

Is there any feedback on this patch?
Could you please merge this.

regards,
Vishwas

________________________________
From: Vishwas Udupa <vudupa@qti.qualcomm.com>
Sent: Thursday, December 04, 2025 12:13 PM
To: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org>
Cc: anuj.mittal@oss.qualcomm.com <anuj.mittal@oss.qualcomm.com>; Vishwas Udupa <vudupa@qti.qualcomm.com>
Subject: [PATCH v2] lxc: delete empty lxc state directory

lxc systemd service [1] defines a StateDirectory to ensure that
the /var/lib/lxc directory is automatically created and managed
by systemd during service startup.
Do not create lxc directory at build time for systemd.

[1] https://github.com/lxc/lxc/blob/f9ff9ea2a92653a823edf25e8e28c9dab08b3090/config/init/systemd/lxc.service.in#L16

Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
---
 recipes-containers/lxc/lxc_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
index d6f137d3..542134db 100644
--- a/recipes-containers/lxc/lxc_git.bb
+++ b/recipes-containers/lxc/lxc_git.bb
@@ -141,7 +141,7 @@ do_install:append() {

         if "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}"; then
             # nothing special for systemd at the moment
-           true
+           (cd ${D}${localstatedir}; [ -d lib/lxc ] && rmdir -v --parents lib/lxc)
         else
             # with meson, these aren't built unless sysvinit is the enabled
             # init system.
--
2.25.1


[-- Attachment #2: Type: text/html, Size: 3929 bytes --]

Re: [meta-virtualization] [PATCH v2] lxc: delete empty lxc state directory

[Bruce Ashfield]

On Mon, Dec 22, 2025 at 1:18 AM Vishwas Udupa via
lists.yoctoproject.org
<vudupa=qti.qualcomm.com@lists.yoctoproject.org> wrote:
>
> Is there any feedback on this patch?

Not yet, or you would have gotten an email ;)

> Could you please merge this.

This part of the message is not needed, it comes across not as
a question, but a demand.

I'm working on some final release items (and had to get the 6.18
kernel into OEcore). I expect to have them done in the next few
days.

After that work is done, I'll return to the queue and finish
pending reviews and merges

Cheers,

Bruce

>
> regards,
> Vishwas
>
> ________________________________
> From: Vishwas Udupa <vudupa@qti.qualcomm.com>
> Sent: Thursday, December 04, 2025 12:13 PM
> To: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org>
> Cc: anuj.mittal@oss.qualcomm.com <anuj.mittal@oss.qualcomm.com>; Vishwas Udupa <vudupa@qti.qualcomm.com>
> Subject: [PATCH v2] lxc: delete empty lxc state directory
>
> lxc systemd service [1] defines a StateDirectory to ensure that
> the /var/lib/lxc directory is automatically created and managed
> by systemd during service startup.
> Do not create lxc directory at build time for systemd.
>
> [1] https://github.com/lxc/lxc/blob/f9ff9ea2a92653a823edf25e8e28c9dab08b3090/config/init/systemd/lxc.service.in#L16
>
> Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
> ---
>  recipes-containers/lxc/lxc_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
> index d6f137d3..542134db 100644
> --- a/recipes-containers/lxc/lxc_git.bb
> +++ b/recipes-containers/lxc/lxc_git.bb
> @@ -141,7 +141,7 @@ do_install:append() {
>
>          if "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}"; then
>              # nothing special for systemd at the moment
> -           true
> +           (cd ${D}${localstatedir}; [ -d lib/lxc ] && rmdir -v --parents lib/lxc)
>          else
>              # with meson, these aren't built unless sysvinit is the enabled
>              # init system.
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9496): https://lists.yoctoproject.org/g/meta-virtualization/message/9496
> Mute This Topic: https://lists.yoctoproject.org/mt/116608759/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [meta-virtualization] [PATCH v2] lxc: delete empty lxc state directory

[Bruce Ashfield]

merged.

Bruce

In message: [meta-virtualization] [PATCH v2] lxc: delete empty lxc state directory
on 04/12/2025 Vishwas Udupa via lists.yoctoproject.org wrote:

> lxc systemd service [1] defines a StateDirectory to ensure that
> the /var/lib/lxc directory is automatically created and managed
> by systemd during service startup.
> Do not create lxc directory at build time for systemd.
> 
> [1] https://github.com/lxc/lxc/blob/f9ff9ea2a92653a823edf25e8e28c9dab08b3090/config/init/systemd/lxc.service.in#L16
> 
> Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
> ---
>  recipes-containers/lxc/lxc_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
> index d6f137d3..542134db 100644
> --- a/recipes-containers/lxc/lxc_git.bb
> +++ b/recipes-containers/lxc/lxc_git.bb
> @@ -141,7 +141,7 @@ do_install:append() {
>  
>  	if "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}"; then
>  	    # nothing special for systemd at the moment
> -	    true
> +	    (cd ${D}${localstatedir}; [ -d lib/lxc ] && rmdir -v --parents lib/lxc)
>  	else
>  	    # with meson, these aren't built unless sysvinit is the enabled
>  	    # init system.
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9477): https://lists.yoctoproject.org/g/meta-virtualization/message/9477
> Mute This Topic: https://lists.yoctoproject.org/mt/116608759/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>