* [PATCH] perf Documentation: Correct branch stack sampling call-stack option
@ 2025-12-16 1:39 Dapeng Mi
2026-01-07 0:58 ` Mi, Dapeng
0 siblings, 1 reply; 5+ messages in thread
From: Dapeng Mi @ 2025-12-16 1:39 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Ian Rogers, Adrian Hunter, Alexander Shishkin
Cc: linux-perf-users, linux-kernel, Zide Chen, Falcon Thomas,
Dapeng Mi, Xudong Hao, Dapeng Mi, stable
The correct call-stack option for branch stack sampling should be "stack"
instead of "call_stack". Correct it.
$perf record -e instructions -j call_stack -- sleep 1
unknown branch filter call_stack, check man page
Usage: perf record [<options>] [<command>]
or: perf record [<options>] -- <command> [<options>]
-j, --branch-filter <branch filter mask>
branch stack filter modes
Cc: stable@vger.kernel.org
Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
---
tools/perf/Documentation/perf-record.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index e8b9aadbbfa5..3d19e77c9c53 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -454,7 +454,7 @@ following filters are defined:
- no_tx: only when the target is not in a hardware transaction
- abort_tx: only when the target is a hardware transaction abort
- cond: conditional branches
- - call_stack: save call stack
+ - stack: save call stack
- no_flags: don't save branch flags e.g prediction, misprediction etc
- no_cycles: don't save branch cycles
- hw_index: save branch hardware index
base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
2025-12-16 1:39 [PATCH] perf Documentation: Correct branch stack sampling call-stack option Dapeng Mi
@ 2026-01-07 0:58 ` Mi, Dapeng
2026-01-08 6:14 ` Namhyung Kim
0 siblings, 1 reply; 5+ messages in thread
From: Mi, Dapeng @ 2026-01-07 0:58 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Ian Rogers, Adrian Hunter, Alexander Shishkin
Cc: linux-perf-users, linux-kernel, Zide Chen, Falcon Thomas,
Dapeng Mi, Xudong Hao, stable
@Arnaldo, @Kim, @Ian
Kindly ping ...
On 12/16/2025 9:39 AM, Dapeng Mi wrote:
> The correct call-stack option for branch stack sampling should be "stack"
> instead of "call_stack". Correct it.
>
> $perf record -e instructions -j call_stack -- sleep 1
> unknown branch filter call_stack, check man page
>
> Usage: perf record [<options>] [<command>]
> or: perf record [<options>] -- <command> [<options>]
>
> -j, --branch-filter <branch filter mask>
> branch stack filter modes
>
> Cc: stable@vger.kernel.org
> Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> ---
> tools/perf/Documentation/perf-record.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index e8b9aadbbfa5..3d19e77c9c53 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -454,7 +454,7 @@ following filters are defined:
> - no_tx: only when the target is not in a hardware transaction
> - abort_tx: only when the target is a hardware transaction abort
> - cond: conditional branches
> - - call_stack: save call stack
> + - stack: save call stack
> - no_flags: don't save branch flags e.g prediction, misprediction etc
> - no_cycles: don't save branch cycles
> - hw_index: save branch hardware index
>
> base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
2026-01-07 0:58 ` Mi, Dapeng
@ 2026-01-08 6:14 ` Namhyung Kim
2026-01-08 7:43 ` Mi, Dapeng
2026-01-13 20:30 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 5+ messages in thread
From: Namhyung Kim @ 2026-01-08 6:14 UTC (permalink / raw)
To: Mi, Dapeng
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Ian Rogers,
Adrian Hunter, Alexander Shishkin, linux-perf-users, linux-kernel,
Zide Chen, Falcon Thomas, Dapeng Mi, Xudong Hao, stable
Hello,
On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
> @Arnaldo, @Kim, @Ian
>
> Kindly ping ...
Sorry for the delay.
>
> On 12/16/2025 9:39 AM, Dapeng Mi wrote:
> > The correct call-stack option for branch stack sampling should be "stack"
> > instead of "call_stack". Correct it.
> >
> > $perf record -e instructions -j call_stack -- sleep 1
> > unknown branch filter call_stack, check man page
> >
> > Usage: perf record [<options>] [<command>]
> > or: perf record [<options>] -- <command> [<options>]
> >
> > -j, --branch-filter <branch filter mask>
> > branch stack filter modes
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> > ---
> > tools/perf/Documentation/perf-record.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> > index e8b9aadbbfa5..3d19e77c9c53 100644
> > --- a/tools/perf/Documentation/perf-record.txt
> > +++ b/tools/perf/Documentation/perf-record.txt
> > @@ -454,7 +454,7 @@ following filters are defined:
> > - no_tx: only when the target is not in a hardware transaction
> > - abort_tx: only when the target is a hardware transaction abort
> > - cond: conditional branches
> > - - call_stack: save call stack
> > + - stack: save call stack
> > - no_flags: don't save branch flags e.g prediction, misprediction etc
> > - no_cycles: don't save branch cycles
> > - hw_index: save branch hardware index
> >
> > base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
2026-01-08 6:14 ` Namhyung Kim
@ 2026-01-08 7:43 ` Mi, Dapeng
2026-01-13 20:30 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 5+ messages in thread
From: Mi, Dapeng @ 2026-01-08 7:43 UTC (permalink / raw)
To: Namhyung Kim
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Ian Rogers,
Adrian Hunter, Alexander Shishkin, linux-perf-users, linux-kernel,
Zide Chen, Falcon Thomas, Dapeng Mi, Xudong Hao, stable
On 1/8/2026 2:14 PM, Namhyung Kim wrote:
> Hello,
>
> On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
>> @Arnaldo, @Kim, @Ian
>>
>> Kindly ping ...
> Sorry for the delay.
>
>> On 12/16/2025 9:39 AM, Dapeng Mi wrote:
>>> The correct call-stack option for branch stack sampling should be "stack"
>>> instead of "call_stack". Correct it.
>>>
>>> $perf record -e instructions -j call_stack -- sleep 1
>>> unknown branch filter call_stack, check man page
>>>
>>> Usage: perf record [<options>] [<command>]
>>> or: perf record [<options>] -- <command> [<options>]
>>>
>>> -j, --branch-filter <branch filter mask>
>>> branch stack filter modes
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
>>> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks a lot. :)
>
> Thanks,
> Namhyung
>
>>> ---
>>> tools/perf/Documentation/perf-record.txt | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
>>> index e8b9aadbbfa5..3d19e77c9c53 100644
>>> --- a/tools/perf/Documentation/perf-record.txt
>>> +++ b/tools/perf/Documentation/perf-record.txt
>>> @@ -454,7 +454,7 @@ following filters are defined:
>>> - no_tx: only when the target is not in a hardware transaction
>>> - abort_tx: only when the target is a hardware transaction abort
>>> - cond: conditional branches
>>> - - call_stack: save call stack
>>> + - stack: save call stack
>>> - no_flags: don't save branch flags e.g prediction, misprediction etc
>>> - no_cycles: don't save branch cycles
>>> - hw_index: save branch hardware index
>>>
>>> base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option
2026-01-08 6:14 ` Namhyung Kim
2026-01-08 7:43 ` Mi, Dapeng
@ 2026-01-13 20:30 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-01-13 20:30 UTC (permalink / raw)
To: Namhyung Kim
Cc: Mi, Dapeng, Peter Zijlstra, Ingo Molnar, Ian Rogers,
Adrian Hunter, Alexander Shishkin, linux-perf-users, linux-kernel,
Zide Chen, Falcon Thomas, Dapeng Mi, Xudong Hao, stable
On Wed, Jan 07, 2026 at 10:14:46PM -0800, Namhyung Kim wrote:
> Hello,
>
> On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
> > @Arnaldo, @Kim, @Ian
> >
> > Kindly ping ...
>
> Sorry for the delay.
Ditto
> > > Cc: stable@vger.kernel.org
> > > Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> > > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next,
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-13 20:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-16 1:39 [PATCH] perf Documentation: Correct branch stack sampling call-stack option Dapeng Mi
2026-01-07 0:58 ` Mi, Dapeng
2026-01-08 6:14 ` Namhyung Kim
2026-01-08 7:43 ` Mi, Dapeng
2026-01-13 20:30 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.