* [PATCH] media: staging: atomisp: remove redundant OOM error messages
@ 2025-12-15 5:53 Zixuan Dong
2025-12-28 19:23 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Zixuan Dong @ 2025-12-15 5:53 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Andy Shevchenko, Sakari Ailus, linux-media, linux-staging,
linux-kernel, Zixuan Dong
The memory allocation functions (kvzalloc) already emit a stack dump
on failure when GFP_KERNEL is used. Printing an extra error message
is redundant and increases code size.
This resolves the checkpatch warnings:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 3a4eb4f6d3be..a3cd9d3e9ce7 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -2961,11 +2961,8 @@ int atomisp_set_parameters(struct video_device *vdev,
* per-frame setting only works for the main output frame.
*/
param = kvzalloc(sizeof(*param), GFP_KERNEL);
- if (!param) {
- dev_err(asd->isp->dev, "%s: failed to alloc params buffer\n",
- __func__);
+ if (!param)
return -ENOMEM;
- }
css_param = ¶m->params;
}
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: staging: atomisp: remove redundant OOM error messages
2025-12-15 5:53 [PATCH] media: staging: atomisp: remove redundant OOM error messages Zixuan Dong
@ 2025-12-28 19:23 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-12-28 19:23 UTC (permalink / raw)
To: Zixuan Dong
Cc: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Andy Shevchenko, Sakari Ailus, linux-media, linux-staging,
linux-kernel
On Mon, Dec 15, 2025 at 01:53:32PM +0800, Zixuan Dong wrote:
> The memory allocation functions (kvzalloc) already emit a stack dump
> on failure when GFP_KERNEL is used. Printing an extra error message
> is redundant and increases code size.
>
> This resolves the checkpatch warnings:
> WARNING: Possible unnecessary 'out of memory' message
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Sakari, can you pick this up?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-28 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-15 5:53 [PATCH] media: staging: atomisp: remove redundant OOM error messages Zixuan Dong
2025-12-28 19:23 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.