From: Gregory Price <gourry@gourry.net>
To: "Huang, FangSheng (Jerry)" <FangSheng.Huang@amd.com>
Cc: qemu-devel@nongnu.org, david@redhat.com, imammedo@redhat.com,
jonathan.cameron@huawei.com, Zhigang.Luo@amd.com,
Lianjie.Shi@amd.com
Subject: Re: [PATCH v4 0/1] numa: add 'spm' option for Specific Purpose Memory
Date: Tue, 30 Dec 2025 09:06:07 -0500 [thread overview]
Message-ID: <aVPcT_APo6SgRrGU@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <8123efd8-73cc-4dfa-9f1e-6d9a95f66984@amd.com>
On Tue, Dec 30, 2025 at 10:55:02AM +0800, Huang, FangSheng (Jerry) wrote:
> Hi Gregory,
>
> > Sorry i've missed prior versions, is numa the right place to put this,
> > considering that the node is not necessarily 100% SPM on a real system?
> >
>
> The decision to add `spm=` to NUMA rather than the memory backend was based
> on
> earlier feedback from David during our initial RFC discussions.
>
> David raised a concern that if we put the spm flag on the memory backend, a
> user
> could accidentally pass such a memory backend to DIMM/virtio-mem/boot
> memory,
> which would have very undesired side effects.
>
This makes sense, and in fact I almost wonder if we should actually
encode a warning in linux in general if a signal NUMA node contains
both normal and SPM. That would help drive consistency between QEMU/KVM
and real platforms from the direction of linux.
> > (in practice it should be, but not technically required to be)
>
> You're right that on a real system, a NUMA node is not technically required
> to
> be 100% SPM. However, in AMD's use case, the entire NUMA node memory (backed
> by
> memdev) is intended to be SPM, and this approach provides a cleaner and
> safer
> configuration interface.
>
I figured this was the case, and honestly this just provides more
evidence that any given NUMA node probably should only have 1 "type" of
memory (or otherwise stated: uniform access within a node, non-uniform
across nodes).
---
bit of an aside - but at LPC we also talked about SPM NUMA nodes:
https://lore.kernel.org/linux-mm/20251112192936.2574429-1-gourry@gourry.net/
Would be cool to be able to detect this in the drivers and have hotplug
automatically mark a node SPM unless a driver overrides it.
(MHP flag? Sorry David :P)
> >
> > ~Gregory
>
> Please let me know if you have further concerns or suggestions.
>
I'll look at the patch details a bit more, but generally I like the
direction - with an obvious note that I have a biased given the above.
~Gregory
next prev parent reply other threads:[~2025-12-30 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 9:38 [PATCH v4 0/1] numa: add 'spm' option for Specific Purpose Memory fanhuang
2025-12-09 9:38 ` [PATCH v4 1/1] " fanhuang
2025-12-23 9:56 ` Jonathan Cameron via
2025-12-23 10:01 ` David Hildenbrand (Red Hat)
2025-12-26 7:15 ` Huang, FangSheng (Jerry)
2025-12-26 22:46 ` Alistair Popple
2025-12-30 20:09 ` David Hildenbrand (Red Hat)
2026-01-04 10:43 ` Huang, FangSheng (Jerry)
2025-12-29 18:26 ` [PATCH v4 0/1] " Gregory Price
2025-12-30 2:55 ` Huang, FangSheng (Jerry)
2025-12-30 14:06 ` Gregory Price [this message]
2025-12-30 20:15 ` David Hildenbrand (Red Hat)
2025-12-30 23:03 ` Gregory Price
2026-01-02 13:09 ` Igor Mammedov
2026-01-02 16:28 ` Gregory Price
2026-01-02 16:30 ` Gregory Price
2026-01-05 15:29 ` David Hildenbrand (Red Hat)
2026-01-07 9:03 ` Huang, FangSheng (Jerry)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVPcT_APo6SgRrGU@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=FangSheng.Huang@amd.com \
--cc=Lianjie.Shi@amd.com \
--cc=Zhigang.Luo@amd.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.