From: Gregory Price <gourry@gourry.net>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: "Huang, FangSheng (Jerry)" <FangSheng.Huang@amd.com>,
qemu-devel@nongnu.org, imammedo@redhat.com,
jonathan.cameron@huawei.com, Zhigang.Luo@amd.com,
Lianjie.Shi@amd.com
Subject: Re: [PATCH v4 0/1] numa: add 'spm' option for Specific Purpose Memory
Date: Tue, 30 Dec 2025 18:03:11 -0500 [thread overview]
Message-ID: <aVRaL3KjYwXksxRs@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <55ed0c12-222f-4474-a21f-ac0703d2b77c@kernel.org>
On Tue, Dec 30, 2025 at 09:15:34PM +0100, David Hildenbrand (Red Hat) wrote:
> On 12/30/25 15:06, Gregory Price wrote:
>
> And given we don't have a boot memory device, the idea was to set it for the
> Node, where it means "all boot memory is SPM". And we only allow one type of
> boot memory (one memory backend) per node in QEMU.
>
> The tricky question is what happens with memory hotplug (DIMMs etc) on such
> a node. I'd argue that it's simply not SPM.
>
...
+++ .../docs/whatever
+ Don't do that.
:]
> >
> > ---
> >
> > bit of an aside - but at LPC we also talked about SPM NUMA nodes:
> > https://lore.kernel.org/linux-mm/20251112192936.2574429-1-gourry@gourry.net/
> >
> > Would be cool to be able to detect this in the drivers and have hotplug
> > automatically mark a node SPM unless a driver overrides it.
> > (MHP flag? Sorry David :P)
>
> :)
>
> If it's a per-node thing, MHP flags feel a bit like "too late". It should be
> configured earlier for the node somehow.
>
just a clarification, the flag would be an override to have mhp mark a
node N_MEMORY instead of N_SPM.
As it stands right now, a node is "online with memory" if N_MEMORY is
set for that node.
https://elixir.bootlin.com/linux/v6.14-rc6/source/mm/memory_hotplug.c#L717
I imagine hotplugged N_SPM would operate the same.
So mhp code would look like
if (node_data->is_spm && !override)
node_set_state(node, N_SPM)
else
node_set_state(node, N_MEMORY)
Basically would allow SPM nodes to operate the same as they did before
when hotplugged to retain existing behavior.
(Sorry i'm think waaaaaaaaaaaaay far ahead here)
~Gregory
next prev parent reply other threads:[~2025-12-30 23:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 9:38 [PATCH v4 0/1] numa: add 'spm' option for Specific Purpose Memory fanhuang
2025-12-09 9:38 ` [PATCH v4 1/1] " fanhuang
2025-12-23 9:56 ` Jonathan Cameron via
2025-12-23 10:01 ` David Hildenbrand (Red Hat)
2025-12-26 7:15 ` Huang, FangSheng (Jerry)
2025-12-26 22:46 ` Alistair Popple
2025-12-30 20:09 ` David Hildenbrand (Red Hat)
2026-01-04 10:43 ` Huang, FangSheng (Jerry)
2025-12-29 18:26 ` [PATCH v4 0/1] " Gregory Price
2025-12-30 2:55 ` Huang, FangSheng (Jerry)
2025-12-30 14:06 ` Gregory Price
2025-12-30 20:15 ` David Hildenbrand (Red Hat)
2025-12-30 23:03 ` Gregory Price [this message]
2026-01-02 13:09 ` Igor Mammedov
2026-01-02 16:28 ` Gregory Price
2026-01-02 16:30 ` Gregory Price
2026-01-05 15:29 ` David Hildenbrand (Red Hat)
2026-01-07 9:03 ` Huang, FangSheng (Jerry)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVRaL3KjYwXksxRs@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=FangSheng.Huang@amd.com \
--cc=Lianjie.Shi@amd.com \
--cc=Zhigang.Luo@amd.com \
--cc=david@kernel.org \
--cc=imammedo@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.