All of lore.kernel.org
 help / color / mirror / Atom feed
From: CL Wang <cl634@andestech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <wim@linux-watchdog.org>, <linux@roeck-us.net>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-watchdog@vger.kernel.org>, <tim609@andestech.com>,
	<ben717@andestech.com>
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: Add support for Andes ATCWDT200
Date: Fri, 9 Jan 2026 17:35:58 +0800	[thread overview]
Message-ID: <aWDL_n16CLyP5DR3@swlinux02> (raw)
In-Reply-To: <ffb1a4ef-b22c-4d59-a494-0ab703ef24d2@kernel.org>

Hi Krzysztof,

Thanks for your review.

On 07/01/2026 15:50, Krzysztof Kozlowski wrote:
> Last part is redundant. Can you add a binding without supported properties and without usage examples?

Agreed. I will remove the redundant part "including supported properties
and usage examples" in the commit message in the next version.

> Subject says WDT200, this code sais 350 and qilai. What is what? You have entire commit msg to explain that

I will clarify in the commit message that ATCWDT200 is the IP name, which
is embedded in AndesCore-based platforms or SoCs such as AE350 and Qilai.

> No clue what's this, but for sure does not pass tests without description and type.

You are right, I missed the type definition. I will add the description
and set the type to uint32 (enum [0, 1]) for `andestech,clock-source`.

Best regards,
CL Wang

  reply	other threads:[~2026-01-09  9:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 14:50 [PATCH 0/3] watchdog: Add support for Andes ATCWDT200 CL Wang
2026-01-07 14:50 ` [PATCH 1/3] dt-bindings: " CL Wang
2026-01-07 15:44   ` Krzysztof Kozlowski
2026-01-09  9:35     ` CL Wang [this message]
2026-01-07 16:23   ` Rob Herring (Arm)
2026-01-12  6:59     ` CL Wang
2026-01-07 14:50 ` [PATCH 2/3] watchdog: atcwdt200: Add driver " CL Wang
2026-01-07 15:46   ` Krzysztof Kozlowski
2026-01-12  7:05     ` CL Wang
2026-01-07 14:50 ` [PATCH 3/3] MAINTAINERS: Add entry " CL Wang
  -- strict thread matches above, loose matches on Subject: below --
2026-01-12 18:04 [PATCH 1/3] dt-bindings: watchdog: Add support " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWDL_n16CLyP5DR3@swlinux02 \
    --to=cl634@andestech.com \
    --cc=ben717@andestech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=tim609@andestech.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.