All of lore.kernel.org
 help / color / mirror / Atom feed
From: CL Wang <cl634@andestech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <wim@linux-watchdog.org>, <linux@roeck-us.net>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-watchdog@vger.kernel.org>, <tim609@andestech.com>,
	<cl634@andestech.com>, <ben717@andestech.com>
Subject: Re: [PATCH 2/3] watchdog: atcwdt200: Add driver for Andes ATCWDT200
Date: Mon, 12 Jan 2026 15:05:26 +0800	[thread overview]
Message-ID: <aWSdNkHc-MAR5CRr@swlinux02> (raw)
In-Reply-To: <f6499c9a-4ec8-4c9e-b9b5-e679e0f913a4@kernel.org>

Hi Krzysztof,

Thanks for your review.

On 07/01/2026 15:50, Krzysztof Kozlowski wrote:

> Just use API for getting enabled clock.
Agreed. I will switch to using `devm_clk_get_enabled()` to simplify
the clock handling and error paths.

> No, read your binding. You said it is a list... list of phandles?
You are right. The property is intended to be a single uint32
configuration value. I will update the binding schema to clearly
define it as such and make it consistent with the driver.

> Just return.
Agreed. I will simplify the resume path and return directly on error.

> Drop, not needed.
Understood. I will drop the `"andestech,qilai-wdt"` compatible and keep
only the generic one.

> From where did you get this?
You're right, this is unnecessary. I will remove `.owner = THIS_MODULE`.

I will address all of the above in the next revision.

Best regards,
CL Wang

  reply	other threads:[~2026-01-12  7:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 14:50 [PATCH 0/3] watchdog: Add support for Andes ATCWDT200 CL Wang
2026-01-07 14:50 ` [PATCH 1/3] dt-bindings: " CL Wang
2026-01-07 15:44   ` Krzysztof Kozlowski
2026-01-09  9:35     ` CL Wang
2026-01-07 16:23   ` Rob Herring (Arm)
2026-01-12  6:59     ` CL Wang
2026-01-07 14:50 ` [PATCH 2/3] watchdog: atcwdt200: Add driver " CL Wang
2026-01-07 15:46   ` Krzysztof Kozlowski
2026-01-12  7:05     ` CL Wang [this message]
2026-01-07 14:50 ` [PATCH 3/3] MAINTAINERS: Add entry " CL Wang
  -- strict thread matches above, loose matches on Subject: below --
2026-01-10 22:19 [PATCH 2/3] watchdog: atcwdt200: Add driver " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWSdNkHc-MAR5CRr@swlinux02 \
    --to=cl634@andestech.com \
    --cc=ben717@andestech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=tim609@andestech.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.