* [PATCH] include/hw/hyperv: Remove unused 'struct mshv_vp_registers' definition
@ 2026-01-08 18:50 Cédric Le Goater
2026-01-12 15:31 ` Magnus Kulke
2026-01-13 7:32 ` Cédric Le Goater
0 siblings, 2 replies; 3+ messages in thread
From: Cédric Le Goater @ 2026-01-08 18:50 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Shameer Kolothum, Cédric Le Goater,
Magnus Kulke
The 'struct mshv_vp_registers' definition in hvgdk_mini.h is unused in
QEMU and conflicts with the canonical definition in
linux-headers/linux/mshv.h.
Remove the duplicate definition to avoid build conflicts when the Linux
headers are updated.
Cc: Magnus Kulke <magnuskulke@linux.microsoft.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/hyperv/hvgdk_mini.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/include/hw/hyperv/hvgdk_mini.h b/include/hw/hyperv/hvgdk_mini.h
index d89315f5452fd565469bbfc98cacb226b71da13f..cb52cc9de283bbe4201357127c2eb1b0b37e4cab 100644
--- a/include/hw/hyperv/hvgdk_mini.h
+++ b/include/hw/hyperv/hvgdk_mini.h
@@ -450,13 +450,6 @@ typedef struct hv_input_set_vp_registers {
struct hv_register_assoc elements[];
} hv_input_set_vp_registers;
-#define MSHV_VP_MAX_REGISTERS 128
-
-struct mshv_vp_registers {
- int count; /* at most MSHV_VP_MAX_REGISTERS */
- struct hv_register_assoc *regs;
-};
-
union hv_interrupt_control {
uint64_t as_uint64;
struct {
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] include/hw/hyperv: Remove unused 'struct mshv_vp_registers' definition
2026-01-08 18:50 [PATCH] include/hw/hyperv: Remove unused 'struct mshv_vp_registers' definition Cédric Le Goater
@ 2026-01-12 15:31 ` Magnus Kulke
2026-01-13 7:32 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Magnus Kulke @ 2026-01-12 15:31 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-devel, Paolo Bonzini, Shameer Kolothum
Reviewed-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
Thanks, looks good to me.
On Thu, Jan 08, 2026 at 07:50:12PM +0100, Cédric Le Goater wrote:
> The 'struct mshv_vp_registers' definition in hvgdk_mini.h is unused in
> QEMU and conflicts with the canonical definition in
> linux-headers/linux/mshv.h.
>
> Remove the duplicate definition to avoid build conflicts when the Linux
> headers are updated.
>
> Cc: Magnus Kulke <magnuskulke@linux.microsoft.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> include/hw/hyperv/hvgdk_mini.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/hw/hyperv/hvgdk_mini.h b/include/hw/hyperv/hvgdk_mini.h
> index d89315f5452fd565469bbfc98cacb226b71da13f..cb52cc9de283bbe4201357127c2eb1b0b37e4cab 100644
> --- a/include/hw/hyperv/hvgdk_mini.h
> +++ b/include/hw/hyperv/hvgdk_mini.h
> @@ -450,13 +450,6 @@ typedef struct hv_input_set_vp_registers {
> struct hv_register_assoc elements[];
> } hv_input_set_vp_registers;
>
> -#define MSHV_VP_MAX_REGISTERS 128
> -
> -struct mshv_vp_registers {
> - int count; /* at most MSHV_VP_MAX_REGISTERS */
> - struct hv_register_assoc *regs;
> -};
> -
> union hv_interrupt_control {
> uint64_t as_uint64;
> struct {
> --
> 2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include/hw/hyperv: Remove unused 'struct mshv_vp_registers' definition
2026-01-08 18:50 [PATCH] include/hw/hyperv: Remove unused 'struct mshv_vp_registers' definition Cédric Le Goater
2026-01-12 15:31 ` Magnus Kulke
@ 2026-01-13 7:32 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2026-01-13 7:32 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Shameer Kolothum, Magnus Kulke
On 1/8/26 19:50, Cédric Le Goater wrote:
> The 'struct mshv_vp_registers' definition in hvgdk_mini.h is unused in
> QEMU and conflicts with the canonical definition in
> linux-headers/linux/mshv.h.
>
> Remove the duplicate definition to avoid build conflicts when the Linux
> headers are updated.
>
> Cc: Magnus Kulke <magnuskulke@linux.microsoft.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> include/hw/hyperv/hvgdk_mini.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/hw/hyperv/hvgdk_mini.h b/include/hw/hyperv/hvgdk_mini.h
> index d89315f5452fd565469bbfc98cacb226b71da13f..cb52cc9de283bbe4201357127c2eb1b0b37e4cab 100644
> --- a/include/hw/hyperv/hvgdk_mini.h
> +++ b/include/hw/hyperv/hvgdk_mini.h
> @@ -450,13 +450,6 @@ typedef struct hv_input_set_vp_registers {
> struct hv_register_assoc elements[];
> } hv_input_set_vp_registers;
>
> -#define MSHV_VP_MAX_REGISTERS 128
> -
> -struct mshv_vp_registers {
> - int count; /* at most MSHV_VP_MAX_REGISTERS */
> - struct hv_register_assoc *regs;
> -};
> -
> union hv_interrupt_control {
> uint64_t as_uint64;
> struct {
Applied to vfio-next.
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-13 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 18:50 [PATCH] include/hw/hyperv: Remove unused 'struct mshv_vp_registers' definition Cédric Le Goater
2026-01-12 15:31 ` Magnus Kulke
2026-01-13 7:32 ` Cédric Le Goater
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.