From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Chao Yu <chao@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, Nanzhe Zhao <nzzhao@126.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add 'folio_in_bio' to handle readahead folios with no BIO submission
Date: Tue, 13 Jan 2026 17:05:35 +0000 [thread overview]
Message-ID: <aWZ7X9yig5TK2yNN@google.com> (raw)
In-Reply-To: <5158ff31-bd7b-4071-b2b1-12cb75c858dd@kernel.org>
On 01/12, Chao Yu wrote:
> On 1/12/2026 4:52 PM, Nanzhe Zhao wrote:
> >
> > At 2026-01-12 09:02:48, "Chao Yu" <chao@kernel.org> wrote:
> > > > @@ -2545,6 +2548,11 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> > > > }
> > > > trace_f2fs_read_folio(folio, DATA);
> > > > if (rac) {
> > > > + if (!folio_in_bio) {
> > > > + if (!ret)
> > >
> > > ret should never be true here?
> > >
> > > Thanks,
> > Yes.Need I send a v3 patch to remove the redundant check?
>
> Yes, I think so.
Applied in dev-test with it.
>
> Thanks,
>
> >
> > Thanks,
> > Nanzhe Zhao
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Nanzhe Zhao <nzzhao@126.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add 'folio_in_bio' to handle readahead folios with no BIO submission
Date: Tue, 13 Jan 2026 17:05:35 +0000 [thread overview]
Message-ID: <aWZ7X9yig5TK2yNN@google.com> (raw)
In-Reply-To: <5158ff31-bd7b-4071-b2b1-12cb75c858dd@kernel.org>
On 01/12, Chao Yu wrote:
> On 1/12/2026 4:52 PM, Nanzhe Zhao wrote:
> >
> > At 2026-01-12 09:02:48, "Chao Yu" <chao@kernel.org> wrote:
> > > > @@ -2545,6 +2548,11 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> > > > }
> > > > trace_f2fs_read_folio(folio, DATA);
> > > > if (rac) {
> > > > + if (!folio_in_bio) {
> > > > + if (!ret)
> > >
> > > ret should never be true here?
> > >
> > > Thanks,
> > Yes.Need I send a v3 patch to remove the redundant check?
>
> Yes, I think so.
Applied in dev-test with it.
>
> Thanks,
>
> >
> > Thanks,
> > Nanzhe Zhao
next prev parent reply other threads:[~2026-01-13 17:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 10:09 [f2fs-dev] [PATCH v2 0/2] f2fs: fix large folio read corner cases for immutable files Nanzhe Zhao
2026-01-11 10:09 ` Nanzhe Zhao
2026-01-11 10:09 ` [f2fs-dev] [PATCH v2 1/2] f2fs: add 'folio_in_bio' to handle readahead folios with no BIO submission Nanzhe Zhao
2026-01-11 10:09 ` Nanzhe Zhao
2026-01-12 1:02 ` Chao Yu via Linux-f2fs-devel
2026-01-12 1:02 ` Chao Yu
2026-01-12 8:52 ` Nanzhe Zhao
2026-01-12 8:52 ` Nanzhe Zhao
2026-01-12 9:24 ` Chao Yu via Linux-f2fs-devel
2026-01-12 9:24 ` Chao Yu
2026-01-13 17:05 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2026-01-13 17:05 ` Jaegeuk Kim
2026-01-16 3:31 ` Nanzhe Zhao
2026-01-16 3:31 ` Nanzhe Zhao
2026-01-16 8:53 ` Chao Yu via Linux-f2fs-devel
2026-01-16 8:53 ` Chao Yu
2026-01-13 18:32 ` Matthew Wilcox
2026-01-13 18:32 ` Matthew Wilcox
2026-01-16 4:33 ` Jaegeuk Kim via Linux-f2fs-devel
2026-01-16 4:33 ` Jaegeuk Kim
2026-01-11 10:09 ` [f2fs-dev] [PATCH v2 2/2] f2fs: advance index and offset after zeroing in large folio read Nanzhe Zhao
2026-01-11 10:09 ` Nanzhe Zhao
2026-01-12 1:03 ` Chao Yu via Linux-f2fs-devel
2026-01-12 1:03 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZ7X9yig5TK2yNN@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nzzhao@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.