From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to unlock folio in f2fs_read_data_large_folio()
Date: Tue, 13 Jan 2026 17:06:28 +0000 [thread overview]
Message-ID: <aWZ7lJ2s7BILOps8@google.com> (raw)
In-Reply-To: <20260112013052.7623-1-chao@kernel.org>
On 01/12, Chao Yu wrote:
> We missed to unlock folio in error path of f2fs_read_data_large_folio(),
> fix it.
>
> With below testcase, it can reproduce the bug.
>
> touch /mnt/f2fs/file
> truncate -s $((1024*1024*1024)) /mnt/f2fs/file
> f2fs_io setflags immutable /mnt/f2fs/file
> sync
> echo 3 > /proc/sys/vm/drop_caches
> time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
> f2fs_io clearflags immutable /mnt/f2fs/file
> echo 1 > /proc/sys/vm/drop_caches
> time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
> time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> Changelog:
> - this patch is based on Nanzhe Zhao's patchset
Please rebase on top of dev-test?
> fs/f2fs/data.c | 28 ++++++++++++----------------
> 1 file changed, 12 insertions(+), 16 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index eeeb70bff101..a2c4769d0ae1 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -2462,11 +2462,11 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> int ret = 0;
> bool folio_in_bio;
>
> - if (!IS_IMMUTABLE(inode))
> - return -EOPNOTSUPP;
> -
> - if (f2fs_compressed_file(inode))
> + if (!IS_IMMUTABLE(inode) || f2fs_compressed_file(inode)) {
> + if (folio)
> + folio_unlock(folio);
> return -EOPNOTSUPP;
> + }
>
> map.m_seg_type = NO_CHECK_TYPE;
>
> @@ -2569,22 +2569,18 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> last_block_in_bio = block_nr;
> }
> trace_f2fs_read_folio(folio, DATA);
> - if (rac) {
> - if (!folio_in_bio) {
> - if (!ret)
> - folio_mark_uptodate(folio);
> - folio_unlock(folio);
> - }
> - folio = readahead_folio(rac);
> - goto next_folio;
> - }
> +
> err_out:
> - /* Nothing was submitted. */
> - if (!bio) {
> + if (!folio_in_bio) {
> if (!ret)
> folio_mark_uptodate(folio);
> folio_unlock(folio);
> - return ret;
> + if (ret)
> + return ret;
> + }
> + if (rac) {
> + folio = readahead_folio(rac);
> + goto next_folio;
> }
> out:
> f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
> --
> 2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to unlock folio in f2fs_read_data_large_folio()
Date: Tue, 13 Jan 2026 17:06:28 +0000 [thread overview]
Message-ID: <aWZ7lJ2s7BILOps8@google.com> (raw)
In-Reply-To: <20260112013052.7623-1-chao@kernel.org>
On 01/12, Chao Yu wrote:
> We missed to unlock folio in error path of f2fs_read_data_large_folio(),
> fix it.
>
> With below testcase, it can reproduce the bug.
>
> touch /mnt/f2fs/file
> truncate -s $((1024*1024*1024)) /mnt/f2fs/file
> f2fs_io setflags immutable /mnt/f2fs/file
> sync
> echo 3 > /proc/sys/vm/drop_caches
> time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
> f2fs_io clearflags immutable /mnt/f2fs/file
> echo 1 > /proc/sys/vm/drop_caches
> time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
> time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> Changelog:
> - this patch is based on Nanzhe Zhao's patchset
Please rebase on top of dev-test?
> fs/f2fs/data.c | 28 ++++++++++++----------------
> 1 file changed, 12 insertions(+), 16 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index eeeb70bff101..a2c4769d0ae1 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -2462,11 +2462,11 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> int ret = 0;
> bool folio_in_bio;
>
> - if (!IS_IMMUTABLE(inode))
> - return -EOPNOTSUPP;
> -
> - if (f2fs_compressed_file(inode))
> + if (!IS_IMMUTABLE(inode) || f2fs_compressed_file(inode)) {
> + if (folio)
> + folio_unlock(folio);
> return -EOPNOTSUPP;
> + }
>
> map.m_seg_type = NO_CHECK_TYPE;
>
> @@ -2569,22 +2569,18 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> last_block_in_bio = block_nr;
> }
> trace_f2fs_read_folio(folio, DATA);
> - if (rac) {
> - if (!folio_in_bio) {
> - if (!ret)
> - folio_mark_uptodate(folio);
> - folio_unlock(folio);
> - }
> - folio = readahead_folio(rac);
> - goto next_folio;
> - }
> +
> err_out:
> - /* Nothing was submitted. */
> - if (!bio) {
> + if (!folio_in_bio) {
> if (!ret)
> folio_mark_uptodate(folio);
> folio_unlock(folio);
> - return ret;
> + if (ret)
> + return ret;
> + }
> + if (rac) {
> + folio = readahead_folio(rac);
> + goto next_folio;
> }
> out:
> f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
> --
> 2.40.1
next prev parent reply other threads:[~2026-01-13 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 1:30 [f2fs-dev] [PATCH] f2fs: fix to unlock folio in f2fs_read_data_large_folio() Chao Yu via Linux-f2fs-devel
2026-01-12 1:30 ` Chao Yu
2026-01-13 17:06 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2026-01-13 17:06 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZ7lJ2s7BILOps8@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.