Re: [PATCH 4/5] drm/rockchip: dw_dp: Add DisplayPort support for rk3576

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, dmitry.baryshkov@oss.qualcomm.com,
	krzk+dt@kernel.org,  conor+dt@kernel.org,
	cristian.ciocaltea@collabora.com,
	 Laurent.pinchart@ideasonboard.com, mripard@kernel.org,
	hjc@rock-chips.com, robh@kernel.org,  tzimmermann@suse.de,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	 Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH 4/5] drm/rockchip: dw_dp: Add DisplayPort support for rk3576
Date: Tue, 13 Jan 2026 22:37:51 +0100	[thread overview]
Message-ID: <aWa7GuLKdUcbjA35@venus> (raw)
In-Reply-To: <20260109080054.228671-5-andyshrk@163.com>

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

Hi,

On Fri, Jan 09, 2026 at 04:00:47PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> The DisplayPort of the RK3576 is basically the same as that of the
> RK3588, but it operates in dual-pixel mode and also support MST.
> 
> This patch only enable the SST output now.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Greetings,

-- Sebastian

>  drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c
> index 89d614d53596..dac3d202971e 100644
> --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c
> @@ -142,10 +142,18 @@ static const struct dw_dp_plat_data rk3588_dp_plat_data = {
>  	.pixel_mode = DW_DP_MP_QUAD_PIXEL,
>  };
>  
> +static const struct dw_dp_plat_data rk3576_dp_plat_data = {
> +	.max_link_rate = 810000,
> +	.pixel_mode = DW_DP_MP_DUAL_PIXEL,
> +};
> +
>  static const struct of_device_id dw_dp_of_match[] = {
>  	{
>  		.compatible = "rockchip,rk3588-dp",
>  		.data = &rk3588_dp_plat_data,
> +	}, {
> +		.compatible = "rockchip,rk3576-dp",
> +		.data = &rk3576_dp_plat_data,
>  	},
>  	{}
>  };
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]