All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Horatiu Vultur" <horatiu.vultur@microchip.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Eric Woudstra" <ericwouds@gmail.com>,
	"Marek Behún" <kabel@kernel.org>, "Lee Jones" <lee@kernel.org>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>
Subject: Re: [PATCH v3 net-next 05/10] phy: add phy_get_rx_polarity() and phy_get_tx_polarity()
Date: Wed, 14 Jan 2026 18:40:44 +0530	[thread overview]
Message-ID: <aWeV1CEaEMvImS-9@vaman> (raw)
In-Reply-To: <20260111141549.xtl5bpjtru6rv6ys@skbuf>

On 11-01-26, 16:15, Vladimir Oltean wrote:
> On Sun, Jan 11, 2026 at 12:53:15PM +0100, Bjørn Mork wrote:
> > Vladimir Oltean <vladimir.oltean@nxp.com> writes:
> > 
> > > Add helpers in the generic PHY folder which can be used using 'select
> > > GENERIC_PHY_COMMON_PROPS' from Kconfig
> > 
> > The code looks good to me now.
> > 
> > But renaming stuff is hard. Leftover old config symbol in the commit
> > description here. Could be fixed up on merge, maybe?
> > 
> > 
> > Bjørn
> 
> This is unfortunate. I'll let Vinot comment on the preferred approach,
> although I also wouldn't prefer resending to fix a minor commit message
> mistake. Thanks for spotting and for the review in general.

Yes fixed that while applying

-- 
~Vinod


WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Horatiu Vultur" <horatiu.vultur@microchip.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Eric Woudstra" <ericwouds@gmail.com>,
	"Marek Behún" <kabel@kernel.org>, "Lee Jones" <lee@kernel.org>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>
Subject: Re: [PATCH v3 net-next 05/10] phy: add phy_get_rx_polarity() and phy_get_tx_polarity()
Date: Wed, 14 Jan 2026 18:40:44 +0530	[thread overview]
Message-ID: <aWeV1CEaEMvImS-9@vaman> (raw)
In-Reply-To: <20260111141549.xtl5bpjtru6rv6ys@skbuf>

On 11-01-26, 16:15, Vladimir Oltean wrote:
> On Sun, Jan 11, 2026 at 12:53:15PM +0100, Bjørn Mork wrote:
> > Vladimir Oltean <vladimir.oltean@nxp.com> writes:
> > 
> > > Add helpers in the generic PHY folder which can be used using 'select
> > > GENERIC_PHY_COMMON_PROPS' from Kconfig
> > 
> > The code looks good to me now.
> > 
> > But renaming stuff is hard. Leftover old config symbol in the commit
> > description here. Could be fixed up on merge, maybe?
> > 
> > 
> > Bjørn
> 
> This is unfortunate. I'll let Vinot comment on the preferred approach,
> although I also wouldn't prefer resending to fix a minor commit message
> mistake. Thanks for spotting and for the review in general.

Yes fixed that while applying

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-01-14 13:11 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11  9:39 [PATCH v3 net-next 00/10] PHY polarity inversion via generic device tree properties Vladimir Oltean
2026-01-11  9:39 ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 01/10] dt-bindings: phy: rename transmit-amplitude.yaml to phy-common-props.yaml Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 02/10] dt-bindings: phy-common-props: create a reusable "protocol-names" definition Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 03/10] dt-bindings: phy-common-props: ensure protocol-names are unique Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 04/10] dt-bindings: phy-common-props: RX and TX lane polarity inversion Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 05/10] phy: add phy_get_rx_polarity() and phy_get_tx_polarity() Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11 11:53   ` Bjørn Mork
2026-01-11 11:53     ` Bjørn Mork
2026-01-11 14:15     ` Vladimir Oltean
2026-01-11 14:15       ` Vladimir Oltean
2026-01-14 13:10       ` Vinod Koul [this message]
2026-01-14 13:10         ` Vinod Koul
2026-01-15  9:34         ` Paolo Abeni
2026-01-15  9:34           ` Paolo Abeni
2026-01-15  9:37           ` Paolo Abeni
2026-01-15  9:37             ` Paolo Abeni
2026-01-15  9:39             ` Vladimir Oltean
2026-01-15  9:39               ` Vladimir Oltean
2026-01-16  3:19               ` Jakub Kicinski
2026-01-16  3:19                 ` Jakub Kicinski
2026-02-26 13:22   ` Geert Uytterhoeven
2026-02-26 13:22     ` Geert Uytterhoeven
2026-02-26 15:10     ` Vladimir Oltean
2026-02-26 15:10       ` Vladimir Oltean
2026-02-26 15:13       ` Geert Uytterhoeven
2026-02-26 15:13         ` Geert Uytterhoeven
2026-02-26 15:21         ` Vladimir Oltean
2026-02-26 15:21           ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 06/10] dt-bindings: net: airoha,en8811h: deprecate "airoha,pnswap-rx" and "airoha,pnswap-tx" Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 07/10] net: phy: air_en8811h: " Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 08/10] dt-bindings: net: pcs: mediatek,sgmiisys: deprecate "mediatek,pnswap" Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 09/10] net: pcs: pcs-mtk-lynxi: pass SGMIISYS OF node to PCS Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-11  9:39 ` [PATCH v3 net-next 10/10] net: pcs: pcs-mtk-lynxi: deprecate "mediatek,pnswap" Vladimir Oltean
2026-01-11  9:39   ` Vladimir Oltean
2026-01-14 13:18 ` [PATCH v3 net-next 00/10] PHY polarity inversion via generic device tree properties Vinod Koul
2026-01-14 13:18   ` Vinod Koul
2026-01-16  3:16   ` Jakub Kicinski
2026-01-16  3:16     ` Jakub Kicinski
2026-01-14 14:01 ` (subset) " Vinod Koul
2026-01-14 14:01   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWeV1CEaEMvImS-9@vaman \
    --to=vkoul@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bjorn@mork.no \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=ericwouds@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kabel@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=matthias.bgg@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=robh@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.