Re: Typo in pinctrl-th1520.c

From: Drew Fustini <fustini@kernel.org>
To: Thomas Gerner <thomas.gerner@muenchen-mail.de>
Cc: Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Linus Walleij <linusw@kernel.org>,
	linux-riscv@lists.infradead.org
Subject: Re: Typo in pinctrl-th1520.c
Date: Thu, 15 Jan 2026 11:03:16 -0800	[thread overview]
Message-ID: <aWk59MT8yWcxiYKr@x1> (raw)
In-Reply-To: <029e5e79-ae9c-4d31-b75f-8f48f359d539@muenchen-mail.de>

On Wed, Jan 14, 2026 at 04:20:17PM +0100, Thomas Gerner wrote:
> Hello,
> 
> in the pincontrol file for the TH1520 SOC a pad is named wrong. According to
> TH1520 System User Manual, chapter 3.2.1 (page 38) pad 8 in pad group 3 is
> named QSPI0_D3_HOLD. With the wrong name QSPI1_D3_HOLD one cannot select the
> right pad in a device tree because the name is not unique. QSPI1_D3_HOLD is
> defined in pad group 2. This patch fixes the the pad name.
> 
> diff --git a/drivers/pinctrl/pinctrl-th1520.c
> b/drivers/pinctrl/pinctrl-th1520.c
> index e641bad6728c..83e9c9f77370 100644
> --- a/drivers/pinctrl/pinctrl-th1520.c
> +++ b/drivers/pinctrl/pinctrl-th1520.c
> @@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc
> th1520_group3_pins[] = {
>         TH1520_PAD(5,  QSPI0_D0_MOSI, QSPI, PWM,  I2S,  GPIO, ____, ____,
> 0),
>         TH1520_PAD(6,  QSPI0_D1_MISO, QSPI, PWM,  I2S,  GPIO, ____, ____,
> 0),
>         TH1520_PAD(7,  QSPI0_D2_WP,   QSPI, PWM,  I2S,  GPIO, ____, ____,
> 0),
> -       TH1520_PAD(8,  QSPI1_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____,
> 0),
> +       TH1520_PAD(8,  QSPI0_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____,
> 0),
>         TH1520_PAD(9,  I2C2_SCL,      I2C,  UART, ____, GPIO, ____, ____,
> 0),
>         TH1520_PAD(10, I2C2_SDA,      I2C,  UART, ____, GPIO, ____, ____,
> 0),
>         TH1520_PAD(11, I2C3_SCL,      I2C,  ____, ____, GPIO, ____, ____,
> 0),
> ---
> 
> Best regards
> Thomas

Hello, thank you catching this and providing a fix. The change looks
correct me, but I believe there is something wrong with the patch.

Did you just paste a diff into an email?

I would suggest using git send-email. KernelNewbies [1] has some good
tips as well as Nick's guide [2].

Thanks,
Drew

[1] https://kernelnewbies.org/FirstKernelPatch
[2] https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv