All of lore.kernel.org
 help / color / mirror / Atom feed
* Typo in pinctrl-th1520.c
@ 2026-01-14 15:20 Thomas Gerner
  2026-01-15 19:03 ` Drew Fustini
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gerner @ 2026-01-14 15:20 UTC (permalink / raw)
  To: Drew Fustini, Guo Ren, Fu Wei, Linus Walleij, linux-riscv

Hello,

in the pincontrol file for the TH1520 SOC a pad is named wrong. 
According to TH1520 System User Manual, chapter 3.2.1 (page 38) pad 8 in 
pad group 3 is named QSPI0_D3_HOLD. With the wrong name QSPI1_D3_HOLD 
one cannot select the right pad in a device tree because the name is not 
unique. QSPI1_D3_HOLD is defined in pad group 2. This patch fixes the 
the pad name.

diff --git a/drivers/pinctrl/pinctrl-th1520.c 
b/drivers/pinctrl/pinctrl-th1520.c
index e641bad6728c..83e9c9f77370 100644
--- a/drivers/pinctrl/pinctrl-th1520.c
+++ b/drivers/pinctrl/pinctrl-th1520.c
@@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc 
th1520_group3_pins[] = {
         TH1520_PAD(5,  QSPI0_D0_MOSI, QSPI, PWM,  I2S,  GPIO, ____, 
____, 0),
         TH1520_PAD(6,  QSPI0_D1_MISO, QSPI, PWM,  I2S,  GPIO, ____, 
____, 0),
         TH1520_PAD(7,  QSPI0_D2_WP,   QSPI, PWM,  I2S,  GPIO, ____, 
____, 0),
-       TH1520_PAD(8,  QSPI1_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, 
____, 0),
+       TH1520_PAD(8,  QSPI0_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, 
____, 0),
         TH1520_PAD(9,  I2C2_SCL,      I2C,  UART, ____, GPIO, ____, 
____, 0),
         TH1520_PAD(10, I2C2_SDA,      I2C,  UART, ____, GPIO, ____, 
____, 0),
         TH1520_PAD(11, I2C3_SCL,      I2C,  ____, ____, GPIO, ____, 
____, 0),
---

Best regards
Thomas



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: Typo in pinctrl-th1520.c
  2026-01-14 15:20 Typo in pinctrl-th1520.c Thomas Gerner
@ 2026-01-15 19:03 ` Drew Fustini
  2026-01-15 19:16   ` Thomas Gerner
  0 siblings, 1 reply; 9+ messages in thread
From: Drew Fustini @ 2026-01-15 19:03 UTC (permalink / raw)
  To: Thomas Gerner; +Cc: Guo Ren, Fu Wei, Linus Walleij, linux-riscv

On Wed, Jan 14, 2026 at 04:20:17PM +0100, Thomas Gerner wrote:
> Hello,
> 
> in the pincontrol file for the TH1520 SOC a pad is named wrong. According to
> TH1520 System User Manual, chapter 3.2.1 (page 38) pad 8 in pad group 3 is
> named QSPI0_D3_HOLD. With the wrong name QSPI1_D3_HOLD one cannot select the
> right pad in a device tree because the name is not unique. QSPI1_D3_HOLD is
> defined in pad group 2. This patch fixes the the pad name.
> 
> diff --git a/drivers/pinctrl/pinctrl-th1520.c
> b/drivers/pinctrl/pinctrl-th1520.c
> index e641bad6728c..83e9c9f77370 100644
> --- a/drivers/pinctrl/pinctrl-th1520.c
> +++ b/drivers/pinctrl/pinctrl-th1520.c
> @@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc
> th1520_group3_pins[] = {
>         TH1520_PAD(5,  QSPI0_D0_MOSI, QSPI, PWM,  I2S,  GPIO, ____, ____,
> 0),
>         TH1520_PAD(6,  QSPI0_D1_MISO, QSPI, PWM,  I2S,  GPIO, ____, ____,
> 0),
>         TH1520_PAD(7,  QSPI0_D2_WP,   QSPI, PWM,  I2S,  GPIO, ____, ____,
> 0),
> -       TH1520_PAD(8,  QSPI1_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____,
> 0),
> +       TH1520_PAD(8,  QSPI0_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____,
> 0),
>         TH1520_PAD(9,  I2C2_SCL,      I2C,  UART, ____, GPIO, ____, ____,
> 0),
>         TH1520_PAD(10, I2C2_SDA,      I2C,  UART, ____, GPIO, ____, ____,
> 0),
>         TH1520_PAD(11, I2C3_SCL,      I2C,  ____, ____, GPIO, ____, ____,
> 0),
> ---
> 
> Best regards
> Thomas

Hello, thank you catching this and providing a fix. The change looks
correct me, but I believe there is something wrong with the patch.

Did you just paste a diff into an email?

I would suggest using git send-email. KernelNewbies [1] has some good
tips as well as Nick's guide [2].

Thanks,
Drew

[1] https://kernelnewbies.org/FirstKernelPatch
[2] https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: Typo in pinctrl-th1520.c
  2026-01-15 19:03 ` Drew Fustini
@ 2026-01-15 19:16   ` Thomas Gerner
  2026-01-19  9:00     ` Linus Walleij
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gerner @ 2026-01-15 19:16 UTC (permalink / raw)
  To: Drew Fustini; +Cc: Guo Ren, Fu Wei, Linus Walleij, linux-riscv

Hi,

Am 15.01.26 um 20:03 schrieb Drew Fustini:
> On Wed, Jan 14, 2026 at 04:20:17PM +0100, Thomas Gerner wrote:
>> Hello,
>>
>> in the pincontrol file for the TH1520 SOC a pad is named wrong. According to
>> TH1520 System User Manual, chapter 3.2.1 (page 38) pad 8 in pad group 3 is
>> named QSPI0_D3_HOLD. With the wrong name QSPI1_D3_HOLD one cannot select the
>> right pad in a device tree because the name is not unique. QSPI1_D3_HOLD is
>> defined in pad group 2. This patch fixes the the pad name.
>>
>> diff --git a/drivers/pinctrl/pinctrl-th1520.c
>> b/drivers/pinctrl/pinctrl-th1520.c
>> index e641bad6728c..83e9c9f77370 100644
>> --- a/drivers/pinctrl/pinctrl-th1520.c
>> +++ b/drivers/pinctrl/pinctrl-th1520.c
>> @@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc
>> th1520_group3_pins[] = {
>>          TH1520_PAD(5,  QSPI0_D0_MOSI, QSPI, PWM,  I2S,  GPIO, ____, ____,
>> 0),
>>          TH1520_PAD(6,  QSPI0_D1_MISO, QSPI, PWM,  I2S,  GPIO, ____, ____,
>> 0),
>>          TH1520_PAD(7,  QSPI0_D2_WP,   QSPI, PWM,  I2S,  GPIO, ____, ____,
>> 0),
>> -       TH1520_PAD(8,  QSPI1_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____,
>> 0),
>> +       TH1520_PAD(8,  QSPI0_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____,
>> 0),
>>          TH1520_PAD(9,  I2C2_SCL,      I2C,  UART, ____, GPIO, ____, ____,
>> 0),
>>          TH1520_PAD(10, I2C2_SDA,      I2C,  UART, ____, GPIO, ____, ____,
>> 0),
>>          TH1520_PAD(11, I2C3_SCL,      I2C,  ____, ____, GPIO, ____, ____,
>> 0),
>> ---
>>
>> Best regards
>> Thomas
> Hello, thank you catching this and providing a fix. The change looks
> correct me, but I believe there is something wrong with the patch.
>
> Did you just paste a diff into an email?
>
> I would suggest using git send-email. KernelNewbies [1] has some good
> tips as well as Nick's guide [2].

Yes, I pasted the patch to Thunderbird and it looks the mail client 
reformatted the mail during send. However, the fix is only a single 
letter and can be done easily with an simple text editor, just change 
QSPI1 to QSPI0 in the line of pad 8.

I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next 
time when I send a patch I will use git send-email.

Best regards
Thomas

> Thanks,
> Drew
>
> [1] https://kernelnewbies.org/FirstKernelPatch
> [2] https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: Typo in pinctrl-th1520.c
  2026-01-15 19:16   ` Thomas Gerner
@ 2026-01-19  9:00     ` Linus Walleij
  2026-01-19 13:55       ` [PATCH] " Thomas Gerner
  0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2026-01-19  9:00 UTC (permalink / raw)
  To: thomas.gerner; +Cc: Drew Fustini, Guo Ren, Fu Wei, linux-riscv

On Thu, Jan 15, 2026 at 8:16 PM Thomas Gerner
<thomas.gerner@muenchen-mail.de> wrote:
> [Drew]:
> > Hello, thank you catching this and providing a fix. The change looks
> > correct me, but I believe there is something wrong with the patch.
> >
> > Did you just paste a diff into an email?
> >
> > I would suggest using git send-email. KernelNewbies [1] has some good
> > tips as well as Nick's guide [2].
>
> Yes, I pasted the patch to Thunderbird and it looks the mail client
> reformatted the mail during send. However, the fix is only a single
> letter and can be done easily with an simple text editor, just change
> QSPI1 to QSPI0 in the line of pad 8.
>
> I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next
> time when I send a patch I will use git send-email.

Will you send a proper patch for this?

Otherwise perhaps Drew can send a proper patch to fix this bug
so I can apply it?

Yours,
Linus Walleij

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] Re: Typo in pinctrl-th1520.c
  2026-01-19  9:00     ` Linus Walleij
@ 2026-01-19 13:55       ` Thomas Gerner
  2026-01-19 14:32         ` Linus Walleij
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gerner @ 2026-01-19 13:55 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Drew Fustini, Guo Ren, Fu Wei, linux-riscv, Thomas Gerner

On Mon, 19 Jan 2026 at 10:00:06 +0100 Linus Walleij wrote

> On Thu, Jan 15, 2026 at 8:16=E2=80=AFPM Thomas Gerner
> <thomas.gerner@muenchen-mail.de> wrote:
> 
> > I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next
> > time when I send a patch I will use git send-email.
>
> Will you send a proper patch for this?
>
> Otherwise perhaps Drew can send a proper patch to fix this bug
> so I can apply it?

I hope this time the patch is proper formatted.

---
 drivers/pinctrl/pinctrl-th1520.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-th1520.c b/drivers/pinctrl/pinctrl-th1520.c
index e641bad6728c..83e9c9f77370 100644
--- a/drivers/pinctrl/pinctrl-th1520.c
+++ b/drivers/pinctrl/pinctrl-th1520.c
@@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc th1520_group3_pins[] = {
 	TH1520_PAD(5,  QSPI0_D0_MOSI, QSPI, PWM,  I2S,  GPIO, ____, ____, 0),
 	TH1520_PAD(6,  QSPI0_D1_MISO, QSPI, PWM,  I2S,  GPIO, ____, ____, 0),
 	TH1520_PAD(7,  QSPI0_D2_WP,   QSPI, PWM,  I2S,  GPIO, ____, ____, 0),
-	TH1520_PAD(8,  QSPI1_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____, 0),
+	TH1520_PAD(8,  QSPI0_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____, 0),
 	TH1520_PAD(9,  I2C2_SCL,      I2C,  UART, ____, GPIO, ____, ____, 0),
 	TH1520_PAD(10, I2C2_SDA,      I2C,  UART, ____, GPIO, ____, ____, 0),
 	TH1520_PAD(11, I2C3_SCL,      I2C,  ____, ____, GPIO, ____, ____, 0),
-- 
2.43.0

Best regards
Thomas


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Re: Typo in pinctrl-th1520.c
  2026-01-19 13:55       ` [PATCH] " Thomas Gerner
@ 2026-01-19 14:32         ` Linus Walleij
  2026-01-19 15:20           ` Thomas Gerner
  0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2026-01-19 14:32 UTC (permalink / raw)
  To: Thomas Gerner; +Cc: Drew Fustini, Guo Ren, Fu Wei, linux-riscv

On Mon, Jan 19, 2026 at 2:56 PM Thomas Gerner
<thomas.gerner@muenchen-mail.de> wrote:
> On Mon, 19 Jan 2026 at 10:00:06 +0100 Linus Walleij wrote
>
> > On Thu, Jan 15, 2026 at 8:16=E2=80=AFPM Thomas Gerner
> > <thomas.gerner@muenchen-mail.de> wrote:
> >
> > > I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next
> > > time when I send a patch I will use git send-email.
> >
> > Will you send a proper patch for this?
> >
> > Otherwise perhaps Drew can send a proper patch to fix this bug
> > so I can apply it?
>
> I hope this time the patch is proper formatted.

Nah it doesn't work... but I could fix that up if you send it again
and provide your "Signed-off-by" because otherwise I cannot legally
apply it.

Yours,
Linus Walleij

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] Re: Typo in pinctrl-th1520.c
  2026-01-19 14:32         ` Linus Walleij
@ 2026-01-19 15:20           ` Thomas Gerner
  2026-01-20 10:10             ` Linus Walleij
  2026-02-20  4:10             ` patchwork-bot+linux-riscv
  0 siblings, 2 replies; 9+ messages in thread
From: Thomas Gerner @ 2026-01-19 15:20 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Drew Fustini, Guo Ren, Fu Wei, linux-riscv, Thomas Gerner


On 19.01.26 at 15:32 Linus Walleij wrote:
> On Mon, Jan 19, 2026 at 2:56 PM Thomas Gerner
> <thomas.gerner@muenchen-mail.de> wrote:
>> On Mon, 19 Jan 2026 at 10:00:06 +0100 Linus Walleij wrote
>>
>>> On Thu, Jan 15, 2026 at 8:16 Thomas Gerner
>>> <thomas.gerner@muenchen-mail.de> wrote:
>>>
>>>> I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next
>>>> time when I send a patch I will use git send-email.
>>>
>>> Will you send a proper patch for this?
>>>
>>> Otherwise perhaps Drew can send a proper patch to fix this bug
>>> so I can apply it?
>>
>> I hope this time the patch is proper formatted.
>
> Nah it doesn't work... but I could fix that up if you send it again
> and provide your "Signed-off-by" because otherwise I cannot legally
> apply it.
>

Hopefully this time everything is okay.

Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de>
---
 drivers/pinctrl/pinctrl-th1520.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-th1520.c b/drivers/pinctrl/pinctrl-th1520.c
index e641bad6728c..83e9c9f77370 100644
--- a/drivers/pinctrl/pinctrl-th1520.c
+++ b/drivers/pinctrl/pinctrl-th1520.c
@@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc th1520_group3_pins[] = {
 	TH1520_PAD(5,  QSPI0_D0_MOSI, QSPI, PWM,  I2S,  GPIO, ____, ____, 0),
 	TH1520_PAD(6,  QSPI0_D1_MISO, QSPI, PWM,  I2S,  GPIO, ____, ____, 0),
 	TH1520_PAD(7,  QSPI0_D2_WP,   QSPI, PWM,  I2S,  GPIO, ____, ____, 0),
-	TH1520_PAD(8,  QSPI1_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____, 0),
+	TH1520_PAD(8,  QSPI0_D3_HOLD, QSPI, ____, I2S,  GPIO, ____, ____, 0),
 	TH1520_PAD(9,  I2C2_SCL,      I2C,  UART, ____, GPIO, ____, ____, 0),
 	TH1520_PAD(10, I2C2_SDA,      I2C,  UART, ____, GPIO, ____, ____, 0),
 	TH1520_PAD(11, I2C3_SCL,      I2C,  ____, ____, GPIO, ____, ____, 0),
-- 
2.43.0

Best regards
Thomas


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Re: Typo in pinctrl-th1520.c
  2026-01-19 15:20           ` Thomas Gerner
@ 2026-01-20 10:10             ` Linus Walleij
  2026-02-20  4:10             ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-01-20 10:10 UTC (permalink / raw)
  To: Thomas Gerner; +Cc: Drew Fustini, Guo Ren, Fu Wei, linux-riscv

On Mon, Jan 19, 2026 at 4:20 PM Thomas Gerner
<thomas.gerner@muenchen-mail.de> wrote:
> On 19.01.26 at 15:32 Linus Walleij wrote:
> > On Mon, Jan 19, 2026 at 2:56 PM Thomas Gerner
> > <thomas.gerner@muenchen-mail.de> wrote:
> >> On Mon, 19 Jan 2026 at 10:00:06 +0100 Linus Walleij wrote
> >>
> >>> On Thu, Jan 15, 2026 at 8:16 Thomas Gerner
> >>> <thomas.gerner@muenchen-mail.de> wrote:
> >>>
> >>>> I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next
> >>>> time when I send a patch I will use git send-email.
> >>>
> >>> Will you send a proper patch for this?
> >>>
> >>> Otherwise perhaps Drew can send a proper patch to fix this bug
> >>> so I can apply it?
> >>
> >> I hope this time the patch is proper formatted.
> >
> > Nah it doesn't work... but I could fix that up if you send it again
> > and provide your "Signed-off-by" because otherwise I cannot legally
> > apply it.
> >
>
> Hopefully this time everything is okay.
>
> Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de>

Fixed up, added title and commit message and applied for fixes!

Yours,
Linus Walleij

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Re: Typo in pinctrl-th1520.c
  2026-01-19 15:20           ` Thomas Gerner
  2026-01-20 10:10             ` Linus Walleij
@ 2026-02-20  4:10             ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 9+ messages in thread
From: patchwork-bot+linux-riscv @ 2026-02-20  4:10 UTC (permalink / raw)
  To: Thomas Gerner; +Cc: linux-riscv, linusw, fustini, guoren, wefu

Hello:

This patch was applied to riscv/linux.git (fixes)
by Linus Walleij <linusw@kernel.org>:

On Mon, 19 Jan 2026 16:20:02 +0100 you wrote:
> On 19.01.26 at 15:32 Linus Walleij wrote:
> > On Mon, Jan 19, 2026 at 2:56 PM Thomas Gerner
> > <thomas.gerner@muenchen-mail.de> wrote:
> >> On Mon, 19 Jan 2026 at 10:00:06 +0100 Linus Walleij wrote
> >>
> >>> On Thu, Jan 15, 2026 at 8:16 Thomas Gerner
> >>> <thomas.gerner@muenchen-mail.de> wrote:
> >>>
> >>>> I'm new in working on the Linux kernel because of my BeagleV-Ahead. Next
> >>>> time when I send a patch I will use git send-email.
> >>>
> >>> Will you send a proper patch for this?
> >>>
> >>> Otherwise perhaps Drew can send a proper patch to fix this bug
> >>> so I can apply it?
> >>
> >> I hope this time the patch is proper formatted.
> >
> > Nah it doesn't work... but I could fix that up if you send it again
> > and provide your "Signed-off-by" because otherwise I cannot legally
> > apply it.
> >
> 
> [...]

Here is the summary with links:
  - Re: Typo in pinctrl-th1520.c
    https://git.kernel.org/riscv/c/304c3ebcaff3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-02-20  4:11 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-14 15:20 Typo in pinctrl-th1520.c Thomas Gerner
2026-01-15 19:03 ` Drew Fustini
2026-01-15 19:16   ` Thomas Gerner
2026-01-19  9:00     ` Linus Walleij
2026-01-19 13:55       ` [PATCH] " Thomas Gerner
2026-01-19 14:32         ` Linus Walleij
2026-01-19 15:20           ` Thomas Gerner
2026-01-20 10:10             ` Linus Walleij
2026-02-20  4:10             ` patchwork-bot+linux-riscv

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.