From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: Vinod Koul <vkoul@kernel.org>
Cc: gregkh@linuxfoundation.org, conor@kernel.org,
neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY
Date: Wed, 21 Jan 2026 21:55:10 +0800 [thread overview]
Message-ID: <aXDavrU8ATmUyWHE@duge-virtual-machine> (raw)
In-Reply-To: <aXB7GqQaxtgKReVa@vaman>
On Wed, Jan 21, 2026 at 12:37:06PM +0530, Vinod Koul wrote:
> On 20-01-26, 22:32, Jiayu Du wrote:
> > + * Copyright (C) 2025 Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
>
> 2026 now!
>
...
> > + void __iomem *base = global->base;
> > + u32 val;
>
> blank line here please
>
...
> > + /* Configure test register (pull-ups/pull-downs) */
>
> wrong alignment above, pls fix it
Thanks for pointing out these issues. I will fix them in v5.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: Vinod Koul <vkoul@kernel.org>
Cc: gregkh@linuxfoundation.org, conor@kernel.org,
neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY
Date: Wed, 21 Jan 2026 21:55:10 +0800 [thread overview]
Message-ID: <aXDavrU8ATmUyWHE@duge-virtual-machine> (raw)
In-Reply-To: <aXB7GqQaxtgKReVa@vaman>
On Wed, Jan 21, 2026 at 12:37:06PM +0530, Vinod Koul wrote:
> On 20-01-26, 22:32, Jiayu Du wrote:
> > + * Copyright (C) 2025 Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
>
> 2026 now!
>
...
> > + void __iomem *base = global->base;
> > + u32 val;
>
> blank line here please
>
...
> > + /* Configure test register (pull-ups/pull-downs) */
>
> wrong alignment above, pls fix it
Thanks for pointing out these issues. I will fix them in v5.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: Vinod Koul <vkoul@kernel.org>
Cc: gregkh@linuxfoundation.org, conor@kernel.org,
neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY
Date: Wed, 21 Jan 2026 21:55:10 +0800 [thread overview]
Message-ID: <aXDavrU8ATmUyWHE@duge-virtual-machine> (raw)
In-Reply-To: <aXB7GqQaxtgKReVa@vaman>
On Wed, Jan 21, 2026 at 12:37:06PM +0530, Vinod Koul wrote:
> On 20-01-26, 22:32, Jiayu Du wrote:
> > + * Copyright (C) 2025 Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
>
> 2026 now!
>
...
> > + void __iomem *base = global->base;
> > + u32 val;
>
> blank line here please
>
...
> > + /* Configure test register (pull-ups/pull-downs) */
>
> wrong alignment above, pls fix it
Thanks for pointing out these issues. I will fix them in v5.
next prev parent reply other threads:[~2026-01-21 13:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 14:32 [PATCH v4 0/4] Add USB support for Canaan K230 Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` [PATCH v4 1/4] dt-bindings: phy: Add Canaan K230 USB PHY Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-21 2:28 ` Rob Herring (Arm)
2026-01-21 2:28 ` Rob Herring (Arm)
2026-01-21 2:28 ` Rob Herring (Arm)
2026-01-20 14:32 ` [PATCH v4 2/4] dt-bindings: usb: dwc2: Add support for Canaan K230 SoC Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` [PATCH v4 3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-21 7:07 ` Vinod Koul
2026-01-21 7:07 ` Vinod Koul
2026-01-21 7:07 ` Vinod Koul
2026-01-21 13:55 ` Jiayu Du [this message]
2026-01-21 13:55 ` Jiayu Du
2026-01-21 13:55 ` Jiayu Du
2026-01-20 14:32 ` [PATCH v4 4/4] riscv: dts: canaan: Add syscon and USB nodes for K230 Jiayu Du
2026-01-20 14:32 ` Jiayu Du
2026-01-20 14:32 ` Jiayu Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXDavrU8ATmUyWHE@duge-virtual-machine \
--to=jiayu.riscv@isrc.iscas.ac.cn \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.