From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4 7/8] x86/HPET: drop .set_affinity hook
Date: Thu, 22 Jan 2026 11:05:08 +0100 [thread overview]
Message-ID: <aXH2VGI_gtiAKfF9@Mac.lan> (raw)
In-Reply-To: <5e09670f-dd80-4dfe-a8d6-182545b744ee@suse.com>
On Mon, Nov 17, 2025 at 03:39:50PM +0100, Jan Beulich wrote:
> No IRQ balancing is supposed to be happening on the broadcast IRQs. The
> only entity responsible for fiddling with the CPU affinities is
> set_channel_irq_affinity(). They shouldn't even be fiddled with when
> offlining a CPU: A CPU going down can't at the same time be idle. Some
> properties (->arch.cpu_mask in particular) may transiently reference an
> offline CPU, but that'll be adjusted as soon as a channel goes into active
> use again.
Hm, we where likely pointlessly migrating the HPET vector in
fixup_irqs() previous to this change, but such movement shouldn't be
fatal, just pointless.
> Along with adjusting fixup_irqs() (in a more general way, i.e. covering all
> vectors which are marked in use globally), also adjust section placement of
> used_vectors.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2026-01-22 10:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 14:35 [PATCH v4 0/8] x86/HPET: tidying / improvements Jan Beulich
2025-11-17 14:37 ` [PATCH v4 1/8] x86/HPET: avoid indirect call to event handler Jan Beulich
2026-01-21 16:19 ` Roger Pau Monné
2025-11-17 14:37 ` [PATCH v4 2/8] x86/HPET: make another channel flags update atomic Jan Beulich
2026-01-21 17:55 ` Roger Pau Monné
2025-11-17 14:37 ` [PATCH v4 3/8] x86/HPET: move legacy tick IRQ count adjustment Jan Beulich
2026-01-22 8:50 ` Roger Pau Monné
2026-01-22 10:31 ` Jan Beulich
2026-01-22 11:21 ` Roger Pau Monné
2025-11-17 14:38 ` [PATCH v4 4/8] x86/HPET: reduce hpet_next_event() call sites Jan Beulich
2026-01-22 9:00 ` Roger Pau Monné
2025-11-17 14:39 ` [PATCH v4 5/8] x86/HPET: drop "long timeout" handling from reprogram_hpet_evt_channel() Jan Beulich
2026-01-22 9:03 ` Roger Pau Monné
2026-01-22 9:23 ` Jan Beulich
2025-11-17 14:39 ` [PATCH v4 6/8] x86/HPET: simplify "expire" check a little in reprogram_hpet_evt_channel() Jan Beulich
2026-01-22 9:18 ` Roger Pau Monné
2026-01-22 9:28 ` Jan Beulich
2026-01-22 10:10 ` Roger Pau Monné
2026-01-22 10:15 ` Jan Beulich
2026-01-22 11:30 ` Roger Pau Monné
2026-01-22 12:50 ` Jan Beulich
2025-11-17 14:39 ` [PATCH v4 7/8] x86/HPET: drop .set_affinity hook Jan Beulich
2026-01-22 10:05 ` Roger Pau Monné [this message]
2025-11-17 14:40 ` [PATCH v4 8/8] x86/HPET: don't arbitrarily cap delta in reprogram_hpet_evt_channel() Jan Beulich
2026-01-22 10:23 ` Roger Pau Monné
2026-01-22 10:35 ` Jan Beulich
2026-01-22 11:29 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXH2VGI_gtiAKfF9@Mac.lan \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.