* [PATCH] binder: fix BR_FROZEN_REPLY error log
@ 2026-01-23 17:57 Carlos Llamas
2026-01-26 9:15 ` Alice Ryhl
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Llamas @ 2026-01-23 17:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Christian Brauner, Carlos Llamas, Alice Ryhl
Cc: kernel-team, linux-kernel, stable, Steven Moreland, Todd Kjos
The error logging for failed transactions is misleading as it always
reports "dead process or thread" even when the target is actually
frozen. Additionally, the pid and tid are reversed which can further
confuse debugging efforts. Fix both issues.
Cc: stable@kernel.org
Cc: Steven Moreland <smoreland@google.com>
Fixes: a15dac8b2286 ("binder: additional transaction error logs")
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
drivers/android/binder.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 535fc881c8da..2837162e73e8 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3812,8 +3812,9 @@ static void binder_transaction(struct binder_proc *proc,
return;
err_dead_proc_or_thread:
- binder_txn_error("%d:%d dead process or thread\n",
- thread->pid, proc->pid);
+ binder_txn_error("%d:%d %s process or thread\n",
+ proc->pid, thread->pid,
+ return_error == BR_FROZEN_REPLY ? "frozen" : "dead");
return_error_line = __LINE__;
binder_dequeue_work(proc, tcomplete);
err_translate_failed:
--
2.52.0.457.g6b5491de43-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] binder: fix BR_FROZEN_REPLY error log
2026-01-23 17:57 [PATCH] binder: fix BR_FROZEN_REPLY error log Carlos Llamas
@ 2026-01-26 9:15 ` Alice Ryhl
0 siblings, 0 replies; 2+ messages in thread
From: Alice Ryhl @ 2026-01-26 9:15 UTC (permalink / raw)
To: Carlos Llamas
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Christian Brauner, kernel-team, linux-kernel, stable,
Steven Moreland, Todd Kjos
On Fri, Jan 23, 2026 at 05:57:02PM +0000, Carlos Llamas wrote:
> The error logging for failed transactions is misleading as it always
> reports "dead process or thread" even when the target is actually
> frozen. Additionally, the pid and tid are reversed which can further
> confuse debugging efforts. Fix both issues.
>
> Cc: stable@kernel.org
> Cc: Steven Moreland <smoreland@google.com>
> Fixes: a15dac8b2286 ("binder: additional transaction error logs")
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-26 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-23 17:57 [PATCH] binder: fix BR_FROZEN_REPLY error log Carlos Llamas
2026-01-26 9:15 ` Alice Ryhl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.