From: Florian Westphal <fw@strlen.de>
To: Brian Witte <brianwitte@mailfence.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] datatype: fix ether address parsing of integer values
Date: Mon, 26 Jan 2026 13:08:21 +0100 [thread overview]
Message-ID: <aXdZNS1fL36NL5vB@strlen.de> (raw)
In-Reply-To: <20260126061746.368011-1-brianwitte@mailfence.com>
Brian Witte <brianwitte@mailfence.com> wrote:
> When parsing "ether daddr 0x64", integer_expr converts the hex value
> to decimal string "100". lladdr_type_parse then interprets this as
> hex, yielding 0x100 = 256 which exceeds the single-byte limit.
Yes, but it looks like it breaks backwards compatibility.
'ether daddr 99' is parsed as 00:00:00:00:00:99.
After your patch, its parsed as 00:00:00:00:00:63.
So I'm not sure we can fix this.
next prev parent reply other threads:[~2026-01-26 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 6:17 [nft PATCH] datatype: fix ether address parsing of integer values Brian Witte
2026-01-26 12:08 ` Florian Westphal [this message]
2026-01-26 17:38 ` Brian Witte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXdZNS1fL36NL5vB@strlen.de \
--to=fw@strlen.de \
--cc=brianwitte@mailfence.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.