All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH linux-next] perf test: Fix test perf evlist for z/VM s390x
@ 2026-01-26 10:18 Thomas Richter
  2026-01-26 17:42 ` Ian Rogers
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Richter @ 2026-01-26 10:18 UTC (permalink / raw)
  To: linux-kernel, linux-s390, linux-perf-users, acme, namhyung,
	irogers
  Cc: agordeev, gor, sumanthk, hca, japo, Thomas Richter

Perf test case 'perf evlist tests' fails on z/VM machines on s390.

The failure is causes by event cycles. This event is not available
on virtualized machines like z/VM on s390.
Change to software event cpu-clock to fix this.

    Output before:
      # ./perf test 78
      79: perf evlist tests              : FAILED!
      #

    Output after:
      # ./perf test 78
      79: perf evlist tests              : Ok
      #

Fixes: b04d2b919912 ("perf test: Fix test case perf evlist tests for s390x")
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Tested-by: Jan Polensky <japo@linux.ibm.com>
Reviewed-by: Jan Polensky <japo@linux.ibm.com>
Cc: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/shell/evlist.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/shell/evlist.sh b/tools/perf/tests/shell/evlist.sh
index 5632be391710..8a22f4171c07 100755
--- a/tools/perf/tests/shell/evlist.sh
+++ b/tools/perf/tests/shell/evlist.sh
@@ -21,13 +21,13 @@ trap trap_cleanup EXIT TERM INT
 
 test_evlist_simple() {
 	echo "Simple evlist test"
-	if ! perf record -e cycles -o "${perfdata}" true 2> /dev/null
+	if ! perf record -e cpu-clock -o "${perfdata}" true 2> /dev/null
 	then
 		echo "Simple evlist [Failed record]"
 		err=1
 		return
 	fi
-	if ! perf evlist -i "${perfdata}" | grep -q "cycles"
+	if ! perf evlist -i "${perfdata}" | grep -q "cpu-clock"
 	then
 		echo "Simple evlist [Failed to list event]"
 		err=1
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH linux-next] perf test: Fix test perf evlist for z/VM s390x
  2026-01-26 10:18 [PATCH linux-next] perf test: Fix test perf evlist for z/VM s390x Thomas Richter
@ 2026-01-26 17:42 ` Ian Rogers
  2026-01-26 20:34   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2026-01-26 17:42 UTC (permalink / raw)
  To: Thomas Richter
  Cc: linux-kernel, linux-s390, linux-perf-users, acme, namhyung,
	agordeev, gor, sumanthk, hca, japo

On Mon, Jan 26, 2026 at 2:18 AM Thomas Richter <tmricht@linux.ibm.com> wrote:
>
> Perf test case 'perf evlist tests' fails on z/VM machines on s390.
>
> The failure is causes by event cycles. This event is not available
> on virtualized machines like z/VM on s390.
> Change to software event cpu-clock to fix this.
>
>     Output before:
>       # ./perf test 78
>       79: perf evlist tests              : FAILED!
>       #
>
>     Output after:
>       # ./perf test 78
>       79: perf evlist tests              : Ok
>       #
>
> Fixes: b04d2b919912 ("perf test: Fix test case perf evlist tests for s390x")
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> Tested-by: Jan Polensky <japo@linux.ibm.com>
> Reviewed-by: Jan Polensky <japo@linux.ibm.com>
> Cc: Ian Rogers <irogers@google.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks!
Ian

> ---
>  tools/perf/tests/shell/evlist.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/evlist.sh b/tools/perf/tests/shell/evlist.sh
> index 5632be391710..8a22f4171c07 100755
> --- a/tools/perf/tests/shell/evlist.sh
> +++ b/tools/perf/tests/shell/evlist.sh
> @@ -21,13 +21,13 @@ trap trap_cleanup EXIT TERM INT
>
>  test_evlist_simple() {
>         echo "Simple evlist test"
> -       if ! perf record -e cycles -o "${perfdata}" true 2> /dev/null
> +       if ! perf record -e cpu-clock -o "${perfdata}" true 2> /dev/null
>         then
>                 echo "Simple evlist [Failed record]"
>                 err=1
>                 return
>         fi
> -       if ! perf evlist -i "${perfdata}" | grep -q "cycles"
> +       if ! perf evlist -i "${perfdata}" | grep -q "cpu-clock"
>         then
>                 echo "Simple evlist [Failed to list event]"
>                 err=1
> --
> 2.52.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH linux-next] perf test: Fix test perf evlist for z/VM s390x
  2026-01-26 17:42 ` Ian Rogers
@ 2026-01-26 20:34   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-01-26 20:34 UTC (permalink / raw)
  To: Ian Rogers
  Cc: Thomas Richter, linux-kernel, linux-s390, linux-perf-users,
	namhyung, agordeev, gor, sumanthk, hca, japo

On Mon, Jan 26, 2026 at 09:42:54AM -0800, Ian Rogers wrote:
> On Mon, Jan 26, 2026 at 2:18 AM Thomas Richter <tmricht@linux.ibm.com> wrote:
> >
> > Perf test case 'perf evlist tests' fails on z/VM machines on s390.
> >
> > The failure is causes by event cycles. This event is not available
> > on virtualized machines like z/VM on s390.
> > Change to software event cpu-clock to fix this.
> >
> >     Output before:
> >       # ./perf test 78
> >       79: perf evlist tests              : FAILED!
> >       #
> >
> >     Output after:
> >       # ./perf test 78
> >       79: perf evlist tests              : Ok
> >       #
> >
> > Fixes: b04d2b919912 ("perf test: Fix test case perf evlist tests for s390x")
> > Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> > Tested-by: Jan Polensky <japo@linux.ibm.com>
> > Reviewed-by: Jan Polensky <japo@linux.ibm.com>
> > Cc: Ian Rogers <irogers@google.com>

> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next,

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-26 20:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 10:18 [PATCH linux-next] perf test: Fix test perf evlist for z/VM s390x Thomas Richter
2026-01-26 17:42 ` Ian Rogers
2026-01-26 20:34   ` Arnaldo Carvalho de Melo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.