* [PATCH] rust/hpet: remove stale TODO comment
@ 2026-01-26 21:09 Mohd Kashif Khan
2026-01-27 8:12 ` Zhao Liu
2026-01-27 9:37 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Mohd Kashif Khan @ 2026-01-26 21:09 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-rust, Mohd Kashif Khan
The irq binding is already implemented in the following line, so the TODO comment is obsolete.
Signed-off-by: Mohd Kashif Khan <kashif04x@gmail.com>
---
rust/hw/timer/hpet/src/device.rs | 1 -
1 file changed, 1 deletion(-)
diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/device.rs
index 4757bf5fd5..ebf715d399 100644
--- a/rust/hw/timer/hpet/src/device.rs
+++ b/rust/hw/timer/hpet/src/device.rs
@@ -725,7 +725,6 @@ fn set_cfg_reg(&self, regs: &mut HPETRegisters, shift: u32, len: u32, val: u64)
self.irqs[0].lower();
self.irqs[RTC_ISA_IRQ].lower();
} else if deactivating_bit(old_val, new_val, HPET_CFG_LEG_RT_SHIFT) {
- // TODO: Add irq binding: qemu_irq_lower(s->irqs[0])
self.irqs[0].lower();
self.pit_enabled.set(true);
self.irqs[RTC_ISA_IRQ].set(self.rtc_irq_level.get() != 0);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust/hpet: remove stale TODO comment
2026-01-26 21:09 [PATCH] rust/hpet: remove stale TODO comment Mohd Kashif Khan
@ 2026-01-27 8:12 ` Zhao Liu
2026-01-27 9:37 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Zhao Liu @ 2026-01-27 8:12 UTC (permalink / raw)
To: Mohd Kashif Khan; +Cc: qemu-devel, qemu-rust, Paolo Bonzini
On Tue, Jan 27, 2026 at 02:39:10AM +0530, Mohd Kashif Khan wrote:
> Date: Tue, 27 Jan 2026 02:39:10 +0530
> From: Mohd Kashif Khan <kashif04x@gmail.com>
> Subject: [PATCH] rust/hpet: remove stale TODO comment
> X-Mailer: git-send-email 2.43.0
>
> The irq binding is already implemented in the following line, so the TODO comment is obsolete.
>
> Signed-off-by: Mohd Kashif Khan <kashif04x@gmail.com>
> ---
> rust/hw/timer/hpet/src/device.rs | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust/hpet: remove stale TODO comment
2026-01-26 21:09 [PATCH] rust/hpet: remove stale TODO comment Mohd Kashif Khan
2026-01-27 8:12 ` Zhao Liu
@ 2026-01-27 9:37 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2026-01-27 9:37 UTC (permalink / raw)
To: Mohd Kashif Khan; +Cc: qemu-devel, qemu-rust
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-27 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 21:09 [PATCH] rust/hpet: remove stale TODO comment Mohd Kashif Khan
2026-01-27 8:12 ` Zhao Liu
2026-01-27 9:37 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.